diff options
| author | Nicholas Baron <nicholas.baron.ten@gmail.com> | 2021-05-16 02:36:52 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-16 10:36:52 +0100 |
| commit | aa4d41fe2c473c3bb78327a1dbe8ec85530259ca (patch) | |
| tree | 925d408b37ab1f7750a3af37adfb2949fcafa836 /Kernel/Syscalls/kill.cpp | |
| parent | bbaa4630323c20e37e2a0ead478987cb5f02fc53 (diff) | |
| download | serenity-aa4d41fe2c473c3bb78327a1dbe8ec85530259ca.zip | |
AK+Kernel+LibELF: Remove the need for `IteratorDecision::Continue`
By constraining two implementations, the compiler will select the best
fitting one. All this will require is duplicating the implementation and
simplifying for the `void` case.
This constraining also informs both the caller and compiler by passing
the callback parameter types as part of the constraint
(e.g.: `IterationFunction<int>`).
Some `for_each` functions in LibELF only take functions which return
`void`. This is a minimal correctness check, as it removes one way for a
function to incompletely do something.
There seems to be a possible idiom where inside a lambda, a `return;` is
the same as `continue;` in a for-loop.
Diffstat (limited to 'Kernel/Syscalls/kill.cpp')
| -rw-r--r-- | Kernel/Syscalls/kill.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/Kernel/Syscalls/kill.cpp b/Kernel/Syscalls/kill.cpp index 6ce69b7217..d1a4181a3d 100644 --- a/Kernel/Syscalls/kill.cpp +++ b/Kernel/Syscalls/kill.cpp @@ -47,8 +47,6 @@ KResult Process::do_killpg(ProcessGroupID pgrp, int signal) any_succeeded = true; else error = res; - - return IterationDecision::Continue; }); if (group_was_empty) |