Kernel: Dispatch pending signals when returning from a syscall

It was quite easy to put the system into a heavy churn state by doing
e.g "cat /dev/zero".

It was then basically impossible to kill the "cat" process, even with
"kill -9", since signals are only delivered in two conditions:

a) The target thread is blocked in the kernel
b) The target thread is running in userspace

However, since "cat /dev/zero" command spends most of its time actively
running in the kernel, not blocked, the signal dispatch code just kept
postponing actually handling the signal indefinitely.

To fix this, we now check before returning from a syscall if there are
any pending unmasked signals, and if so, we take a dramatic pause by
blocking the current thread, knowing it will immediately be unblocked
by signal dispatch anyway. :^)

1 files changed, 3 insertions, 0 deletions

diff --git a/Kernel/Syscall.cpp b/Kernel/Syscall.cpp
index e4e39d6769..0a9cd38f3c 100644
--- a/Kernel/Syscall.cpp
+++ b/Kernel/Syscall.cpp
@@ -135,4 +135,7 @@ void syscall_handler(RegisterDump regs)
 
     // Check if we're supposed to return to userspace or just die.
     current->die_if_needed();
+
+    if (current->has_unmasked_pending_signals())
+        (void)current->block<Thread::SemiPermanentBlocker>(Thread::SemiPermanentBlocker::Reason::Signal);
 }