summaryrefslogtreecommitdiff
path: root/Kernel/Storage
diff options
context:
space:
mode:
authorLiav A <liavalb@gmail.com>2022-01-23 20:24:02 +0200
committerLinus Groh <mail@linusgroh.de>2022-01-23 20:56:28 +0000
commite0aaac970c9c295b9afe0d20096b7d0fe29ddba5 (patch)
treefbb1577ae3dfb8beef02a6aa2ea74dee9f0946b9 /Kernel/Storage
parent4597e980fe5d6073b437d1aebc5171089f31e225 (diff)
downloadserenity-e0aaac970c9c295b9afe0d20096b7d0fe29ddba5.zip
Kernel/Storage: Don't declare NVMeQueue constructor explicit
Also, declare it as a private method.
Diffstat (limited to 'Kernel/Storage')
-rw-r--r--Kernel/Storage/NVMe/NVMeQueue.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/Kernel/Storage/NVMe/NVMeQueue.h b/Kernel/Storage/NVMe/NVMeQueue.h
index 9140213c59..fdec1be7a4 100644
--- a/Kernel/Storage/NVMe/NVMeQueue.h
+++ b/Kernel/Storage/NVMe/NVMeQueue.h
@@ -31,7 +31,6 @@ class NVMeQueue : public IRQHandler
public:
static ErrorOr<NonnullRefPtr<NVMeQueue>> try_create(u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> cq_dma_page, OwnPtr<Memory::Region> sq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> sq_dma_page, Memory::TypedMapping<volatile DoorbellRegister> db_regs);
ErrorOr<void> create();
- explicit NVMeQueue(u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> cq_dma_page, OwnPtr<Memory::Region> sq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> sq_dma_page, Memory::TypedMapping<volatile DoorbellRegister> db_regs);
bool is_admin_queue() { return m_admin_queue; };
void submit_sqe(NVMeSubmission&);
u16 submit_sync_sqe(NVMeSubmission&);
@@ -41,6 +40,8 @@ public:
void disable_interrupts() { disable_irq(); };
private:
+ NVMeQueue(u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> cq_dma_page, OwnPtr<Memory::Region> sq_dma_region, NonnullRefPtrVector<Memory::PhysicalPage> sq_dma_page, Memory::TypedMapping<volatile DoorbellRegister> db_regs);
+
virtual bool handle_irq(const RegisterState&) override;
bool cqe_available();