Kernel: Don't use references or pointers to physical addresses

Now the ACPI & PCI code is more safer, because we don't use raw pointers
or references to objects or data that are located in the physical
address space, so an accidental dereference cannot happen easily.
Instead, we use the PhysicalAddress class to represent those addresses.

1 files changed, 3 insertions, 6 deletions

diff --git a/Kernel/PCI/Initializer.cpp b/Kernel/PCI/Initializer.cpp
index 1b5d258344..3dd4c04638 100644
--- a/Kernel/PCI/Initializer.cpp
+++ b/Kernel/PCI/Initializer.cpp
@@ -44,7 +44,7 @@ PCI::Initializer& PCI::Initializer::the()
     }
     return *s_pci_initializer;
 }
-void PCI::Initializer::initialize_pci_mmio_access(ACPI_RAW::MCFG& mcfg)
+void PCI::Initializer::initialize_pci_mmio_access(PhysicalAddress mcfg)
 {
     PCI::MMIOAccess::initialize(mcfg);
     detect_devices();
@@ -129,15 +129,12 @@ bool PCI::Initializer::test_pci_io()
 
 bool PCI::Initializer::test_pci_mmio()
 {
-    if (ACPIParser::the().find_table("MCFG") != nullptr)
-        return true;
-    else
-        return false;
+    return !ACPIParser::the().find_table("MCFG").is_null();
 }
 
 void PCI::Initializer::initialize_pci_mmio_access_after_test()
 {
-    initialize_pci_mmio_access(*(ACPI_RAW::MCFG*)(ACPIParser::the().find_table("MCFG")));
+    initialize_pci_mmio_access(ACPIParser::the().find_table("MCFG"));
 }
 
 void PCI::Initializer::dismiss()