diff options
| author | Brian Gianforcaro <bgianf@serenityos.org> | 2021-05-14 23:01:07 -0700 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2021-05-15 09:46:50 +0200 |
| commit | f25599334994a5a9e22b2f3cbe036f9bf822f13a (patch) | |
| tree | 276860d2e605d4aea6848660f811cec70009bc2b /Kernel/Net/NetworkTask.cpp | |
| parent | d76dedb381275613f2c5fa655c59973770dfcf39 (diff) | |
| download | serenity-f25599334994a5a9e22b2f3cbe036f9bf822f13a.zip | |
Kernel: Log unexpected TCP packet flags in NetworkTask handle_tcp()
Occasionally we'll see messages in the serial console like:
handle_tcp: unexpected flags in FinWait1 state
In these cases it would be nice to know what flags we are receiving that
we aren't expecting.
Diffstat (limited to 'Kernel/Net/NetworkTask.cpp')
| -rw-r--r-- | Kernel/Net/NetworkTask.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/Kernel/Net/NetworkTask.cpp b/Kernel/Net/NetworkTask.cpp index 7e95cf3f4f..87ec1dd4d8 100644 --- a/Kernel/Net/NetworkTask.cpp +++ b/Kernel/Net/NetworkTask.cpp @@ -428,7 +428,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) return; } default: - dbgln("handle_tcp: unexpected flags in Listen state"); + dbgln("handle_tcp: unexpected flags in Listen state ({:x})", tcp_packet.flags()); // socket->send_tcp_packet(TCPFlags::RST); return; } @@ -461,7 +461,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) socket->set_setup_state(Socket::SetupState::Completed); return; default: - dbgln("handle_tcp: unexpected flags in SynSent state"); + dbgln("handle_tcp: unexpected flags in SynSent state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); socket->set_error(TCPSocket::Error::UnexpectedFlagsDuringConnect); @@ -500,7 +500,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) return; default: - dbgln("handle_tcp: unexpected flags in SynReceived state"); + dbgln("handle_tcp: unexpected flags in SynReceived state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; @@ -508,7 +508,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) case TCPSocket::State::CloseWait: switch (tcp_packet.flags()) { default: - dbgln("handle_tcp: unexpected flags in CloseWait state"); + dbgln("handle_tcp: unexpected flags in CloseWait state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; @@ -520,7 +520,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) socket->set_state(TCPSocket::State::Closed); return; default: - dbgln("handle_tcp: unexpected flags in LastAck state"); + dbgln("handle_tcp: unexpected flags in LastAck state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; @@ -536,7 +536,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) socket->set_state(TCPSocket::State::Closing); return; default: - dbgln("handle_tcp: unexpected flags in FinWait1 state"); + dbgln("handle_tcp: unexpected flags in FinWait1 state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; @@ -551,7 +551,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) socket->set_state(TCPSocket::State::Closed); return; default: - dbgln("handle_tcp: unexpected flags in FinWait2 state"); + dbgln("handle_tcp: unexpected flags in FinWait2 state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; @@ -563,7 +563,7 @@ void handle_tcp(const IPv4Packet& ipv4_packet, const Time& packet_timestamp) socket->set_state(TCPSocket::State::TimeWait); return; default: - dbgln("handle_tcp: unexpected flags in Closing state"); + dbgln("handle_tcp: unexpected flags in Closing state ({:x})", tcp_packet.flags()); unused_rc = socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return; |