summaryrefslogtreecommitdiff
path: root/Kernel/KBuffer.h
diff options
context:
space:
mode:
authorLenny Maiorani <lenny@colorado.edu>2021-01-10 16:29:28 -0700
committerAndreas Kling <kling@serenityos.org>2021-01-12 09:11:45 +0100
commite6f907a1556757c623fe660df0a43faf1b3d0eae (patch)
treea3a07081ec2ebdac050d776c61d2c908459bf343 /Kernel/KBuffer.h
parent9dc44bf8c427160bafd87205c42201cf9b11c0b4 (diff)
downloadserenity-e6f907a1556757c623fe660df0a43faf1b3d0eae.zip
AK: Simplify constructors and conversions from nullptr_t
Problem: - Many constructors are defined as `{}` rather than using the ` = default` compiler-provided constructor. - Some types provide an implicit conversion operator from `nullptr_t` instead of requiring the caller to default construct. This violates the C++ Core Guidelines suggestion to declare single-argument constructors explicit (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit). Solution: - Change default constructors to use the compiler-provided default constructor. - Remove implicit conversion operators from `nullptr_t` and change usage to enforce type consistency without conversion.
Diffstat (limited to 'Kernel/KBuffer.h')
-rw-r--r--Kernel/KBuffer.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/Kernel/KBuffer.h b/Kernel/KBuffer.h
index 53ad60bf88..665610571a 100644
--- a/Kernel/KBuffer.h
+++ b/Kernel/KBuffer.h
@@ -128,7 +128,7 @@ public:
{
auto impl = KBufferImpl::try_create_with_size(size, access, name, strategy);
if (!impl)
- return nullptr;
+ return {};
return adopt_own(*new KBuffer(impl.release_nonnull()));
}
@@ -136,7 +136,7 @@ public:
{
auto impl = KBufferImpl::try_create_with_bytes(bytes, access, name, strategy);
if (!impl)
- return nullptr;
+ return {};
return adopt_own(*new KBuffer(impl.release_nonnull()));
}