diff options
author | Nicholas-Baron <nicholas.baron.ten@gmail.com> | 2021-04-15 10:43:29 -0700 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-04-15 20:57:13 +0200 |
commit | c4ede3854236244fbcefd66b56579c9608ff0664 (patch) | |
tree | 58bf4a4c1973003c398f488589154030bae50d31 /Kernel/Interrupts/InterruptManagement.h | |
parent | b75d2d36e12d4f32c448b4ae352a8b5cc14f00a6 (diff) | |
download | serenity-c4ede3854236244fbcefd66b56579c9608ff0664.zip |
Everything: Add `-Wnon-virtual-dtor` flag
This flag warns on classes which have `virtual` functions but do not
have a `virtual` destructor.
This patch adds both the flag and missing destructors. The access level
of the destructors was determined by a two rules of thumb:
1. A destructor should have a similar or lower access level to that of a
constructor.
2. Having a `private` destructor implicitly deletes the default
constructor, which is probably undesirable for "interface" types
(classes with only virtual functions and no data).
In short, most of the added destructors are `protected`, unless the
compiler complained about access.
Diffstat (limited to 'Kernel/Interrupts/InterruptManagement.h')
-rw-r--r-- | Kernel/Interrupts/InterruptManagement.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/Kernel/Interrupts/InterruptManagement.h b/Kernel/Interrupts/InterruptManagement.h index 89f24780ec..15db486964 100644 --- a/Kernel/Interrupts/InterruptManagement.h +++ b/Kernel/Interrupts/InterruptManagement.h @@ -83,6 +83,9 @@ public: void enumerate_interrupt_handlers(Function<void(GenericInterruptHandler&)>); IRQController& get_interrupt_controller(int index); +protected: + virtual ~InterruptManagement() = default; + private: InterruptManagement(); PhysicalAddress search_for_madt(); |