diff options
| author | Liav A <liavalb@gmail.com> | 2021-08-21 06:55:25 +0300 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2021-08-23 01:07:45 +0200 |
| commit | 7b9c3439ec1d4d0c2122897fdfeb72fe52814d7a (patch) | |
| tree | 96c1bf1a4ef695ba2f5d4308001cd372daf4dc84 /Kernel/Devices | |
| parent | d071ce352c3fd9a6f21dc9c6e17626269ec15bc4 (diff) | |
| download | serenity-7b9c3439ec1d4d0c2122897fdfeb72fe52814d7a.zip | |
Kernel/PCI: Delete PCI::Device in its current form
I created this class a long time ago just to be able to quickly make a
PCI device to also represent an interrupt handler (because PCI devices
have this capability for most devices).
Then after a while I introduced the PCI::DeviceController, which is
really almost the same thing (a PCI device class that has Address member
in it), but is not tied to interrupts so it can have no interrupts, or
spawn interrupt handlers however it wants to seems fit.
However I decided it's time to say goodbye for this class for
a couple of reasons:
1. It made a whole bunch of weird patterns where you had a PCI::Device
and a PCI::DeviceController being used in the topic of implementation,
where originally, they meant to be used mutually exclusively (you
can't and really don't want to use both).
2. We can really make all the classes that inherit from PCI::Device
to inherit from IRQHandler at this point. Later on, when we have MSI
interrupts support, we can go further and untie things even more.
3. It makes it possible to simplify the VirtIO implementation to a great
extent. While this commit almost doesn't change it, future changes
can untangle some complexity in the VirtIO code.
For UHCIController, E1000NetworkAdapter, NE2000NetworkAdapter,
RTL8139NetworkAdapter, RTL8168NetworkAdapter, E1000ENetworkAdapter we
are simply making them to inherit the IRQHandler. This makes some sense,
because the first 3 devices will never support anything besides IRQs.
For the last 2, they might have MSI support, so when we start to utilize
those, we might need to untie these classes from IRQHandler and spawn
IRQHandler(s) or MSIHandler(s) as needed.
The VirtIODevice class is also a case where we currently need to use
both PCI::DeviceController and IRQHandler classes as parents, but it
could also be untied from the latter.
Diffstat (limited to 'Kernel/Devices')
| -rw-r--r-- | Kernel/Devices/PCISerialDevice.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Kernel/Devices/PCISerialDevice.h b/Kernel/Devices/PCISerialDevice.h index 34beb5942b..88dbc74b3f 100644 --- a/Kernel/Devices/PCISerialDevice.h +++ b/Kernel/Devices/PCISerialDevice.h @@ -6,7 +6,7 @@ #pragma once -#include <Kernel/Bus/PCI/Device.h> +#include <Kernel/Bus/PCI/DeviceController.h> #include <Kernel/Bus/PCI/IDs.h> #include <Kernel/Devices/CharacterDevice.h> #include <Kernel/Devices/SerialDevice.h> |