diff options
author | Andreas Kling <kling@serenityos.org> | 2021-11-03 16:48:42 +0100 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-11-03 16:48:42 +0100 |
commit | 652042e680bffb9c466187ce295c2a6bb4d43a0b (patch) | |
tree | e8689d51e4df8885a9c94f5f514011f56867962f /Kernel/Devices | |
parent | 82d79349594992607aa773aac15de91d24848feb (diff) | |
download | serenity-652042e680bffb9c466187ce295c2a6bb4d43a0b.zip |
Revert "Kernel: Prevent VMWareMouseDevice from handling invalid mouse packets"
This reverts commit 4131b3585164761e3841bb1c9609b302658ee2c0.
We're swallowing way too many mouse events from QEMU with this code
enabled. Something is not right, so let's revert it for now.
Diffstat (limited to 'Kernel/Devices')
-rw-r--r-- | Kernel/Devices/HID/VMWareMouseDevice.cpp | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/Kernel/Devices/HID/VMWareMouseDevice.cpp b/Kernel/Devices/HID/VMWareMouseDevice.cpp index 05ba5f0d19..f2a6908153 100644 --- a/Kernel/Devices/HID/VMWareMouseDevice.cpp +++ b/Kernel/Devices/HID/VMWareMouseDevice.cpp @@ -25,11 +25,10 @@ UNMAP_AFTER_INIT RefPtr<VMWareMouseDevice> VMWareMouseDevice::try_to_initialize( return {}; } -void VMWareMouseDevice::irq_handle_byte_read(u8 byte) +void VMWareMouseDevice::irq_handle_byte_read(u8) { VERIFY(VMWareBackdoor::the()); VERIFY(VMWareBackdoor::the()->vmmouse_is_absolute()); - // We won't receive complete packets with the backdoor enabled, // we will only get one byte for each event, which we'll just // discard. If we were to wait until we *think* that we got a @@ -37,12 +36,6 @@ void VMWareMouseDevice::irq_handle_byte_read(u8 byte) // because we wouldn't read the appropriate number of mouse // packets from VMWareBackdoor. auto mouse_packet = VMWareBackdoor::the()->receive_mouse_packet(); - - // Only process packets with bit 3 set. - // Note that this needs to happen _after_ invoking receive_mouse_packet() above - if (!(byte & 0x8)) - return; - if (mouse_packet.has_value()) { m_entropy_source.add_random_event(mouse_packet.value()); { |