summaryrefslogtreecommitdiff
path: root/Kernel/Devices/HID
diff options
context:
space:
mode:
authorLiav A <liavalb@gmail.com>2021-08-14 07:01:19 +0300
committerAndreas Kling <kling@serenityos.org>2021-09-08 00:42:20 +0200
commit21b6d84ff071779a90e351e9959c80e09193ec89 (patch)
treee545cf3e5b278bf0b258a97ccaca70d8c4590eed /Kernel/Devices/HID
parent4f04cb98c1281ca7658ab60569898a5f83afc7b7 (diff)
downloadserenity-21b6d84ff071779a90e351e9959c80e09193ec89.zip
Kernel/Devices: Remove required_mode and device_name methods
These methods are no longer needed because SystemServer is able to populate the DevFS on its own. Device absolute_path no longer assume a path to the /dev location, because it really should not assume any path to a Device node. Because StorageManagement still needs to know the storage name, we declare a virtual method only for StorageDevices to override, but this technique should really be removed later on.
Diffstat (limited to 'Kernel/Devices/HID')
-rw-r--r--Kernel/Devices/HID/KeyboardDevice.h5
-rw-r--r--Kernel/Devices/HID/MouseDevice.h5
2 files changed, 0 insertions, 10 deletions
diff --git a/Kernel/Devices/HID/KeyboardDevice.h b/Kernel/Devices/HID/KeyboardDevice.h
index 6065474523..05353fe345 100644
--- a/Kernel/Devices/HID/KeyboardDevice.h
+++ b/Kernel/Devices/HID/KeyboardDevice.h
@@ -33,14 +33,9 @@ public:
// ^HIDDevice
virtual Type instrument_type() const override { return Type::Keyboard; }
- // ^Device
- virtual mode_t required_mode() const override { return 0440; }
-
// ^File
virtual KResult ioctl(OpenFileDescription&, unsigned request, Userspace<void*> arg) override;
- virtual String device_name() const override { return String::formatted("keyboard{}", minor()); }
-
void update_modifier(u8 modifier, bool state)
{
if (state)
diff --git a/Kernel/Devices/HID/MouseDevice.h b/Kernel/Devices/HID/MouseDevice.h
index 73105f9e89..6df59de9d7 100644
--- a/Kernel/Devices/HID/MouseDevice.h
+++ b/Kernel/Devices/HID/MouseDevice.h
@@ -31,11 +31,6 @@ public:
// ^HIDDevice
virtual Type instrument_type() const override { return Type::Mouse; }
- // ^Device
- virtual mode_t required_mode() const override { return 0440; }
-
- virtual String device_name() const override { return String::formatted("mouse{}", minor()); }
-
protected:
MouseDevice();
// ^CharacterDevice