diff options
author | Pankaj Raghav <pankydev8@gmail.com> | 2022-01-06 22:01:05 +0530 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2022-01-09 00:45:38 +0100 |
commit | 0a1b34c753e83632688e925a7971ab5d08ffa605 (patch) | |
tree | 69377177de15bf03f19b56c87de61ad1fc2634a3 /Kernel/Devices/Audio | |
parent | 59da9bd0bdf249108cb9628cb417a117c14f7e71 (diff) | |
download | serenity-0a1b34c753e83632688e925a7971ab5d08ffa605.zip |
Kernel: Use DMA helper everywhere
Port UCHI, AC97, SB16, BMIDEChannel and AHCIPort to use the helper to
allocate DMA buffers.
Diffstat (limited to 'Kernel/Devices/Audio')
-rw-r--r-- | Kernel/Devices/Audio/AC97.cpp | 11 | ||||
-rw-r--r-- | Kernel/Devices/Audio/SB16.cpp | 7 |
2 files changed, 3 insertions, 15 deletions
diff --git a/Kernel/Devices/Audio/AC97.cpp b/Kernel/Devices/Audio/AC97.cpp index f8b6f419f1..6951e19807 100644 --- a/Kernel/Devices/Audio/AC97.cpp +++ b/Kernel/Devices/Audio/AC97.cpp @@ -20,13 +20,6 @@ static constexpr u16 pcm_fixed_sample_rate = 48000; static constexpr u16 pcm_sample_rate_minimum = 8000; static constexpr u16 pcm_sample_rate_maximum = 48000; -static ErrorOr<OwnPtr<Memory::Region>> allocate_physical_buffer(size_t size, StringView name) -{ - auto rounded_size = TRY(Memory::page_round_up(size)); - auto vmobject = TRY(Memory::AnonymousVMObject::try_create_physically_contiguous_with_size(rounded_size)); - return TRY(MM.allocate_kernel_region_with_vmobject(move(vmobject), vmobject->size(), name, Memory::Region::Access::Write)); -} - UNMAP_AFTER_INIT void AC97::detect() { PCI::enumerate([&](PCI::DeviceIdentifier const& device_identifier) { @@ -204,11 +197,11 @@ void AC97::set_pcm_output_volume(u8 left_channel, u8 right_channel, Muted mute) ErrorOr<size_t> AC97::write(OpenFileDescription&, u64, UserOrKernelBuffer const& data, size_t length) { if (!m_output_buffer) { - m_output_buffer = TRY(allocate_physical_buffer(m_output_buffer_page_count * PAGE_SIZE, "AC97 Output buffer"sv)); + m_output_buffer = TRY(MM.allocate_dma_buffer_pages(m_output_buffer_page_count * PAGE_SIZE, "AC97 Output buffer"sv, Memory::Region::Access::Write)); } if (!m_buffer_descriptor_list) { constexpr size_t buffer_descriptor_list_size = buffer_descriptor_list_max_entries * sizeof(BufferDescriptorListEntry); - m_buffer_descriptor_list = TRY(allocate_physical_buffer(buffer_descriptor_list_size, "AC97 Buffer Descriptor List"sv)); + m_buffer_descriptor_list = TRY(MM.allocate_dma_buffer_pages(buffer_descriptor_list_size, "AC97 Buffer Descriptor List"sv, Memory::Region::Access::Write)); } auto remaining = length; diff --git a/Kernel/Devices/Audio/SB16.cpp b/Kernel/Devices/Audio/SB16.cpp index ce2cdc8d63..7256db1807 100644 --- a/Kernel/Devices/Audio/SB16.cpp +++ b/Kernel/Devices/Audio/SB16.cpp @@ -252,12 +252,7 @@ void SB16::wait_for_irq() ErrorOr<size_t> SB16::write(OpenFileDescription&, u64, UserOrKernelBuffer const& data, size_t length) { if (!m_dma_region) { - auto page = MM.allocate_supervisor_physical_page(); - if (!page) - return ENOMEM; - auto nonnull_page = page.release_nonnull(); - auto vmobject = TRY(Memory::AnonymousVMObject::try_create_with_physical_pages({ &nonnull_page, 1 })); - m_dma_region = TRY(MM.allocate_kernel_region_with_vmobject(move(vmobject), PAGE_SIZE, "SB16 DMA buffer", Memory::Region::Access::Write)); + m_dma_region = TRY(MM.allocate_dma_buffer_page("SB16 DMA buffer", Memory::Region::Access::Write)); } dbgln_if(SB16_DEBUG, "SB16: Writing buffer of {} bytes", length); |