diff options
| author | Itamar <itamar8910@gmail.com> | 2020-11-13 22:38:58 +0200 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2020-12-14 23:05:53 +0100 |
| commit | 39890af833e1bb06136b0e761b1df026d97b264b (patch) | |
| tree | aa6b29218a4cd15227caa0f9009a75cf1c618710 /Kernel/CoreDump.cpp | |
| parent | dfdd977a823e643bf9952acd1f59a2ef78816732 (diff) | |
| download | serenity-39890af833e1bb06136b0e761b1df026d97b264b.zip | |
Kernel: Pass full path of output coredump file to CoreDump
Diffstat (limited to 'Kernel/CoreDump.cpp')
| -rw-r--r-- | Kernel/CoreDump.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/Kernel/CoreDump.cpp b/Kernel/CoreDump.cpp index e65c64e47c..5e44b33e61 100644 --- a/Kernel/CoreDump.cpp +++ b/Kernel/CoreDump.cpp @@ -40,9 +40,9 @@ namespace Kernel { -OwnPtr<CoreDump> CoreDump::create(Process& process) +OwnPtr<CoreDump> CoreDump::create(Process& process, const LexicalPath& output_path) { - auto fd = create_target_file(process); + auto fd = create_target_file(process, output_path); if (!fd) return nullptr; return make<CoreDump>(process, fd.release_nonnull()); @@ -59,19 +59,19 @@ CoreDump::~CoreDump() { } -RefPtr<FileDescription> CoreDump::create_target_file(const Process& process) +RefPtr<FileDescription> CoreDump::create_target_file(const Process& process, const LexicalPath& output_path) { - static constexpr const char* coredumps_directory = "/tmp/coredump"; - if (VFS::the().open_directory(coredumps_directory, VFS::the().root_custody()).is_error()) { - auto res = VFS::the().mkdir(coredumps_directory, 0777, VFS::the().root_custody()); + auto output_directory = output_path.dirname(); + if (VFS::the().open_directory(output_directory, VFS::the().root_custody()).is_error()) { + auto res = VFS::the().mkdir(output_directory, 0777, VFS::the().root_custody()); if (res.is_error()) return nullptr; } - auto tmp_dir = VFS::the().open_directory(coredumps_directory, VFS::the().root_custody()); + auto tmp_dir = VFS::the().open_directory(output_directory, VFS::the().root_custody()); if (tmp_dir.is_error()) return nullptr; auto fd_or_error = VFS::the().open( - String::format("%s_%u.core", process.name().characters(), RTC::now()), + output_path.basename(), O_CREAT | O_WRONLY | O_EXCL, 0, // We will enable reading from userspace when we finish generating the coredump file *tmp_dir.value(), |