diff options
author | Hendiadyoin1 <leon2002.la@gmail.com> | 2021-12-08 13:39:17 +0100 |
---|---|---|
committer | Brian Gianforcaro <b.gianfo@gmail.com> | 2021-12-09 22:53:42 -0800 |
commit | 5adf5f4dee012a0e67535da2d7a622096e8d2f3c (patch) | |
tree | c0c73f771e240f7299e216dd80f8c492c7c22a17 /Kernel/Bus/PCI/SysFSPCI.h | |
parent | de26dd253b2bc9d66d814db74403f790dd0c8719 (diff) | |
download | serenity-5adf5f4dee012a0e67535da2d7a622096e8d2f3c.zip |
Kernel: Construct PCIDeviceAttributeSysFSComponent with StringViews
There is no use to create a temporary String of a char const* to just
cast it to a StringView on SysFSComponent construction again.
Also this could have lead to a UAF bug.
Diffstat (limited to 'Kernel/Bus/PCI/SysFSPCI.h')
-rw-r--r-- | Kernel/Bus/PCI/SysFSPCI.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Kernel/Bus/PCI/SysFSPCI.h b/Kernel/Bus/PCI/SysFSPCI.h index ac589c69ca..a1cd2f19cb 100644 --- a/Kernel/Bus/PCI/SysFSPCI.h +++ b/Kernel/Bus/PCI/SysFSPCI.h @@ -34,14 +34,14 @@ private: class PCIDeviceAttributeSysFSComponent : public SysFSComponent { public: - static NonnullRefPtr<PCIDeviceAttributeSysFSComponent> create(String name, const PCIDeviceSysFSDirectory& device, PCI::RegisterOffset offset, size_t field_bytes_width); + static NonnullRefPtr<PCIDeviceAttributeSysFSComponent> create(StringView name, const PCIDeviceSysFSDirectory& device, PCI::RegisterOffset offset, size_t field_bytes_width); virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const override; virtual ~PCIDeviceAttributeSysFSComponent() {}; protected: ErrorOr<NonnullOwnPtr<KBuffer>> try_to_generate_buffer() const; - PCIDeviceAttributeSysFSComponent(String name, const PCIDeviceSysFSDirectory& device, PCI::RegisterOffset offset, size_t field_bytes_width); + PCIDeviceAttributeSysFSComponent(StringView name, const PCIDeviceSysFSDirectory& device, PCI::RegisterOffset offset, size_t field_bytes_width); NonnullRefPtr<PCIDeviceSysFSDirectory> m_device; PCI::RegisterOffset m_offset; size_t m_field_bytes_width; |