summaryrefslogtreecommitdiff
path: root/Kernel/Arch/x86/common/Processor.cpp
diff options
context:
space:
mode:
authorDaniel Bertalan <dani@danielbertalan.dev>2021-08-29 19:31:22 +0200
committerAndreas Kling <kling@serenityos.org>2021-08-30 13:20:34 +0200
commit779cf49f38e237191e9403b8e2ab463a14080bed (patch)
tree683fa4ff9259c7c1264de41171c51bc089fbd507 /Kernel/Arch/x86/common/Processor.cpp
parentf0b3aa033134b788a28fe8cf8ff6028d0e7941e8 (diff)
downloadserenity-779cf49f38e237191e9403b8e2ab463a14080bed.zip
Kernel: Fix Clang not initializing `s_bsp_processor` correctly
Initializing the variable this way fixes a kernel panic in Clang where the object was zero-initialized, so the `m_in_scheduler` contained the wrong value. GCC got it right, but we're better off making this change, as leaving uninitialized fields in constant-initialized objects can cause other weird situations like this. Also, initializing only a single field to a non-zero value isn't worth the cost of no longer fitting in `.bss`. Another two variables suffer from the same problem, even though their values are supposed to be zero. Removing these causes the `_GLOBAL_sub_I_` function to no longer be generated and the (not handled) `.init_array` section to be omitted.
Diffstat (limited to 'Kernel/Arch/x86/common/Processor.cpp')
-rw-r--r--Kernel/Arch/x86/common/Processor.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/Kernel/Arch/x86/common/Processor.cpp b/Kernel/Arch/x86/common/Processor.cpp
index 1b8de25d1b..11affd1bed 100644
--- a/Kernel/Arch/x86/common/Processor.cpp
+++ b/Kernel/Arch/x86/common/Processor.cpp
@@ -305,6 +305,7 @@ UNMAP_AFTER_INIT void Processor::early_initialize(u32 cpu)
m_invoke_scheduler_async = false;
m_scheduler_initialized = false;
+ m_in_scheduler = true;
m_message_queue = nullptr;
m_idle_thread = nullptr;