LibGUI: Turn GUI::Application::the() into a pointer

During app teardown, the Application object may be destroyed before
something else, and so having Application::the() return a reference was
obscuring the truth about its lifetime.

This patch makes the API more honest by returning a pointer. While
this makes call sites look a bit more sketchy, do note that the global
Application pointer only becomes null during app teardown.

2 files changed, 2 insertions, 2 deletions

diff --git a/Games/Minesweeper/main.cpp b/Games/Minesweeper/main.cpp
index 4f7ce5468f..8556815d89 100644
--- a/Games/Minesweeper/main.cpp
+++ b/Games/Minesweeper/main.cpp
@@ -104,7 +104,7 @@ int main(int argc, char** argv)
     app_menu.add_separator();
 
     app_menu.add_action(GUI::CommonActions::make_quit_action([](auto&) {
-        GUI::Application::the().quit(0);
+        GUI::Application::the()->quit();
         return;
     }));
 
diff --git a/Games/Snake/main.cpp b/Games/Snake/main.cpp
index ad24a3449e..6abc482e66 100644
--- a/Games/Snake/main.cpp
+++ b/Games/Snake/main.cpp
@@ -65,7 +65,7 @@ int main(int argc, char** argv)
         game.reset();
     }));
     app_menu.add_action(GUI::CommonActions::make_quit_action([](auto&) {
-        GUI::Application::the().quit(0);
+        GUI::Application::the()->quit();
     }));
 
     auto& help_menu = menubar->add_menu("Help");