summaryrefslogtreecommitdiff
path: root/DevTools
diff options
context:
space:
mode:
authorBen Wiederhake <BenWiederhake.GitHub@gmx.de>2020-09-18 09:49:51 +0200
committerAndreas Kling <kling@serenityos.org>2020-09-25 21:18:17 +0200
commit25488ddcad0b5f112eb67530e4f0368f23f694fd (patch)
treefd1b9aab124482ef0d481e3cfe224809a653b6b4 /DevTools
parentb3909ac0ddd6a66c304be6910bcd33e490a6a11d (diff)
downloadserenity-25488ddcad0b5f112eb67530e4f0368f23f694fd.zip
Meta+DevTools: Make clang-format-10 clean
Diffstat (limited to 'DevTools')
-rw-r--r--DevTools/HackStudio/AutoCompleteBox.cpp2
-rw-r--r--DevTools/HackStudio/CMakeLists.txt1
-rw-r--r--DevTools/HackStudio/Debugger/DebugInfoWidget.cpp2
-rw-r--r--DevTools/HackStudio/Debugger/DebugInfoWidget.h2
-rw-r--r--DevTools/HackStudio/Debugger/DisassemblyWidget.cpp2
-rw-r--r--DevTools/HackStudio/Debugger/DisassemblyWidget.h2
-rw-r--r--DevTools/HackStudio/FindInFilesWidget.cpp2
-rw-r--r--DevTools/HackStudio/FindInFilesWidget.h2
-rw-r--r--DevTools/HackStudio/Git/GitFilesModel.h2
-rw-r--r--DevTools/HackStudio/Git/GitWidget.h2
-rw-r--r--DevTools/HackStudio/Tool.cpp26
-rw-r--r--DevTools/Inspector/RemoteObject.h2
-rw-r--r--DevTools/Profiler/DisassemblyModel.h12
-rw-r--r--DevTools/Profiler/Profile.cpp3
-rw-r--r--DevTools/Profiler/ProfileModel.h1
-rw-r--r--DevTools/VisualBuilder/VBPropertiesWindow.cpp6
-rw-r--r--DevTools/VisualBuilder/VBWidget.cpp6
-rw-r--r--DevTools/VisualBuilder/VBWidget.h2
18 files changed, 24 insertions, 53 deletions
diff --git a/DevTools/HackStudio/AutoCompleteBox.cpp b/DevTools/HackStudio/AutoCompleteBox.cpp
index 82f0190894..444a83038e 100644
--- a/DevTools/HackStudio/AutoCompleteBox.cpp
+++ b/DevTools/HackStudio/AutoCompleteBox.cpp
@@ -72,7 +72,7 @@ private:
Vector<String> m_suggestions;
};
-AutoCompleteBox::~AutoCompleteBox() {}
+AutoCompleteBox::~AutoCompleteBox() { }
AutoCompleteBox::AutoCompleteBox(WeakPtr<Editor> editor)
: m_editor(move(editor))
diff --git a/DevTools/HackStudio/CMakeLists.txt b/DevTools/HackStudio/CMakeLists.txt
index 356de87621..d695e0a523 100644
--- a/DevTools/HackStudio/CMakeLists.txt
+++ b/DevTools/HackStudio/CMakeLists.txt
@@ -26,7 +26,6 @@ set(SOURCES
Project.cpp
ProjectFile.cpp
TerminalWrapper.cpp
- Tool.cpp
WidgetTool.cpp
WidgetTreeModel.cpp
main.cpp
diff --git a/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp b/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp
index 843d7ef339..c44fba80cc 100644
--- a/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp
+++ b/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp
@@ -66,7 +66,7 @@ void DebugInfoWidget::init_toolbar()
pthread_mutex_unlock(Debugger::the().continue_mutex());
});
- m_step_out_action = GUI::Action::create("Step Out", { Mod_Shift, Key_F11 },Gfx::Bitmap::load_from_file("/res/icons/16x16/debug-step-out.png"), [](auto&) {
+ m_step_out_action = GUI::Action::create("Step Out", { Mod_Shift, Key_F11 }, Gfx::Bitmap::load_from_file("/res/icons/16x16/debug-step-out.png"), [](auto&) {
pthread_mutex_lock(Debugger::the().continue_mutex());
Debugger::the().set_continue_type(Debugger::ContinueType::SourceStepOut);
pthread_cond_signal(Debugger::the().continue_cond());
diff --git a/DevTools/HackStudio/Debugger/DebugInfoWidget.h b/DevTools/HackStudio/Debugger/DebugInfoWidget.h
index db432522a6..efc6f4b958 100644
--- a/DevTools/HackStudio/Debugger/DebugInfoWidget.h
+++ b/DevTools/HackStudio/Debugger/DebugInfoWidget.h
@@ -44,7 +44,7 @@ namespace HackStudio {
class DebugInfoWidget final : public GUI::Widget {
C_OBJECT(DebugInfoWidget)
public:
- virtual ~DebugInfoWidget() override {}
+ virtual ~DebugInfoWidget() override { }
void update_state(const Debug::DebugSession&, const PtraceRegisters&);
void program_stopped();
diff --git a/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp b/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp
index 69395a5c10..893d8dac82 100644
--- a/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp
+++ b/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp
@@ -26,9 +26,9 @@
#include "DisassemblyWidget.h"
#include "DisassemblyModel.h"
-#include <LibGfx/Palette.h>
#include <LibGUI/BoxLayout.h>
#include <LibGUI/Painter.h>
+#include <LibGfx/Palette.h>
namespace HackStudio {
diff --git a/DevTools/HackStudio/Debugger/DisassemblyWidget.h b/DevTools/HackStudio/Debugger/DisassemblyWidget.h
index b84bc9fedb..77d36b0edd 100644
--- a/DevTools/HackStudio/Debugger/DisassemblyWidget.h
+++ b/DevTools/HackStudio/Debugger/DisassemblyWidget.h
@@ -29,8 +29,8 @@
#include "Debugger.h"
#include <AK/NonnullOwnPtr.h>
#include <LibGUI/Label.h>
-#include <LibGUI/TableView.h>
#include <LibGUI/Model.h>
+#include <LibGUI/TableView.h>
#include <LibGUI/Widget.h>
#include <sys/arch/i386/regs.h>
diff --git a/DevTools/HackStudio/FindInFilesWidget.cpp b/DevTools/HackStudio/FindInFilesWidget.cpp
index 764274a3a7..fe3717adb9 100644
--- a/DevTools/HackStudio/FindInFilesWidget.cpp
+++ b/DevTools/HackStudio/FindInFilesWidget.cpp
@@ -95,7 +95,7 @@ public:
return {};
}
- virtual void update() override {}
+ virtual void update() override { }
virtual GUI::ModelIndex index(int row, int column = 0, const GUI::ModelIndex& = GUI::ModelIndex()) const override { return create_index(row, column, &m_matches.at(row)); }
private:
diff --git a/DevTools/HackStudio/FindInFilesWidget.h b/DevTools/HackStudio/FindInFilesWidget.h
index ce2d28bed1..759d116374 100644
--- a/DevTools/HackStudio/FindInFilesWidget.h
+++ b/DevTools/HackStudio/FindInFilesWidget.h
@@ -35,7 +35,7 @@ namespace HackStudio {
class FindInFilesWidget final : public GUI::Widget {
C_OBJECT(FindInFilesWidget)
public:
- virtual ~FindInFilesWidget() override {}
+ virtual ~FindInFilesWidget() override { }
void focus_textbox_and_select_all();
diff --git a/DevTools/HackStudio/Git/GitFilesModel.h b/DevTools/HackStudio/Git/GitFilesModel.h
index 988be1c472..a3e1483ded 100644
--- a/DevTools/HackStudio/Git/GitFilesModel.h
+++ b/DevTools/HackStudio/Git/GitFilesModel.h
@@ -47,7 +47,7 @@ public:
virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override;
- virtual void update() override {}
+ virtual void update() override { }
virtual GUI::ModelIndex index(int row, int column, const GUI::ModelIndex&) const override;
private:
diff --git a/DevTools/HackStudio/Git/GitWidget.h b/DevTools/HackStudio/Git/GitWidget.h
index c0fea89851..a17e9f9fd4 100644
--- a/DevTools/HackStudio/Git/GitWidget.h
+++ b/DevTools/HackStudio/Git/GitWidget.h
@@ -39,7 +39,7 @@ typedef Function<void(const String& original_content, const String& diff)> ViewD
class GitWidget final : public GUI::Widget {
C_OBJECT(GitWidget)
public:
- virtual ~GitWidget() override {}
+ virtual ~GitWidget() override { }
void refresh();
void set_view_diff_callback(ViewDiffCallback callback);
diff --git a/DevTools/HackStudio/Tool.cpp b/DevTools/HackStudio/Tool.cpp
deleted file mode 100644
index 94d598cb16..0000000000
--- a/DevTools/HackStudio/Tool.cpp
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice, this
- * list of conditions and the following disclaimer.
- *
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- * this list of conditions and the following disclaimer in the documentation
- * and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
- * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
diff --git a/DevTools/Inspector/RemoteObject.h b/DevTools/Inspector/RemoteObject.h
index 89c0e93f21..5f55c77352 100644
--- a/DevTools/Inspector/RemoteObject.h
+++ b/DevTools/Inspector/RemoteObject.h
@@ -26,9 +26,9 @@
#pragma once
-#include <AK/String.h>
#include <AK/JsonObject.h>
#include <AK/NonnullOwnPtrVector.h>
+#include <AK/String.h>
#include <AK/Vector.h>
class RemoteObjectPropertyModel;
diff --git a/DevTools/Profiler/DisassemblyModel.h b/DevTools/Profiler/DisassemblyModel.h
index e4c1b6fe9d..52465d0818 100644
--- a/DevTools/Profiler/DisassemblyModel.h
+++ b/DevTools/Profiler/DisassemblyModel.h
@@ -33,12 +33,12 @@ class Profile;
class ProfileNode;
struct InstructionData {
- X86::Instruction insn;
- String disassembly;
- StringView bytes;
- FlatPtr address { 0 };
- u32 event_count { 0 };
- float percent { 0 };
+ X86::Instruction insn;
+ String disassembly;
+ StringView bytes;
+ FlatPtr address { 0 };
+ u32 event_count { 0 };
+ float percent { 0 };
};
class DisassemblyModel final : public GUI::Model {
diff --git a/DevTools/Profiler/Profile.cpp b/DevTools/Profiler/Profile.cpp
index 32c966bbb5..cb7208de07 100644
--- a/DevTools/Profiler/Profile.cpp
+++ b/DevTools/Profiler/Profile.cpp
@@ -117,8 +117,7 @@ void Profile::rebuild_tree()
ProfileNode* node = nullptr;
- auto for_each_frame = [&]<typename Callback>(Callback callback)
- {
+ auto for_each_frame = [&]<typename Callback>(Callback callback) {
if (!m_inverted) {
for (size_t i = 0; i < event.frames.size(); ++i) {
if (callback(event.frames.at(i), i == event.frames.size() - 1) == IterationDecision::Break)
diff --git a/DevTools/Profiler/ProfileModel.h b/DevTools/Profiler/ProfileModel.h
index 580d972997..9b61dd5137 100644
--- a/DevTools/Profiler/ProfileModel.h
+++ b/DevTools/Profiler/ProfileModel.h
@@ -28,7 +28,6 @@
#include <LibGUI/Model.h>
-
class Profile;
class ProfileModel final : public GUI::Model {
diff --git a/DevTools/VisualBuilder/VBPropertiesWindow.cpp b/DevTools/VisualBuilder/VBPropertiesWindow.cpp
index 7e608f6e1b..2d5eccb034 100644
--- a/DevTools/VisualBuilder/VBPropertiesWindow.cpp
+++ b/DevTools/VisualBuilder/VBPropertiesWindow.cpp
@@ -37,7 +37,7 @@ class BoolValuesModel final : public GUI::Model {
public:
virtual int row_count(const GUI::ModelIndex&) const override { return 2; }
virtual int column_count(const GUI::ModelIndex&) const override { return 1; }
- virtual void update() override {}
+ virtual void update() override { }
virtual GUI::Variant data(const GUI::ModelIndex& index, GUI::ModelRole role) const override
{
if (role != GUI::ModelRole::Display)
@@ -54,8 +54,8 @@ public:
class BoolModelEditingDelegate : public GUI::ModelEditingDelegate {
public:
- BoolModelEditingDelegate() {}
- virtual ~BoolModelEditingDelegate() override {}
+ BoolModelEditingDelegate() { }
+ virtual ~BoolModelEditingDelegate() override { }
virtual RefPtr<GUI::Widget> create_widget() override
{
diff --git a/DevTools/VisualBuilder/VBWidget.cpp b/DevTools/VisualBuilder/VBWidget.cpp
index 661a3de416..ded0920604 100644
--- a/DevTools/VisualBuilder/VBWidget.cpp
+++ b/DevTools/VisualBuilder/VBWidget.cpp
@@ -130,9 +130,9 @@ void VBWidget::add_property(const String& name, Function<GUI::Variant(const GUI:
prop.m_setter = move(setter);
}
-#define VB_ADD_PROPERTY(gclass, name, getter, setter, variant_type) \
- add_property( \
- name, \
+#define VB_ADD_PROPERTY(gclass, name, getter, setter, variant_type) \
+ add_property( \
+ name, \
[](auto& widget) -> GUI::Variant { return ((const gclass&)widget).getter(); }, \
[](auto& widget, auto& value) { ((gclass&)widget).setter(value.to_##variant_type()); })
diff --git a/DevTools/VisualBuilder/VBWidget.h b/DevTools/VisualBuilder/VBWidget.h
index 850d5584b6..137827867a 100644
--- a/DevTools/VisualBuilder/VBWidget.h
+++ b/DevTools/VisualBuilder/VBWidget.h
@@ -33,8 +33,8 @@
#include <AK/NonnullRefPtr.h>
#include <AK/RefCounted.h>
#include <AK/Weakable.h>
-#include <LibGfx/Rect.h>
#include <LibGUI/Widget.h>
+#include <LibGfx/Rect.h>
class VBForm;
class VBProperty;