diff options
| author | Andreas Kling <kling@serenityos.org> | 2020-07-04 16:52:01 +0200 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2020-07-04 16:54:55 +0200 |
| commit | ca93c22ae2706c35828f913976f35e828157bb01 (patch) | |
| tree | 6daa1e52973d55636634ceb69fc0fe15b6bd50f4 /DevTools/Profiler | |
| parent | f7577585a6794228659e5e7b496cddfd8a94b54d (diff) | |
| download | serenity-ca93c22ae2706c35828f913976f35e828157bb01.zip | |
LibGUI: Turn GUI::Application::the() into a pointer
During app teardown, the Application object may be destroyed before
something else, and so having Application::the() return a reference was
obscuring the truth about its lifetime.
This patch makes the API more honest by returning a pointer. While
this makes call sites look a bit more sketchy, do note that the global
Application pointer only becomes null during app teardown.
Diffstat (limited to 'DevTools/Profiler')
| -rw-r--r-- | DevTools/Profiler/main.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/DevTools/Profiler/main.cpp b/DevTools/Profiler/main.cpp index 20fbe4fb5c..2b0be42a15 100644 --- a/DevTools/Profiler/main.cpp +++ b/DevTools/Profiler/main.cpp @@ -144,11 +144,11 @@ bool prompt_to_stop_profiling() auto& stop_button = widget.add<GUI::Button>("Stop"); stop_button.on_click = [&](auto) { - GUI::Application::the().quit(); + GUI::Application::the()->quit(); }; window->show(); - return GUI::Application::the().exec() == 0; + return GUI::Application::the()->exec() == 0; } bool generate_profile(pid_t pid) |