summaryrefslogtreecommitdiff
path: root/CMakeLists.txt
diff options
context:
space:
mode:
authorLucas CHOLLET <lucas.chollet@free.fr>2022-12-08 14:10:55 +0100
committerAndreas Kling <kling@serenityos.org>2022-12-08 17:20:51 +0100
commit741138c5850d5c32a0558d96a1e6f6f92c70e4b1 (patch)
tree18a0497aef4fff4f8d6c71d0d97a4c1a5b32d184 /CMakeLists.txt
parentf14006637db05f8d8113b78c13fea559980e2130 (diff)
downloadserenity-741138c5850d5c32a0558d96a1e6f6f92c70e4b1.zip
LibGUI: Add a prefix to `IncrementalSearchBanner`'s widgets name
Widget's name are the current way to retrieve them when using GML. Presently, there is no way to differentiate two items that share the same name. `IncrementalSearchBanner` uses common names as "close_button" or "next_button", prepend them with `incremental_search_banner_` avoid collisions. This fixes a bug where the close button of `CrashReporter` was confused with the one of the search banner. However, This solution isn't perfect, down the road, we should probably find a way to warn about equal names and introduce something like namespace to avoid huge prefixes.
Diffstat (limited to 'CMakeLists.txt')
0 files changed, 0 insertions, 0 deletions