LibGUI: Turn GUI::Application::the() into a pointer

During app teardown, the Application object may be destroyed before
something else, and so having Application::the() return a reference was
obscuring the truth about its lifetime.

This patch makes the API more honest by returning a pointer. While
this makes call sites look a bit more sketchy, do note that the global
Application pointer only becomes null during app teardown.

1 files changed, 2 insertions, 2 deletions

diff --git a/Applications/TextEditor/TextEditorWidget.cpp b/Applications/TextEditor/TextEditorWidget.cpp
index 39b339de3c..307e280d6e 100644
--- a/Applications/TextEditor/TextEditorWidget.cpp
+++ b/Applications/TextEditor/TextEditorWidget.cpp
@@ -368,7 +368,7 @@ TextEditorWidget::TextEditorWidget()
     app_menu.add_action(GUI::CommonActions::make_quit_action([this](auto&) {
         if (!request_close())
             return;
-        GUI::Application::the().quit(0);
+        GUI::Application::the()->quit();
     }));
 
     auto& edit_menu = menubar->add_menu("Edit");
@@ -455,7 +455,7 @@ TextEditorWidget::TextEditorWidget()
         GUI::AboutDialog::show("Text Editor", Gfx::Bitmap::load_from_file("/res/icons/32x32/app-texteditor.png"), window());
     }));
 
-    GUI::Application::the().set_menubar(move(menubar));
+    GUI::Application::the()->set_menubar(move(menubar));
 
     toolbar.add_action(*m_new_action);
     toolbar.add_action(*m_open_action);