diff options
| author | Andreas Kling <kling@serenityos.org> | 2020-07-04 16:52:01 +0200 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2020-07-04 16:54:55 +0200 |
| commit | ca93c22ae2706c35828f913976f35e828157bb01 (patch) | |
| tree | 6daa1e52973d55636634ceb69fc0fe15b6bd50f4 /Applications/Piano | |
| parent | f7577585a6794228659e5e7b496cddfd8a94b54d (diff) | |
| download | serenity-ca93c22ae2706c35828f913976f35e828157bb01.zip | |
LibGUI: Turn GUI::Application::the() into a pointer
During app teardown, the Application object may be destroyed before
something else, and so having Application::the() return a reference was
obscuring the truth about its lifetime.
This patch makes the API more honest by returning a pointer. While
this makes call sites look a bit more sketchy, do note that the global
Application pointer only becomes null during app teardown.
Diffstat (limited to 'Applications/Piano')
| -rw-r--r-- | Applications/Piano/main.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Applications/Piano/main.cpp b/Applications/Piano/main.cpp index a089508bd2..aec6966a81 100644 --- a/Applications/Piano/main.cpp +++ b/Applications/Piano/main.cpp @@ -96,7 +96,7 @@ int main(int argc, char** argv) auto& app_menu = menubar->add_menu("Piano"); app_menu.add_action(GUI::CommonActions::make_quit_action([](auto&) { - GUI::Application::the().quit(0); + GUI::Application::the()->quit(); return; })); app_menu.add_action(GUI::Action::create("Export", { Mod_Ctrl, Key_E }, [&](const GUI::Action&) { |