AK: Stop Vector::extend from unnecessary reallocation

Previously, Vector::extend for a moved vector would move the other
vector into this vector if this vector was empty, thereby throwing away
existing allocated capacity. Therefore, this commit allows the move to
only happen if this vector's capacity is too small to fit the other
vector. This will also alleviate bugs where callers relied on the
capacity to never shrink with calls to unchecked_append, extend and the
like.

1 files changed, 1 insertions, 1 deletions

diff --git a/AK/Vector.h b/AK/Vector.h
index 751952b987..327be79be8 100644
--- a/AK/Vector.h
+++ b/AK/Vector.h
@@ -491,7 +491,7 @@ public:
 
     ErrorOr<void> try_extend(Vector&& other)
     {
-        if (is_empty()) {
+        if (is_empty() && capacity() <= other.capacity()) {
             *this = move(other);
             return {};
         }