AK: Fix logic in String::operator>(const String&)

Null strings should not compare greater than non-null strings.

Add tests for >, <, >=, and <= comparison involving null strings.

1 files changed, 3 insertions, 3 deletions

diff --git a/AK/String.cpp b/AK/String.cpp
index 6dec4c1438..b975781de0 100644
--- a/AK/String.cpp
+++ b/AK/String.cpp
@@ -58,10 +58,10 @@ bool String::operator<(const String& other) const
 
 bool String::operator>(const String& other) const
 {
-    if (!m_impl)
-        return other.m_impl;
-
     if (!other.m_impl)
+        return m_impl;
+
+    if (!m_impl)
         return false;
 
     return strcmp(characters(), other.characters()) > 0;