AK+Everywhere: Disallow constructing Functions from incompatible types

Previously, AK::Function would accept _any_ callable type, and try to
call it when called, first with the given set of arguments, then with
zero arguments, and if all of those failed, it would simply not call the
function and **return a value-constructed Out type**.
This lead to many, many, many hard to debug situations when someone
forgot a `const` in their lambda argument types, and many cases of
people taking zero arguments in their lambdas to ignore them.
This commit reworks the Function interface to not include any such
surprising behaviour, if your function instance is not callable with
the declared argument set of the Function, it can simply not be
assigned to that Function instance, end of story.

1 files changed, 0 insertions, 4 deletions

diff --git a/AK/StdLibExtras.h b/AK/StdLibExtras.h
index 7a48da2ba1..19411fc4b6 100644
--- a/AK/StdLibExtras.h
+++ b/AK/StdLibExtras.h
@@ -39,9 +39,6 @@ struct _RawPtr {
 
 namespace AK {
 
-template<typename T>
-auto declval() -> T;
-
 template<class T>
 constexpr T&& forward(RemoveReference<T>& param)
 {
@@ -118,7 +115,6 @@ using RawPtr = typename Detail::_RawPtr<T>::Type;
 using AK::array_size;
 using AK::ceil_div;
 using AK::clamp;
-using AK::declval;
 using AK::exchange;
 using AK::forward;
 using AK::max;