summaryrefslogtreecommitdiff
path: root/AK/Span.h
diff options
context:
space:
mode:
authorLenny Maiorani <lenny@colorado.edu>2021-01-10 16:29:28 -0700
committerAndreas Kling <kling@serenityos.org>2021-01-12 09:11:45 +0100
commite6f907a1556757c623fe660df0a43faf1b3d0eae (patch)
treea3a07081ec2ebdac050d776c61d2c908459bf343 /AK/Span.h
parent9dc44bf8c427160bafd87205c42201cf9b11c0b4 (diff)
downloadserenity-e6f907a1556757c623fe660df0a43faf1b3d0eae.zip
AK: Simplify constructors and conversions from nullptr_t
Problem: - Many constructors are defined as `{}` rather than using the ` = default` compiler-provided constructor. - Some types provide an implicit conversion operator from `nullptr_t` instead of requiring the caller to default construct. This violates the C++ Core Guidelines suggestion to declare single-argument constructors explicit (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit). Solution: - Change default constructors to use the compiler-provided default constructor. - Remove implicit conversion operators from `nullptr_t` and change usage to enforce type consistency without conversion.
Diffstat (limited to 'AK/Span.h')
-rw-r--r--AK/Span.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/AK/Span.h b/AK/Span.h
index 7bfae70adf..6b5427656f 100644
--- a/AK/Span.h
+++ b/AK/Span.h
@@ -105,10 +105,7 @@ class Span : public Detail::Span<T> {
public:
using Detail::Span<T>::Span;
- ALWAYS_INLINE constexpr Span(std::nullptr_t)
- : Span()
- {
- }
+ constexpr Span() = default;
ALWAYS_INLINE constexpr Span(const Span& other)
: Span(other.m_values, other.m_size)