AK: Make dbgln_if() avoid evaluating the arguments when disabled

Naturally, this makes the `enabled` flag on dbgln() obsolete.

1 files changed, 8 insertions, 6 deletions

diff --git a/AK/Format.h b/AK/Format.h
index c5b6ce795e..c7b5400e30 100644
--- a/AK/Format.h
+++ b/AK/Format.h
@@ -396,15 +396,13 @@ inline void warnln() { outln(stderr); }
 
 void vdbgln(StringView fmtstr, TypeErasedFormatParams);
 
-template<bool enabled = true, typename... Parameters>
+template<typename... Parameters>
 void dbgln(CheckedFormatString<Parameters...>&& fmtstr, const Parameters&... parameters)
 {
-    if constexpr (enabled)
-        vdbgln(fmtstr.view(), VariadicFormatParams { parameters... });
+    vdbgln(fmtstr.view(), VariadicFormatParams { parameters... });
 }
 
-template<bool enabled = true>
-void dbgln() { dbgln<enabled>(""); }
+inline void dbgln() { dbgln(""); }
 
 void set_debug_enabled(bool);
 
@@ -488,4 +486,8 @@ using AK::CheckedFormatString;
 using AK::FormatIfSupported;
 using AK::FormatString;
 
-#define dbgln_if(flag, fmt, ...) dbgln<flag>(fmt, ##__VA_ARGS__)
+#define dbgln_if(flag, fmt, ...)       \
+    do {                               \
+        if constexpr (flag)            \
+            dbgln(fmt, ##__VA_ARGS__); \
+    } while (0)