AK: Resolve clang-tidy warnings about unusual assignment operators

Either not returning *this, or in the case of Variant, not checking for
self assignment. In AK::Atomic, we can't return *this due to the wrapper
semantics Atomic implements.

1 files changed, 3 insertions, 0 deletions

diff --git a/AK/Atomic.h b/AK/Atomic.h
index e1a1007b2e..70ae6d1399 100644
--- a/AK/Atomic.h
+++ b/AK/Atomic.h
@@ -187,6 +187,7 @@ public:
         return *ret;
     }
 
+    // NOLINTNEXTLINE(misc-unconventional-assign-operator) We want operator= to exchange the value, so returning an object of type Atomic& here does not make sense
     ALWAYS_INLINE T operator=(T desired) volatile noexcept
     {
         store(desired);
@@ -317,6 +318,7 @@ public:
         return __atomic_load_n(&m_value, order);
     }
 
+    // NOLINTNEXTLINE(misc-unconventional-assign-operator) We want operator= to exchange the value, so returning an object of type Atomic& here does not make sense
     ALWAYS_INLINE T operator=(T desired) volatile noexcept
     {
         store(desired);
@@ -417,6 +419,7 @@ public:
         return __atomic_load_n(&m_value, order);
     }
 
+    // NOLINTNEXTLINE(misc-unconventional-assign-operator) We want operator= to exchange the value, so returning an object of type Atomic& here does not make sense
     T* operator=(T* desired) volatile noexcept
     {
         store(desired);