summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Kling <kling@serenityos.org>2023-05-06 12:42:22 +0200
committerAndreas Kling <kling@serenityos.org>2023-05-06 12:49:12 +0200
commit0eb7c24e7d812bdd37a709e54bad3939ffcc6d4f (patch)
tree570640753d4248f08901cc57663dcc89a7123936
parenteff783a6d221a09606a01ce6896f0ff011d522a7 (diff)
downloadserenity-0eb7c24e7d812bdd37a709e54bad3939ffcc6d4f.zip
Ladybird: Stop telling Qt to use HTTP pipelining
For some reason, this was causing incomplete HTTP loads in some cases. As an example, we would only load half of the "Ahem" CSS font from the wpt.live server when running Acid3. I only enabled pipelining in the first place because I assumed it would be a performance boost, but it appears to do more than that. I suppose there's a reason it's off by default (and most Qt API users don't bother enabling it.)
-rw-r--r--Ladybird/RequestManagerQt.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/Ladybird/RequestManagerQt.cpp b/Ladybird/RequestManagerQt.cpp
index e6a97d2f15..7138243e89 100644
--- a/Ladybird/RequestManagerQt.cpp
+++ b/Ladybird/RequestManagerQt.cpp
@@ -40,7 +40,6 @@ ErrorOr<NonnullRefPtr<RequestManagerQt::Request>> RequestManagerQt::Request::cre
{
QNetworkRequest request { QString(url.to_deprecated_string().characters()) };
request.setAttribute(QNetworkRequest::RedirectPolicyAttribute, QNetworkRequest::ManualRedirectPolicy);
- request.setAttribute(QNetworkRequest::HttpPipeliningAllowedAttribute, true);
request.setAttribute(QNetworkRequest::CookieLoadControlAttribute, QNetworkRequest::Manual);
request.setAttribute(QNetworkRequest::CookieSaveControlAttribute, QNetworkRequest::Manual);