summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Kling <awesomekling@gmail.com>2019-02-15 12:39:16 +0100
committerAndreas Kling <awesomekling@gmail.com>2019-02-15 12:39:16 +0100
commitdf6aaaeeef5777dbf3bbdff6b4651ff891fa5a35 (patch)
tree59e34ada56a95a87adf86f8946a6bbe9fce3f007
parent56f0a30f9b014df71afb8cd90cd234d9c3c6c87e (diff)
downloadserenity-df6aaaeeef5777dbf3bbdff6b4651ff891fa5a35.zip
Enable -Wimplicit-fallthrough.
-rw-r--r--Applications/About/Makefile2
-rw-r--r--Applications/Clock/Makefile2
-rw-r--r--Applications/FileManager/Makefile2
-rw-r--r--Applications/FontEditor/Makefile2
-rw-r--r--Applications/Launcher/Makefile2
-rw-r--r--Applications/Terminal/Makefile2
-rw-r--r--Kernel/Makefile2
-rw-r--r--Kernel/VirtualConsole.cpp4
-rw-r--r--LibC/Makefile2
-rw-r--r--LibGUI/Makefile2
-rw-r--r--Userland/Makefile2
11 files changed, 12 insertions, 12 deletions
diff --git a/Applications/About/Makefile b/Applications/About/Makefile
index 3b84f7c2e7..e3ae25ff9e 100644
--- a/Applications/About/Makefile
+++ b/Applications/About/Makefile
@@ -6,7 +6,7 @@ APP = About
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Applications/Clock/Makefile b/Applications/Clock/Makefile
index 1939a1d220..1107a42242 100644
--- a/Applications/Clock/Makefile
+++ b/Applications/Clock/Makefile
@@ -7,7 +7,7 @@ APP = Clock
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Applications/FileManager/Makefile b/Applications/FileManager/Makefile
index f41a35cfca..91b3ab36d4 100644
--- a/Applications/FileManager/Makefile
+++ b/Applications/FileManager/Makefile
@@ -7,7 +7,7 @@ APP = FileManager
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Applications/FontEditor/Makefile b/Applications/FontEditor/Makefile
index dd592ab7c8..99a1bbd494 100644
--- a/Applications/FontEditor/Makefile
+++ b/Applications/FontEditor/Makefile
@@ -7,7 +7,7 @@ APP = FontEditor
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Applications/Launcher/Makefile b/Applications/Launcher/Makefile
index cd6a918d08..6f90104cdc 100644
--- a/Applications/Launcher/Makefile
+++ b/Applications/Launcher/Makefile
@@ -6,7 +6,7 @@ APP = Launcher
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Applications/Terminal/Makefile b/Applications/Terminal/Makefile
index ac2ed4ba57..c19fac2808 100644
--- a/Applications/Terminal/Makefile
+++ b/Applications/Terminal/Makefile
@@ -7,7 +7,7 @@ APP = Terminal
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../.. -I. -I../../LibC
diff --git a/Kernel/Makefile b/Kernel/Makefile
index fa2d01cfe1..b8c66dd0a5 100644
--- a/Kernel/Makefile
+++ b/Kernel/Makefile
@@ -85,7 +85,7 @@ IMAGE = .floppy-image
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
KERNEL_FLAGS = -ffreestanding -fno-stack-protector -fno-ident -fno-builtin
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -mregparm=3 -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables -fno-omit-frame-pointer
INCLUDE_FLAGS = -I.. -I.
diff --git a/Kernel/VirtualConsole.cpp b/Kernel/VirtualConsole.cpp
index ee1e984226..3760fa0b63 100644
--- a/Kernel/VirtualConsole.cpp
+++ b/Kernel/VirtualConsole.cpp
@@ -417,14 +417,14 @@ void VirtualConsole::on_char(byte ch)
return;
}
m_escape_state = ExpectIntermediate;
- // fall through
+ [[fallthrough]];
case ExpectIntermediate:
if (is_valid_intermediate_character(ch)) {
m_intermediates.append(ch);
return;
}
m_escape_state = ExpectFinal;
- // fall through
+ [[fallthrough]];
case ExpectFinal:
if (is_valid_final_character(ch)) {
m_escape_state = Normal;
diff --git a/LibC/Makefile b/LibC/Makefile
index bdc2068ba6..17842a7f7c 100644
--- a/LibC/Makefile
+++ b/LibC/Makefile
@@ -55,7 +55,7 @@ LIBRARY = LibC.a
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
LIBC_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -fomit-frame-pointer -march=i386 -m32 -fno-exceptions -fno-rtti -ffunction-sections -fdata-sections -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -O2 -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I.. -I.
diff --git a/LibGUI/Makefile b/LibGUI/Makefile
index e1dcfaa385..685a6eb02a 100644
--- a/LibGUI/Makefile
+++ b/LibGUI/Makefile
@@ -37,7 +37,7 @@ LIBRARY = LibGUI.a
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
LIBC_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -fomit-frame-pointer -march=i386 -m32 -fno-exceptions -fno-rtti -ffunction-sections -fdata-sections -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I../LibC -I.. -I.
diff --git a/Userland/Makefile b/Userland/Makefile
index 6f64eeeeab..de3a65745a 100644
--- a/Userland/Makefile
+++ b/Userland/Makefile
@@ -64,7 +64,7 @@ APPS = \
ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib -nostdinc
USERLAND_FLAGS = -ffreestanding -fno-stack-protector -fno-ident
-WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings
+WARNING_FLAGS = -Wextra -Wall -Wundef -Wcast-qual -Wwrite-strings -Wimplicit-fallthrough
FLAVOR_FLAGS = -march=i386 -m32 -fno-exceptions -fno-rtti -fmerge-all-constants -fno-unroll-loops -fno-pie -fno-pic
OPTIMIZATION_FLAGS = -Oz -fno-asynchronous-unwind-tables
INCLUDE_FLAGS = -I.. -I. -I../LibC