summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrendan Coles <bcoles@gmail.com>2020-03-31 06:52:31 +0000
committerAndreas Kling <kling@serenityos.org>2020-03-31 09:08:30 +0200
commitd64589101cbe7dcbf4245dc677358ba7e76bcfdd (patch)
treee04494d85b0bf5cc113939bfb5d8fc5ee5f8a603
parent7bd077a3ae0e3b69cfb0e36455610e7f3429977b (diff)
downloadserenity-d64589101cbe7dcbf4245dc677358ba7e76bcfdd.zip
Userland: Add optional human readable output to /bin/df
/bin/df now allows the operator to view human readable output using `-h` or `--human-readable` optional flags.
-rw-r--r--Userland/df.cpp52
1 files changed, 47 insertions, 5 deletions
diff --git a/Userland/df.cpp b/Userland/df.cpp
index 3d8d4b5182..c5e56edc4b 100644
--- a/Userland/df.cpp
+++ b/Userland/df.cpp
@@ -28,29 +28,62 @@
#include <AK/JsonArray.h>
#include <AK/JsonObject.h>
#include <AK/Vector.h>
+#include <LibCore/ArgsParser.h>
#include <LibCore/File.h>
+#include <cstring>
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
+static bool flag_human_readable = false;
+
struct FileSystem {
String fs;
size_t total_block_count { 0 };
size_t free_block_count { 0 };
size_t total_inode_count { 0 };
size_t free_inode_count { 0 };
+ size_t block_size { 0 };
String mount_point;
};
-int main(int, char**)
+// FIXME: Remove this hackery once printf() supports floats.
+// FIXME: Also, we should probably round the sizes in df -h output.
+static String number_string_with_one_decimal(float number, const char* suffix)
+{
+ float decimals = number - (int)number;
+ return String::format("%d.%d%s", (int)number, (int)(decimals * 10), suffix);
+}
+
+static String human_readable_size(size_t size)
+{
+ if (size < 1 * KB)
+ return String::number(size);
+ if (size < 1 * MB)
+ return number_string_with_one_decimal((float)size / (float)KB, "K");
+ if (size < 1 * GB)
+ return number_string_with_one_decimal((float)size / (float)MB, "M");
+ return number_string_with_one_decimal((float)size / (float)GB, "G");
+}
+
+int main(int argc, char** argv)
{
+ Core::ArgsParser args_parser;
+ args_parser.add_option(flag_human_readable, "Print human-readable sizes", "human-readable", 'h');
+ args_parser.parse(argc, argv);
+
auto file = Core::File::construct("/proc/df");
if (!file->open(Core::IODevice::ReadOnly)) {
fprintf(stderr, "Failed to open /proc/df: %s\n", file->error_string());
return 1;
}
- printf("Filesystem Blocks Used Available Mount point\n");
+
+ if (flag_human_readable) {
+ printf("Filesystem Size Used Available Mount point\n");
+ } else {
+ printf("Filesystem Blocks Used Available Mount point\n");
+ }
auto file_contents = file->read_all();
auto json = JsonValue::from_string(file_contents).as_array();
@@ -61,15 +94,24 @@ int main(int, char**)
auto free_block_count = fs_object.get("free_block_count").to_u32();
auto total_inode_count = fs_object.get("total_inode_count").to_u32();
auto free_inode_count = fs_object.get("free_inode_count").to_u32();
+ auto block_size = fs_object.get("block_size").to_u32();
auto mount_point = fs_object.get("mount_point").to_string();
(void)total_inode_count;
(void)free_inode_count;
printf("%-10s", fs.characters());
- printf("%10u ", total_block_count);
- printf("%10u ", total_block_count - free_block_count);
- printf("%10u ", free_block_count);
+
+ if (flag_human_readable) {
+ printf("%10s ", human_readable_size(total_block_count * block_size).characters());
+ printf("%10s ", human_readable_size((total_block_count - free_block_count) * block_size).characters());
+ printf("%10s ", human_readable_size(free_block_count * block_size).characters());
+ } else {
+ printf("%10u ", total_block_count);
+ printf("%10u ", total_block_count - free_block_count);
+ printf("%10u ", free_block_count);
+ }
+
printf("%s", mount_point.characters());
printf("\n");
});