diff options
author | Andreas Kling <kling@serenityos.org> | 2021-02-10 08:37:13 +0100 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-02-10 09:13:30 +0100 |
commit | abf7c02acb4761a833726fed33ad88fc0c8177a3 (patch) | |
tree | 3c0d9fcbd660dc54af8bab2821351e45ce4f5211 | |
parent | 794ebb699c72e0e2768b7a6380c963150183daa0 (diff) | |
download | serenity-abf7c02acb4761a833726fed33ad88fc0c8177a3.zip |
LibWeb: Move window.confirm() to using a PageClient callback
This allows us to move the GUI::MessageBox out of DOM::Window and up to
the widget layer.
-rw-r--r-- | Userland/Libraries/LibWeb/DOM/Window.cpp | 6 | ||||
-rw-r--r-- | Userland/Libraries/LibWeb/InProcessWebView.cpp | 6 | ||||
-rw-r--r-- | Userland/Libraries/LibWeb/InProcessWebView.h | 1 | ||||
-rw-r--r-- | Userland/Libraries/LibWeb/Page/Page.h | 1 |
4 files changed, 11 insertions, 3 deletions
diff --git a/Userland/Libraries/LibWeb/DOM/Window.cpp b/Userland/Libraries/LibWeb/DOM/Window.cpp index 648d083696..cf1a164c38 100644 --- a/Userland/Libraries/LibWeb/DOM/Window.cpp +++ b/Userland/Libraries/LibWeb/DOM/Window.cpp @@ -25,7 +25,6 @@ */ #include <LibGUI/DisplayLink.h> -#include <LibGUI/MessageBox.h> #include <LibJS/Runtime/Function.h> #include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Event.h> @@ -67,8 +66,9 @@ void Window::alert(const String& message) bool Window::confirm(const String& message) { - auto confirm_result = GUI::MessageBox::show(nullptr, message, "Confirm", GUI::MessageBox::Type::Warning, GUI::MessageBox::InputType::OKCancel); - return confirm_result == GUI::Dialog::ExecResult::ExecOK; + if (auto* page = m_document.page()) + return page->client().page_did_request_confirm(message); + return false; } i32 Window::set_interval(JS::Function& callback, i32 interval) diff --git a/Userland/Libraries/LibWeb/InProcessWebView.cpp b/Userland/Libraries/LibWeb/InProcessWebView.cpp index c0ccaed81f..942a8b62e6 100644 --- a/Userland/Libraries/LibWeb/InProcessWebView.cpp +++ b/Userland/Libraries/LibWeb/InProcessWebView.cpp @@ -420,4 +420,10 @@ void InProcessWebView::page_did_request_alert(const String& message) GUI::MessageBox::show(window(), message, "Alert", GUI::MessageBox::Type::Information); } +bool InProcessWebView::page_did_request_confirm(const String& message) +{ + auto confirm_result = GUI::MessageBox::show(window(), message, "Confirm", GUI::MessageBox::Type::Warning, GUI::MessageBox::InputType::OKCancel); + return confirm_result == GUI::Dialog::ExecResult::ExecOK; +} + } diff --git a/Userland/Libraries/LibWeb/InProcessWebView.h b/Userland/Libraries/LibWeb/InProcessWebView.h index cad88401cd..2350b2b3d8 100644 --- a/Userland/Libraries/LibWeb/InProcessWebView.h +++ b/Userland/Libraries/LibWeb/InProcessWebView.h @@ -106,6 +106,7 @@ private: virtual void page_did_layout() override; virtual void page_did_request_scroll_into_view(const Gfx::IntRect&) override; virtual void page_did_request_alert(const String&) override; + virtual bool page_did_request_confirm(const String&) override; void layout_and_sync_size(); diff --git a/Userland/Libraries/LibWeb/Page/Page.h b/Userland/Libraries/LibWeb/Page/Page.h index fb94463482..537c85bbfa 100644 --- a/Userland/Libraries/LibWeb/Page/Page.h +++ b/Userland/Libraries/LibWeb/Page/Page.h @@ -105,6 +105,7 @@ public: virtual void page_did_layout() { } virtual void page_did_request_scroll_into_view(const Gfx::IntRect&) { } virtual void page_did_request_alert(const String&) { } + virtual bool page_did_request_confirm(const String&) { return false; } }; } |