diff options
| author | davidot <davidot@serenityos.org> | 2022-08-23 20:24:59 +0200 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2022-08-23 22:30:15 +0100 |
| commit | a9d2d806b61df3b84af06744b6fad670f4012539 (patch) | |
| tree | adf00b921ea1bba7eb16d2ed07e956e937af5086 | |
| parent | 34a09bbb5410b866e35bb03fcb489a61f4b262b3 (diff) | |
| download | serenity-a9d2d806b61df3b84af06744b6fad670f4012539.zip | |
LibJS: Use __builtin_isnan in static_assert instead of isnan
For the fuzzer build isnan was not usable in a constexpr context however
__builtin_isnan seems to always be.
Also while we're here add my name to the copyright since I forgot after
the Value rewrite.
| -rw-r--r-- | Userland/Libraries/LibJS/Runtime/Value.cpp | 1 | ||||
| -rw-r--r-- | Userland/Libraries/LibJS/Runtime/Value.h | 6 |
2 files changed, 5 insertions, 2 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/Value.cpp b/Userland/Libraries/LibJS/Runtime/Value.cpp index 06c2bafc2e..8575e5f4fb 100644 --- a/Userland/Libraries/LibJS/Runtime/Value.cpp +++ b/Userland/Libraries/LibJS/Runtime/Value.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2020-2022, Linus Groh <linusg@serenityos.org> + * Copyright (c) 2022, David Tuin <davidot@serenityos.org> * * SPDX-License-Identifier: BSD-2-Clause */ diff --git a/Userland/Libraries/LibJS/Runtime/Value.h b/Userland/Libraries/LibJS/Runtime/Value.h index 4e54e4016e..87ebc71aab 100644 --- a/Userland/Libraries/LibJS/Runtime/Value.h +++ b/Userland/Libraries/LibJS/Runtime/Value.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2020-2022, Linus Groh <linusg@serenityos.org> + * Copyright (c) 2022, David Tuin <davidot@serenityos.org> * * SPDX-License-Identifier: BSD-2-Clause */ @@ -47,8 +48,9 @@ static_assert(POSITIVE_INFINITY_BITS == 0x7FF0000000000000); static_assert(NEGATIVE_INFINITY_BITS == 0xFFF0000000000000); // However as long as any bit is set in the mantissa with the exponent of all // ones this value is a NaN, and it even ignores the sign bit. -static_assert(isnan(bit_cast<double>(0x7FF0000000000001))); -static_assert(isnan(bit_cast<double>(0xFFF0000000040000))); +// (NOTE: we have to use __builtin_isnan here since some isnan implementations are not constexpr) +static_assert(__builtin_isnan(bit_cast<double>(0x7FF0000000000001))); +static_assert(__builtin_isnan(bit_cast<double>(0xFFF0000000040000))); // This means we can use all of these NaNs to store all other options for Value. // To make sure all of these other representations we use 0x7FF8 as the base top // 2 bytes which ensures the value is always a NaN. |