summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTimothy Flynn <trflynn89@pm.me>2021-04-02 13:32:28 -0400
committerAndreas Kling <kling@serenityos.org>2021-04-02 20:36:02 +0200
commit7d8d45e757ec16a73406746e179ab611a90a32d1 (patch)
treefaf6cc5a471746aaecd6f81eeeb1fc54aaa671fd
parenta106f852d3171ae35a4e09870cbb2aef24c2fd10 (diff)
downloadserenity-7d8d45e757ec16a73406746e179ab611a90a32d1.zip
LibWeb: Add a line box fragment for <br> nodes
This is required for the block formatting context to know the height of the <br> element while computing the height of its parent. Specifically, this comes into play when the <br> element is the first or last child of its parent. In that case, it previously would not have any fragments, so BlockFormattingContext::compute_auto_height_for_block_level_element would infer its top and bottom positions to be 0.
-rw-r--r--Userland/Libraries/LibWeb/Layout/BreakNode.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/Userland/Libraries/LibWeb/Layout/BreakNode.cpp b/Userland/Libraries/LibWeb/Layout/BreakNode.cpp
index 9951ae4fe0..79bff7cadd 100644
--- a/Userland/Libraries/LibWeb/Layout/BreakNode.cpp
+++ b/Userland/Libraries/LibWeb/Layout/BreakNode.cpp
@@ -42,7 +42,8 @@ BreakNode::~BreakNode()
void BreakNode::split_into_lines(InlineFormattingContext& context, LayoutMode)
{
- context.containing_block().add_line_box();
+ auto& line_box = context.containing_block().add_line_box();
+ line_box.add_fragment(*this, 0, 0, 0, context.containing_block().line_height());
}
}