diff options
| author | davidot <davidot@serenityos.org> | 2022-02-04 23:47:35 +0100 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2022-02-05 11:52:51 +0100 |
| commit | 14d1601a7697e9b0a43d2fcc806d0f558aca755e (patch) | |
| tree | cde98e6ec06bb49dfc1fe4f8d62ffa4b6bf12b5e | |
| parent | d46be7e7f2348ccbd0f6fda0ec3ee5fc53b1274e (diff) | |
| download | serenity-14d1601a7697e9b0a43d2fcc806d0f558aca755e.zip | |
LibJS: Remove the VERIFY_NOT_REACHED in link_and_eval_module
Since the spec does not fully define the entry points of modules what
this means is kind of unclear. But it does work in most cases and can
be useful. We do print out a warning just to clarify why there could be
strange things.
| -rw-r--r-- | Userland/Libraries/LibJS/Runtime/VM.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/VM.cpp b/Userland/Libraries/LibJS/Runtime/VM.cpp index 5ad68f8d6a..f4e116c96e 100644 --- a/Userland/Libraries/LibJS/Runtime/VM.cpp +++ b/Userland/Libraries/LibJS/Runtime/VM.cpp @@ -766,10 +766,9 @@ ThrowCompletionOr<void> VM::link_and_eval_module(Module& module) if (module_or_end.is_end()) { dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] Warning introducing module via link_and_eval_module {}", module.filename()); - if (m_loaded_modules.size() > 0) { - dbgln("Using link_and_eval module as entry point is not allowed if it is not the first module!"); - VERIFY_NOT_REACHED(); - } + if (m_loaded_modules.size() > 0) + dbgln("Warning: Using multiple modules as entry point can lead to unexpected results"); + m_loaded_modules.empend( &module, module.filename(), |