summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPankaj Raghav <p.raghav@samsung.com>2023-03-11 10:44:18 +0100
committerLinus Groh <mail@linusgroh.de>2023-03-11 13:15:00 +0000
commitf8b67e15962306455f919038d069a6a9b122f72c (patch)
treebcf65e682a6f2e814e8df117cd6f4e268169884f
parent84e17fcbcca4f1d572ff8b36978c3ee555ac62a0 (diff)
downloadserenity-f8b67e15962306455f919038d069a6a9b122f72c.zip
Kernel/Storage+Base: Fix boot_device_addressing document for NVMe
The LUN.target_id parameter points to a NVMe Namespace which starts from 1 and not 0. Fix the document to reflect the same while addressing a nvme device in the boot parameters
-rw-r--r--Base/usr/share/man/man7/boot_device_addressing.md2
-rw-r--r--Kernel/Storage/StorageDevice.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/Base/usr/share/man/man7/boot_device_addressing.md b/Base/usr/share/man/man7/boot_device_addressing.md
index 021ace43ad..e002dc91c3 100644
--- a/Base/usr/share/man/man7/boot_device_addressing.md
+++ b/Base/usr/share/man/man7/boot_device_addressing.md
@@ -30,7 +30,7 @@ to address raw `StorageDevice`s:
```
ata0:0:0 [First ATA controller, ATA first primary channel, master device]
-nvme0:0 [First NVMe Controller, First NVMe Namespace]
+nvme0:1:0 [First NVMe Controller, First NVMe Namespace, Not Applicable]
ramdisk0 [First Ramdisk]
```
diff --git a/Kernel/Storage/StorageDevice.h b/Kernel/Storage/StorageDevice.h
index b66a94f062..08198f4792 100644
--- a/Kernel/Storage/StorageDevice.h
+++ b/Kernel/Storage/StorageDevice.h
@@ -46,7 +46,7 @@ public:
// For example, on a legacy ATA instance, one might connect an harddrive to the second IDE controller,
// to the Primary channel as a slave device, which translates to LUN 1:0:1.
// On NVMe, for example, connecting a second PCIe NVMe storage device as a sole NVMe namespace translates
- // to LUN 1:0:0.
+ // to LUN 1:1:0.
struct LUNAddress {
u32 controller_id;
u32 target_id;