summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2020-05-18 01:00:09 +0100
committerAndreas Kling <kling@serenityos.org>2020-05-18 09:36:14 +0200
commitb8b7f84547a1854a265cd94fe8037b039eb428e7 (patch)
tree403a66d6af544a29f1e27ee4b7a5e3b8f784af1a
parent50c116e57b136d616f857bae6a09e391c8d1b801 (diff)
downloadserenity-b8b7f84547a1854a265cd94fe8037b039eb428e7.zip
LibJS: Remove no-op SymbolPrototype::description_setter()
We can just give put_native_property() a nullptr for the setter.
-rw-r--r--Libraries/LibJS/Runtime/SymbolPrototype.cpp8
-rw-r--r--Libraries/LibJS/Runtime/SymbolPrototype.h1
2 files changed, 1 insertions, 8 deletions
diff --git a/Libraries/LibJS/Runtime/SymbolPrototype.cpp b/Libraries/LibJS/Runtime/SymbolPrototype.cpp
index b00dfbedd2..8512a8fa85 100644
--- a/Libraries/LibJS/Runtime/SymbolPrototype.cpp
+++ b/Libraries/LibJS/Runtime/SymbolPrototype.cpp
@@ -42,8 +42,7 @@ namespace JS {
SymbolPrototype::SymbolPrototype()
: Object(interpreter().global_object().object_prototype())
{
- // FIXME: description has no setter, eventually remove
- put_native_property("description", description_getter, description_setter, Attribute::Configurable);
+ put_native_property("description", description_getter, nullptr, Attribute::Configurable);
put_native_function("toString", to_string, 0, Attribute::Writable | Attribute::Configurable);
put_native_function("valueOf", value_of, 0, Attribute::Writable | Attribute::Configurable);
@@ -73,11 +72,6 @@ Value SymbolPrototype::description_getter(Interpreter& interpreter)
return js_string(interpreter, this_object->description());
}
-void SymbolPrototype::description_setter(Interpreter&, Value)
-{
- // No-op, remove eventually
-}
-
Value SymbolPrototype::to_string(Interpreter& interpreter)
{
auto* this_object = this_symbol_from_interpreter(interpreter);
diff --git a/Libraries/LibJS/Runtime/SymbolPrototype.h b/Libraries/LibJS/Runtime/SymbolPrototype.h
index 4ccd5df3e1..5106a0b370 100644
--- a/Libraries/LibJS/Runtime/SymbolPrototype.h
+++ b/Libraries/LibJS/Runtime/SymbolPrototype.h
@@ -39,7 +39,6 @@ private:
virtual const char* class_name() const override { return "SymbolPrototype"; }
static Value description_getter(Interpreter&);
- static void description_setter(Interpreter&, Value);
static Value to_string(Interpreter&);
static Value value_of(Interpreter&);