diff options
author | Andreas Kling <kling@serenityos.org> | 2021-02-03 11:17:21 +0100 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-02-03 11:17:47 +0100 |
commit | 9c7798096550e1a894c7e110a65cfb0ab2776475 (patch) | |
tree | 11e160adb28f923145c29605dd15853d24d5fb00 | |
parent | ac59903c89708e19c837fe6cdec4c450b78d2a98 (diff) | |
download | serenity-9c7798096550e1a894c7e110a65cfb0ab2776475.zip |
Everywhere: Remove some bitrotted "#if 0" blocks
-rw-r--r-- | Kernel/KSyms.cpp | 6 | ||||
-rw-r--r-- | Kernel/VM/InodeVMObject.cpp | 34 | ||||
-rw-r--r-- | Userland/Libraries/LibGUI/TreeView.cpp | 14 |
3 files changed, 1 insertions, 53 deletions
diff --git a/Kernel/KSyms.cpp b/Kernel/KSyms.cpp index 6ccf816af6..05ebde5133 100644 --- a/Kernel/KSyms.cpp +++ b/Kernel/KSyms.cpp @@ -117,12 +117,6 @@ static void load_kernel_sybols_from_data(const KBuffer& buffer) NEVER_INLINE static void dump_backtrace_impl(FlatPtr base_pointer, bool use_ksyms) { SmapDisabler disabler; -#if 0 - if (!current) { - //hang(); - return; - } -#endif if (use_ksyms && !g_kernel_symbols_available) { Processor::halt(); return; diff --git a/Kernel/VM/InodeVMObject.cpp b/Kernel/VM/InodeVMObject.cpp index 88d7cdc694..fc48ee365e 100644 --- a/Kernel/VM/InodeVMObject.cpp +++ b/Kernel/VM/InodeVMObject.cpp @@ -98,40 +98,6 @@ void InodeVMObject::inode_contents_changed(Badge<Inode>, off_t offset, [[maybe_u for (auto& physical_page : m_physical_pages) physical_page = nullptr; -#if 0 - size_t current_offset = offset; - size_t remaining_bytes = size; - const u8* data_ptr = data; - - auto to_page_index = [] (size_t offset) -> size_t { - return offset / PAGE_SIZE; - }; - - if (current_offset & PAGE_MASK) { - size_t page_index = to_page_index(current_offset); - size_t bytes_to_copy = min(size, PAGE_SIZE - (current_offset & PAGE_MASK)); - if (m_physical_pages[page_index]) { - auto* ptr = MM.quickmap_page(*m_physical_pages[page_index]); - memcpy(ptr, data_ptr, bytes_to_copy); - MM.unquickmap_page(); - } - current_offset += bytes_to_copy; - data += bytes_to_copy; - remaining_bytes -= bytes_to_copy; - } - - for (size_t page_index = to_page_index(current_offset); page_index < m_physical_pages.size(); ++page_index) { - size_t bytes_to_copy = PAGE_SIZE - (current_offset & PAGE_MASK); - if (m_physical_pages[page_index]) { - auto* ptr = MM.quickmap_page(*m_physical_pages[page_index]); - memcpy(ptr, data_ptr, bytes_to_copy); - MM.unquickmap_page(); - } - current_offset += bytes_to_copy; - data += bytes_to_copy; - } -#endif - // FIXME: Consolidate with inode_size_changed() so we only do a single walk. for_each_region([](auto& region) { region.remap(); diff --git a/Userland/Libraries/LibGUI/TreeView.cpp b/Userland/Libraries/LibGUI/TreeView.cpp index 00f4f9fd61..be91aaaf61 100644 --- a/Userland/Libraries/LibGUI/TreeView.cpp +++ b/Userland/Libraries/LibGUI/TreeView.cpp @@ -418,19 +418,7 @@ void TreeView::did_update_selection() auto index = selection().first(); if (!index.is_valid()) return; -#if 0 - bool opened_any = false; - for (auto current = index; current.is_valid(); current = current.parent()) { - auto& metadata_for_ancestor = ensure_metadata_for_index(current); - if (!metadata_for_ancestor.open) { - metadata_for_ancestor.open = true; - opened_any = true; - } - } - if (opened_any) - update_content_size(); - update(); -#endif + if (activates_on_selection()) activate(index); } |