diff options
| author | Andreas Kling <kling@serenityos.org> | 2023-05-08 07:10:24 +0200 |
|---|---|---|
| committer | Jelle Raaijmakers <jelle@gmta.nl> | 2023-05-08 09:29:44 +0200 |
| commit | 67d2e329840091308c10ad3f81f5c1725e38830c (patch) | |
| tree | 87c1b6d7f319ce550f20411f25529191f2bc9f9e | |
| parent | f7678e279723d851dd81d62c3e44e1680618a686 (diff) | |
| download | serenity-67d2e329840091308c10ad3f81f5c1725e38830c.zip | |
LibWeb: Don't include DOM/NamedNodeMap.h from DOM/Element.h
| -rw-r--r-- | Userland/Libraries/LibWeb/DOM/Element.cpp | 11 | ||||
| -rw-r--r-- | Userland/Libraries/LibWeb/DOM/Element.h | 5 | ||||
| -rw-r--r-- | Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp | 1 |
3 files changed, 14 insertions, 3 deletions
diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp index fe2a649375..3cdaca22f9 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.cpp +++ b/Userland/Libraries/LibWeb/DOM/Element.cpp @@ -20,6 +20,7 @@ #include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Element.h> #include <LibWeb/DOM/HTMLCollection.h> +#include <LibWeb/DOM/NamedNodeMap.h> #include <LibWeb/DOM/ShadowRoot.h> #include <LibWeb/DOM/Text.h> #include <LibWeb/DOMParsing/InnerHTML.h> @@ -1692,4 +1693,14 @@ Layout::NodeWithStyle const* Element::layout_node() const return static_cast<Layout::NodeWithStyle const*>(Node::layout_node()); } +bool Element::has_attributes() const +{ + return !m_attributes->is_empty(); +} + +size_t Element::attribute_list_size() const +{ + return m_attributes->length(); +} + } diff --git a/Userland/Libraries/LibWeb/DOM/Element.h b/Userland/Libraries/LibWeb/DOM/Element.h index 3628b5720a..0df51fca6b 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.h +++ b/Userland/Libraries/LibWeb/DOM/Element.h @@ -15,7 +15,6 @@ #include <LibWeb/CSS/Selector.h> #include <LibWeb/CSS/StyleProperty.h> #include <LibWeb/DOM/ChildNode.h> -#include <LibWeb/DOM/NamedNodeMap.h> #include <LibWeb/DOM/NonDocumentTypeChildNode.h> #include <LibWeb/DOM/ParentNode.h> #include <LibWeb/DOM/QualifiedName.h> @@ -89,7 +88,7 @@ public: DeprecatedFlyString const& namespace_uri() const { return namespace_(); } bool has_attribute(DeprecatedFlyString const& name) const; - bool has_attributes() const { return !m_attributes->is_empty(); } + bool has_attributes() const; DeprecatedString attribute(DeprecatedFlyString const& name) const { return get_attribute(name); } DeprecatedString get_attribute(DeprecatedFlyString const& name) const; WebIDL::ExceptionOr<void> set_attribute(DeprecatedFlyString const& name, DeprecatedString const& value); @@ -98,7 +97,7 @@ public: WebIDL::ExceptionOr<JS::GCPtr<Attr>> set_attribute_node_ns(Attr&); void remove_attribute(DeprecatedFlyString const& name); WebIDL::ExceptionOr<bool> toggle_attribute(DeprecatedFlyString const& name, Optional<bool> force); - size_t attribute_list_size() const { return m_attributes->length(); } + size_t attribute_list_size() const; NamedNodeMap const* attributes() const { return m_attributes.ptr(); } Vector<DeprecatedString> get_attribute_names() const; diff --git a/Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp b/Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp index 7873639fb1..222085a119 100644 --- a/Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp +++ b/Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp @@ -11,6 +11,7 @@ #include <LibWeb/DOM/DocumentFragment.h> #include <LibWeb/DOM/DocumentType.h> #include <LibWeb/DOM/Element.h> +#include <LibWeb/DOM/NamedNodeMap.h> #include <LibWeb/DOM/Node.h> #include <LibWeb/DOM/ProcessingInstruction.h> #include <LibWeb/DOM/Text.h> |