summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2022-01-04 22:15:07 +0100
committerLinus Groh <mail@linusgroh.de>2022-01-04 23:37:26 +0000
commit62356cff409134f60a2d7ca890fa63fca9718477 (patch)
treecf39a227e3442ba700386e724bb497dd37c72183
parent245d486ba4f255a85c52579e8654bac7861d8365 (diff)
downloadserenity-62356cff409134f60a2d7ca890fa63fca9718477.zip
LibJS: Convert FunctionObject::bind() to ThrowCompletionOr
-rw-r--r--Userland/Libraries/LibJS/Runtime/FunctionObject.cpp9
-rw-r--r--Userland/Libraries/LibJS/Runtime/FunctionObject.h2
-rw-r--r--Userland/Libraries/LibJS/Runtime/FunctionPrototype.cpp2
3 files changed, 7 insertions, 6 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp b/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp
index ff6e392533..1051536a41 100644
--- a/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp
+++ b/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp
@@ -6,6 +6,7 @@
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/BoundFunction.h>
+#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/FunctionObject.h>
#include <LibJS/Runtime/GlobalObject.h>
@@ -20,7 +21,7 @@ FunctionObject::~FunctionObject()
{
}
-BoundFunction* FunctionObject::bind(Value bound_this_value, Vector<Value> arguments)
+ThrowCompletionOr<BoundFunction*> FunctionObject::bind(Value bound_this_value, Vector<Value> arguments)
{
auto& vm = this->vm();
FunctionObject& target_function = is<BoundFunction>(*this) ? static_cast<BoundFunction&>(*this).bound_target_function() : *this;
@@ -38,15 +39,15 @@ BoundFunction* FunctionObject::bind(Value bound_this_value, Vector<Value> argume
return TRY(bound_this_value.to_object(global_object()));
}
};
- auto bound_this_object = TRY_OR_DISCARD(get_bound_this_object());
+ auto bound_this_object = TRY(get_bound_this_object());
i32 computed_length = 0;
- auto length_property = TRY_OR_DISCARD(get(vm.names.length));
+ auto length_property = TRY(get(vm.names.length));
if (length_property.is_number())
computed_length = max(0, length_property.as_i32() - static_cast<i32>(arguments.size()));
Object* constructor_prototype = nullptr;
- auto prototype_property = TRY_OR_DISCARD(target_function.get(vm.names.prototype));
+ auto prototype_property = TRY(target_function.get(vm.names.prototype));
if (prototype_property.is_object())
constructor_prototype = &prototype_property.as_object();
diff --git a/Userland/Libraries/LibJS/Runtime/FunctionObject.h b/Userland/Libraries/LibJS/Runtime/FunctionObject.h
index ef2267564a..0aa9d2a33e 100644
--- a/Userland/Libraries/LibJS/Runtime/FunctionObject.h
+++ b/Userland/Libraries/LibJS/Runtime/FunctionObject.h
@@ -25,7 +25,7 @@ public:
virtual const FlyString& name() const = 0;
- BoundFunction* bind(Value bound_this_value, Vector<Value> arguments);
+ ThrowCompletionOr<BoundFunction*> bind(Value bound_this_value, Vector<Value> arguments);
virtual bool is_strict_mode() const { return false; }
diff --git a/Userland/Libraries/LibJS/Runtime/FunctionPrototype.cpp b/Userland/Libraries/LibJS/Runtime/FunctionPrototype.cpp
index f74654d991..ea37349f92 100644
--- a/Userland/Libraries/LibJS/Runtime/FunctionPrototype.cpp
+++ b/Userland/Libraries/LibJS/Runtime/FunctionPrototype.cpp
@@ -72,7 +72,7 @@ JS_DEFINE_NATIVE_FUNCTION(FunctionPrototype::bind)
arguments.remove(0);
}
- return this_function.bind(bound_this_arg, move(arguments));
+ return TRY(this_function.bind(bound_this_arg, move(arguments)));
}
// 20.2.3.3 Function.prototype.call ( thisArg, ...args ), https://tc39.es/ecma262/#sec-function.prototype.call