summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Kling <kling@serenityos.org>2021-07-22 22:43:06 +0200
committerAndreas Kling <kling@serenityos.org>2021-07-22 23:34:33 +0200
commit3f9e018d9a2f2868b8ad98c0782e40994a145065 (patch)
tree6440709d27f95c26b589eaaae906d585e463f4c0
parentcdae397e6a563923f90766ed7d6bce35d7bd0520 (diff)
downloadserenity-3f9e018d9a2f2868b8ad98c0782e40994a145065.zip
CrashDaemon: Remove BACKTRACE_DEBUG debugging code
This thing seems to work fine, no need to hang on to old debug code.
-rw-r--r--AK/Debug.h.in4
-rw-r--r--Meta/CMake/all_the_debug_macros.cmake1
-rw-r--r--Userland/Services/CrashDaemon/main.cpp11
3 files changed, 0 insertions, 16 deletions
diff --git a/AK/Debug.h.in b/AK/Debug.h.in
index 3b936c4e3d..5b0d8178d3 100644
--- a/AK/Debug.h.in
+++ b/AK/Debug.h.in
@@ -14,10 +14,6 @@
#cmakedefine01 AFLACLOADER_DEBUG
#endif
-#ifndef BACKTRACE_DEBUG
-#cmakedefine01 BACKTRACE_DEBUG
-#endif
-
#ifndef BMP_DEBUG
#cmakedefine01 BMP_DEBUG
#endif
diff --git a/Meta/CMake/all_the_debug_macros.cmake b/Meta/CMake/all_the_debug_macros.cmake
index 288bbd6353..14bca912c3 100644
--- a/Meta/CMake/all_the_debug_macros.cmake
+++ b/Meta/CMake/all_the_debug_macros.cmake
@@ -5,7 +5,6 @@ set(APIC_SMP_DEBUG ON)
set(ARP_DEBUG ON)
set(AWAVLOADER_DEBUG ON)
set(AFLACLOADER_DEBUG ON)
-set(BACKTRACE_DEBUG ON)
set(BBFS_DEBUG ON)
set(BMP_DEBUG ON)
set(BXVGA_DEBUG ON)
diff --git a/Userland/Services/CrashDaemon/main.cpp b/Userland/Services/CrashDaemon/main.cpp
index c8b314b10e..6ab73070cf 100644
--- a/Userland/Services/CrashDaemon/main.cpp
+++ b/Userland/Services/CrashDaemon/main.cpp
@@ -75,18 +75,7 @@ static void print_backtrace(const String& coredump_path)
dbgln();
dbgln("--- Backtrace for thread #{} (TID {}) ---", thread_index, thread_info.tid);
for (auto& entry : backtrace.entries()) {
-#ifndef BACKTRACE_DEBUG
dbgln("{}", entry.to_string(true));
-#else
- auto region = coredump->region_containing(entry.eip);
- String name;
- u32 base_addr { 0 };
- if (region) {
- name = region->region_name;
- base_addr = region->region_start;
- }
- dbgln("{} ({} base: {:p}, offset: {:p})", entry.to_string(true), name, base_addr, entry.eip - base_addr);
-#endif
}
++thread_index;
return IterationDecision::Continue;