diff options
author | Lenny Maiorani <lenny@serenityos.org> | 2022-02-10 12:28:48 -0700 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2022-02-14 22:06:55 +0000 |
commit | 160bda72280fd61e3059163c267abf542439f852 (patch) | |
tree | 036dd1a14419934255933487c62237ba8d80b0fd | |
parent | 6be75bd5e41f40b31721e5c22184d50ae1c440b7 (diff) | |
download | serenity-160bda72280fd61e3059163c267abf542439f852.zip |
Applications: Use default constructors/destructors
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules
"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
195 files changed, 335 insertions, 638 deletions
diff --git a/Userland/Applications/3DFileViewer/MeshLoader.h b/Userland/Applications/3DFileViewer/MeshLoader.h index 9676bf2604..04b8c10146 100644 --- a/Userland/Applications/3DFileViewer/MeshLoader.h +++ b/Userland/Applications/3DFileViewer/MeshLoader.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Jesse Buhagiar <jooster669@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,8 +15,8 @@ class MeshLoader { public: - MeshLoader() { } - virtual ~MeshLoader() { } + MeshLoader() = default; + virtual ~MeshLoader() = default; virtual RefPtr<Mesh> load(Core::File& file) = 0; }; diff --git a/Userland/Applications/3DFileViewer/WavefrontOBJLoader.h b/Userland/Applications/3DFileViewer/WavefrontOBJLoader.h index afebce1384..67a260b46c 100644 --- a/Userland/Applications/3DFileViewer/WavefrontOBJLoader.h +++ b/Userland/Applications/3DFileViewer/WavefrontOBJLoader.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Jesse Buhagiar <jooster669@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,8 +15,8 @@ class WavefrontOBJLoader final : public MeshLoader { public: - WavefrontOBJLoader() { } - ~WavefrontOBJLoader() override { } + WavefrontOBJLoader() = default; + ~WavefrontOBJLoader() override = default; RefPtr<Mesh> load(Core::File& file) override; }; diff --git a/Userland/Applications/Browser/BrowserWindow.cpp b/Userland/Applications/Browser/BrowserWindow.cpp index b75ac99b75..3eb8344378 100644 --- a/Userland/Applications/Browser/BrowserWindow.cpp +++ b/Userland/Applications/Browser/BrowserWindow.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Jakob-Niklas See <git@nwex.de> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -131,10 +132,6 @@ BrowserWindow::BrowserWindow(CookieJar& cookie_jar, URL url) create_new_tab(move(url), true); } -BrowserWindow::~BrowserWindow() -{ -} - void BrowserWindow::build_menus() { auto& file_menu = add_menu("&File"); diff --git a/Userland/Applications/Browser/BrowserWindow.h b/Userland/Applications/Browser/BrowserWindow.h index 672f8a7b92..826cb33bb7 100644 --- a/Userland/Applications/Browser/BrowserWindow.h +++ b/Userland/Applications/Browser/BrowserWindow.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class BrowserWindow final : public GUI::Window { C_OBJECT(BrowserWindow); public: - virtual ~BrowserWindow() override; + virtual ~BrowserWindow() override = default; GUI::TabWidget& tab_widget(); Tab& active_tab(); diff --git a/Userland/Applications/Browser/ConsoleWidget.cpp b/Userland/Applications/Browser/ConsoleWidget.cpp index 9f46618ce4..53e3f1d9fc 100644 --- a/Userland/Applications/Browser/ConsoleWidget.cpp +++ b/Userland/Applications/Browser/ConsoleWidget.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2020, Hunter Salyer <thefalsehonesty@gmail.com> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -68,10 +69,6 @@ ConsoleWidget::ConsoleWidget() }; } -ConsoleWidget::~ConsoleWidget() -{ -} - void ConsoleWidget::request_console_messages() { VERIFY(!m_waiting_for_messages); diff --git a/Userland/Applications/Browser/ConsoleWidget.h b/Userland/Applications/Browser/ConsoleWidget.h index 82eac6f07b..4683a84e2e 100644 --- a/Userland/Applications/Browser/ConsoleWidget.h +++ b/Userland/Applications/Browser/ConsoleWidget.h @@ -2,6 +2,7 @@ * Copyright (c) 2020, Hunter Salyer <thefalsehonesty@gmail.com> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +18,7 @@ namespace Browser { class ConsoleWidget final : public GUI::Widget { C_OBJECT(ConsoleWidget) public: - virtual ~ConsoleWidget(); + virtual ~ConsoleWidget() = default; void notify_about_new_console_message(i32 message_index); void handle_console_messages(i32 start_index, Vector<String> const& message_types, Vector<String> const& messages); diff --git a/Userland/Applications/Browser/DownloadWidget.cpp b/Userland/Applications/Browser/DownloadWidget.cpp index 880f9b4566..3b173ce0f2 100644 --- a/Userland/Applications/Browser/DownloadWidget.cpp +++ b/Userland/Applications/Browser/DownloadWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -110,10 +111,6 @@ DownloadWidget::DownloadWidget(const URL& url) }; } -DownloadWidget::~DownloadWidget() -{ -} - void DownloadWidget::did_progress(Optional<u32> total_size, u32 downloaded_size) { m_progressbar->set_min(0); diff --git a/Userland/Applications/Browser/DownloadWidget.h b/Userland/Applications/Browser/DownloadWidget.h index 8b37aab4ed..c4b8604856 100644 --- a/Userland/Applications/Browser/DownloadWidget.h +++ b/Userland/Applications/Browser/DownloadWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,7 +21,7 @@ class DownloadWidget final : public GUI::Widget { C_OBJECT(DownloadWidget); public: - virtual ~DownloadWidget() override; + virtual ~DownloadWidget() override = default; private: explicit DownloadWidget(const URL&); diff --git a/Userland/Applications/Browser/InspectorWidget.cpp b/Userland/Applications/Browser/InspectorWidget.cpp index d51b3fdf9e..a2d72b3687 100644 --- a/Userland/Applications/Browser/InspectorWidget.cpp +++ b/Userland/Applications/Browser/InspectorWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -95,10 +96,6 @@ InspectorWidget::InspectorWidget() m_dom_tree_view->set_focus(true); } -InspectorWidget::~InspectorWidget() -{ -} - void InspectorWidget::select_default_node() { clear_style_json(); diff --git a/Userland/Applications/Browser/InspectorWidget.h b/Userland/Applications/Browser/InspectorWidget.h index 5a906bebd8..cd02355150 100644 --- a/Userland/Applications/Browser/InspectorWidget.h +++ b/Userland/Applications/Browser/InspectorWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ namespace Browser { class InspectorWidget final : public GUI::Widget { C_OBJECT(InspectorWidget) public: - virtual ~InspectorWidget(); + virtual ~InspectorWidget() = default; void set_web_view(NonnullRefPtr<Web::OutOfProcessWebView> web_view) { m_web_view = web_view; } void set_dom_json(String); diff --git a/Userland/Applications/Browser/Tab.cpp b/Userland/Applications/Browser/Tab.cpp index 8ceea29698..06ec6ab64f 100644 --- a/Userland/Applications/Browser/Tab.cpp +++ b/Userland/Applications/Browser/Tab.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Maciej Zygmanowski <sppmacd@pm.me> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -351,10 +352,6 @@ Tab::Tab(BrowserWindow& window) }; } -Tab::~Tab() -{ -} - void Tab::load(const URL& url, LoadType load_type) { m_is_history_navigation = (load_type == LoadType::HistoryNavigation); diff --git a/Userland/Applications/Browser/Tab.h b/Userland/Applications/Browser/Tab.h index 919bf93325..0c47673cb6 100644 --- a/Userland/Applications/Browser/Tab.h +++ b/Userland/Applications/Browser/Tab.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -32,7 +33,7 @@ class Tab final : public GUI::Widget { friend class BrowserWindow; public: - virtual ~Tab() override; + virtual ~Tab() override = default; URL url() const; diff --git a/Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp b/Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp index 7ca9d6a4c7..0499ce63c1 100644 --- a/Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp +++ b/Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp @@ -105,10 +105,6 @@ BrowserSettingsWidget::BrowserSettingsWidget() m_auto_close_download_windows_checkbox->set_checked(Config::read_bool("Browser", "Preferences", "CloseDownloadWidgetOnFinish", default_auto_close_download_windows), GUI::AllowCallback::No); } -BrowserSettingsWidget::~BrowserSettingsWidget() -{ -} - void BrowserSettingsWidget::set_color_scheme(StringView color_scheme) { bool found_color_scheme = false; diff --git a/Userland/Applications/BrowserSettings/BrowserSettingsWidget.h b/Userland/Applications/BrowserSettings/BrowserSettingsWidget.h index 692f865d53..a13bbe5077 100644 --- a/Userland/Applications/BrowserSettings/BrowserSettingsWidget.h +++ b/Userland/Applications/BrowserSettings/BrowserSettingsWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class BrowserSettingsWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(BrowserSettingsWidget) public: - virtual ~BrowserSettingsWidget() override; + virtual ~BrowserSettingsWidget() override = default; virtual void apply_settings() override; virtual void reset_default_values() override; diff --git a/Userland/Applications/Calculator/Calculator.cpp b/Userland/Applications/Calculator/Calculator.cpp index 5af39b6d61..e5865d94f9 100644 --- a/Userland/Applications/Calculator/Calculator.cpp +++ b/Userland/Applications/Calculator/Calculator.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -9,14 +10,6 @@ #include <AK/Assertions.h> #include <AK/Math.h> -Calculator::Calculator() -{ -} - -Calculator::~Calculator() -{ -} - KeypadValue Calculator::begin_operation(Operation operation, KeypadValue argument) { KeypadValue res = 0; diff --git a/Userland/Applications/Calculator/Calculator.h b/Userland/Applications/Calculator/Calculator.h index 91f6c21eff..bbfcac5546 100644 --- a/Userland/Applications/Calculator/Calculator.h +++ b/Userland/Applications/Calculator/Calculator.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,8 +18,8 @@ class Calculator final { public: - Calculator(); - ~Calculator(); + Calculator() = default; + ~Calculator() = default; enum class Operation { None, diff --git a/Userland/Applications/Calculator/CalculatorWidget.cpp b/Userland/Applications/Calculator/CalculatorWidget.cpp index a66099379d..3a37fd4503 100644 --- a/Userland/Applications/Calculator/CalculatorWidget.cpp +++ b/Userland/Applications/Calculator/CalculatorWidget.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> * Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com> * Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -104,10 +105,6 @@ CalculatorWidget::CalculatorWidget() }; } -CalculatorWidget::~CalculatorWidget() -{ -} - void CalculatorWidget::add_operation_button(GUI::Button& button, Calculator::Operation operation) { button.on_click = [this, operation](auto) { diff --git a/Userland/Applications/Calculator/CalculatorWidget.h b/Userland/Applications/Calculator/CalculatorWidget.h index b18570a733..84d2c087de 100644 --- a/Userland/Applications/Calculator/CalculatorWidget.h +++ b/Userland/Applications/Calculator/CalculatorWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> * Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ class CalculatorWidget final : public GUI::Widget { C_OBJECT(CalculatorWidget) public: - virtual ~CalculatorWidget() override; + virtual ~CalculatorWidget() override = default; String get_entry(); void set_entry(KeypadValue); diff --git a/Userland/Applications/Calculator/Keypad.cpp b/Userland/Applications/Calculator/Keypad.cpp index fa473dc5d5..02fdce5884 100644 --- a/Userland/Applications/Calculator/Keypad.cpp +++ b/Userland/Applications/Calculator/Keypad.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> * Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -10,14 +11,6 @@ #include <AK/IntegralMath.h> #include <AK/StringBuilder.h> -Keypad::Keypad() -{ -} - -Keypad::~Keypad() -{ -} - void Keypad::type_digit(int digit) { u64 previous_value = 0; diff --git a/Userland/Applications/Calculator/Keypad.h b/Userland/Applications/Calculator/Keypad.h index 7d10115942..f542aa38bf 100644 --- a/Userland/Applications/Calculator/Keypad.h +++ b/Userland/Applications/Calculator/Keypad.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,8 +17,8 @@ class Keypad final { public: - Keypad(); - ~Keypad(); + Keypad() = default; + ~Keypad() = default; void type_digit(int digit); void type_decimal_point(); diff --git a/Userland/Applications/Calendar/AddEventDialog.cpp b/Userland/Applications/Calendar/AddEventDialog.cpp index 010a89b19a..11a1bc6f1b 100644 --- a/Userland/Applications/Calendar/AddEventDialog.cpp +++ b/Userland/Applications/Calendar/AddEventDialog.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Ryan Grieb <ryan.m.grieb@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -86,18 +87,6 @@ AddEventDialog::AddEventDialog(Core::DateTime date_time, Window* parent_window) event_title_textbox.set_focus(true); } -AddEventDialog::~AddEventDialog() -{ -} - -AddEventDialog::MonthListModel::MonthListModel() -{ -} - -AddEventDialog::MonthListModel::~MonthListModel() -{ -} - int AddEventDialog::MonthListModel::row_count(const GUI::ModelIndex&) const { return 12; diff --git a/Userland/Applications/Calendar/AddEventDialog.h b/Userland/Applications/Calendar/AddEventDialog.h index d63114f02b..49e84dde67 100644 --- a/Userland/Applications/Calendar/AddEventDialog.h +++ b/Userland/Applications/Calendar/AddEventDialog.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Ryan Grieb <ryan.m.grieb@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class AddEventDialog final : public GUI::Dialog { C_OBJECT(AddEventDialog) public: - virtual ~AddEventDialog() override; + virtual ~AddEventDialog() override = default; static void show(Core::DateTime date_time, Window* parent_window = nullptr) { @@ -33,7 +34,7 @@ private: }; static NonnullRefPtr<MonthListModel> create() { return adopt_ref(*new MonthListModel); } - virtual ~MonthListModel() override; + virtual ~MonthListModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; } @@ -41,7 +42,7 @@ private: virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override; private: - MonthListModel(); + MonthListModel() = default; }; Core::DateTime m_date_time; diff --git a/Userland/Applications/CharacterMap/CharacterMapWidget.cpp b/Userland/Applications/CharacterMap/CharacterMapWidget.cpp index 6bc5df218b..19e46f66a3 100644 --- a/Userland/Applications/CharacterMap/CharacterMapWidget.cpp +++ b/Userland/Applications/CharacterMap/CharacterMapWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -123,10 +124,6 @@ CharacterMapWidget::CharacterMapWidget() update_statusbar(); } -CharacterMapWidget::~CharacterMapWidget() -{ -} - void CharacterMapWidget::initialize_menubar(GUI::Window& window) { auto& file_menu = window.add_menu("&File"); diff --git a/Userland/Applications/CharacterMap/CharacterMapWidget.h b/Userland/Applications/CharacterMap/CharacterMapWidget.h index fdf304eaf9..5775536d1a 100644 --- a/Userland/Applications/CharacterMap/CharacterMapWidget.h +++ b/Userland/Applications/CharacterMap/CharacterMapWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class CharacterMapWidget final : public GUI::Widget { C_OBJECT(CharacterMapWidget); public: - virtual ~CharacterMapWidget() override; + virtual ~CharacterMapWidget() override = default; void initialize_menubar(GUI::Window& window); diff --git a/Userland/Applications/CharacterMap/CharacterSearchWidget.cpp b/Userland/Applications/CharacterMap/CharacterSearchWidget.cpp index db25ccc45f..c27571d64e 100644 --- a/Userland/Applications/CharacterMap/CharacterSearchWidget.cpp +++ b/Userland/Applications/CharacterMap/CharacterSearchWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ struct SearchResult { class CharacterSearchModel final : public GUI::Model { public: - CharacterSearchModel() { } + CharacterSearchModel() = default; int row_count(GUI::ModelIndex const&) const override { return m_data.size(); } int column_count(GUI::ModelIndex const&) const override { return 2; } @@ -72,10 +73,6 @@ CharacterSearchWidget::CharacterSearchWidget() }; } -CharacterSearchWidget::~CharacterSearchWidget() -{ -} - void CharacterSearchWidget::search() { // TODO: Sort the results nicely. They're sorted by code-point for now, which is easy, but not the most useful. diff --git a/Userland/Applications/CharacterMap/CharacterSearchWidget.h b/Userland/Applications/CharacterMap/CharacterSearchWidget.h index 51672dfdec..ca0fcce39a 100644 --- a/Userland/Applications/CharacterMap/CharacterSearchWidget.h +++ b/Userland/Applications/CharacterMap/CharacterSearchWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class CharacterSearchWidget final : public GUI::Widget { C_OBJECT(CharacterSearchWidget); public: - virtual ~CharacterSearchWidget() override; + virtual ~CharacterSearchWidget() override = default; Function<void(u32)> on_character_selected; diff --git a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp index 0d9a30a8ed..38bae7e44d 100644 --- a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp +++ b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com> * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -40,10 +41,6 @@ BackgroundSettingsWidget::BackgroundSettingsWidget() load_current_settings(); } -BackgroundSettingsWidget::~BackgroundSettingsWidget() -{ -} - void BackgroundSettingsWidget::create_frame() { load_from_gml(background_settings_gml); diff --git a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h index 1f92eda2a0..0fa8a191cf 100644 --- a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class BackgroundSettingsWidget : public GUI::SettingsWindow::Tab { C_OBJECT(BackgroundSettingsWidget); public: - virtual ~BackgroundSettingsWidget() override; + virtual ~BackgroundSettingsWidget() override = default; virtual void apply_settings() override; diff --git a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp index 6ef80b7573..0585bd98ac 100644 --- a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp +++ b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,10 +21,6 @@ DesktopSettingsWidget::DesktopSettingsWidget() load_current_settings(); } -DesktopSettingsWidget::~DesktopSettingsWidget() -{ -} - void DesktopSettingsWidget::create_frame() { load_from_gml(desktop_settings_gml); diff --git a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h index 189d0bf18c..9f9d7c12db 100644 --- a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +16,7 @@ class DesktopSettingsWidget : public GUI::SettingsWindow::Tab { C_OBJECT(DesktopSettingsWidget); public: - virtual ~DesktopSettingsWidget() override; + virtual ~DesktopSettingsWidget() override = default; virtual void apply_settings() override; diff --git a/Userland/Applications/DisplaySettings/FontSettingsWidget.cpp b/Userland/Applications/DisplaySettings/FontSettingsWidget.cpp index 9b07151ba7..433e838e60 100644 --- a/Userland/Applications/DisplaySettings/FontSettingsWidget.cpp +++ b/Userland/Applications/DisplaySettings/FontSettingsWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Thomas Keppler <winfr34k@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -45,10 +46,6 @@ FontSettingsWidget::FontSettingsWidget() }; } -FontSettingsWidget::~FontSettingsWidget() -{ -} - static void update_label_with_font(GUI::Label& label, Gfx::Font const& font) { label.set_text(font.human_readable_name()); diff --git a/Userland/Applications/DisplaySettings/FontSettingsWidget.h b/Userland/Applications/DisplaySettings/FontSettingsWidget.h index 642c7d1934..490b6e00b9 100644 --- a/Userland/Applications/DisplaySettings/FontSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/FontSettingsWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class FontSettingsWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(FontSettingsWidget); public: - virtual ~FontSettingsWidget() override; + virtual ~FontSettingsWidget() override = default; virtual void apply_settings() override; diff --git a/Userland/Applications/FileManager/DesktopWidget.cpp b/Userland/Applications/FileManager/DesktopWidget.cpp index 956773538b..64b6989a61 100644 --- a/Userland/Applications/FileManager/DesktopWidget.cpp +++ b/Userland/Applications/FileManager/DesktopWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -9,14 +10,6 @@ namespace FileManager { -DesktopWidget::DesktopWidget() -{ -} - -DesktopWidget::~DesktopWidget() -{ -} - void DesktopWidget::paint_event(GUI::PaintEvent& event) { GUI::Painter painter(*this); diff --git a/Userland/Applications/FileManager/DesktopWidget.h b/Userland/Applications/FileManager/DesktopWidget.h index 708af99981..0a4a2a7a03 100644 --- a/Userland/Applications/FileManager/DesktopWidget.h +++ b/Userland/Applications/FileManager/DesktopWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,12 +15,12 @@ class DesktopWidget final : public GUI::Widget { C_OBJECT(DesktopWidget); public: - virtual ~DesktopWidget() override; + virtual ~DesktopWidget() override = default; private: virtual void paint_event(GUI::PaintEvent&) override; - DesktopWidget(); + DesktopWidget() = default; }; } diff --git a/Userland/Applications/FileManager/PropertiesWindow.cpp b/Userland/Applications/FileManager/PropertiesWindow.cpp index dbff9c91f6..ac83c0986f 100644 --- a/Userland/Applications/FileManager/PropertiesWindow.cpp +++ b/Userland/Applications/FileManager/PropertiesWindow.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -162,10 +163,6 @@ PropertiesWindow::PropertiesWindow(String const& path, bool disable_rename, Wind update(); } -PropertiesWindow::~PropertiesWindow() -{ -} - void PropertiesWindow::update() { m_icon->set_bitmap(GUI::FileIconProvider::icon_for_path(make_full_path(m_name), m_mode).bitmap_for_size(32)); diff --git a/Userland/Applications/FileManager/PropertiesWindow.h b/Userland/Applications/FileManager/PropertiesWindow.h index b8704ef483..c1150a8deb 100644 --- a/Userland/Applications/FileManager/PropertiesWindow.h +++ b/Userland/Applications/FileManager/PropertiesWindow.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +19,7 @@ class PropertiesWindow final : public GUI::Window { C_OBJECT(PropertiesWindow); public: - virtual ~PropertiesWindow() override; + virtual ~PropertiesWindow() override = default; private: PropertiesWindow(String const& path, bool disable_rename, Window* parent = nullptr); diff --git a/Userland/Applications/FontEditor/FontEditor.cpp b/Userland/Applications/FontEditor/FontEditor.cpp index 8f52892d71..bc56a8a4d9 100644 --- a/Userland/Applications/FontEditor/FontEditor.cpp +++ b/Userland/Applications/FontEditor/FontEditor.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -437,10 +438,6 @@ FontEditorWidget::FontEditorWidget() set_scale(scale); } -FontEditorWidget::~FontEditorWidget() -{ -} - void FontEditorWidget::initialize(String const& path, RefPtr<Gfx::BitmapFont>&& edited_font) { if (m_edited_font == edited_font) diff --git a/Userland/Applications/FontEditor/FontEditor.h b/Userland/Applications/FontEditor/FontEditor.h index 94caae424a..ed74b541df 100644 --- a/Userland/Applications/FontEditor/FontEditor.h +++ b/Userland/Applications/FontEditor/FontEditor.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class FontEditorWidget final , public Config::Listener { C_OBJECT(FontEditorWidget) public: - virtual ~FontEditorWidget() override; + virtual ~FontEditorWidget() override = default; bool open_file(String const&); bool save_file(String const&); diff --git a/Userland/Applications/FontEditor/GlyphEditorWidget.cpp b/Userland/Applications/FontEditor/GlyphEditorWidget.cpp index 3c1fe4315e..1a2bb480fe 100644 --- a/Userland/Applications/FontEditor/GlyphEditorWidget.cpp +++ b/Userland/Applications/FontEditor/GlyphEditorWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,10 +14,6 @@ #include <LibGfx/Palette.h> #include <string.h> -GlyphEditorWidget::~GlyphEditorWidget() -{ -} - void GlyphEditorWidget::initialize(Gfx::BitmapFont& mutable_font) { if (m_font == mutable_font) diff --git a/Userland/Applications/FontEditor/GlyphEditorWidget.h b/Userland/Applications/FontEditor/GlyphEditorWidget.h index 08aebb4061..eabbc01fc1 100644 --- a/Userland/Applications/FontEditor/GlyphEditorWidget.h +++ b/Userland/Applications/FontEditor/GlyphEditorWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,7 +24,7 @@ public: Counterclockwise }; - virtual ~GlyphEditorWidget() override; + virtual ~GlyphEditorWidget() override = default; void initialize(Gfx::BitmapFont&); diff --git a/Userland/Applications/Help/ManualNode.h b/Userland/Applications/Help/ManualNode.h index 6b6b2386de..34971e234d 100644 --- a/Userland/Applications/Help/ManualNode.h +++ b/Userland/Applications/Help/ManualNode.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,7 +12,7 @@ class ManualNode { public: - virtual ~ManualNode() { } + virtual ~ManualNode() = default; virtual NonnullOwnPtrVector<ManualNode>& children() const = 0; virtual const ManualNode* parent() const = 0; diff --git a/Userland/Applications/Help/ManualPageNode.cpp b/Userland/Applications/Help/ManualPageNode.cpp index f512d3c19c..dc28cb4c08 100644 --- a/Userland/Applications/Help/ManualPageNode.cpp +++ b/Userland/Applications/Help/ManualPageNode.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ diff --git a/Userland/Applications/Help/ManualPageNode.h b/Userland/Applications/Help/ManualPageNode.h index 8e366eae42..0f60dd6569 100644 --- a/Userland/Applications/Help/ManualPageNode.h +++ b/Userland/Applications/Help/ManualPageNode.h @@ -12,7 +12,7 @@ class ManualSectionNode; class ManualPageNode : public ManualNode { public: - virtual ~ManualPageNode() override { } + virtual ~ManualPageNode() override = default; ManualPageNode(const ManualSectionNode& section, StringView page) : m_section(section) diff --git a/Userland/Applications/Help/ManualSectionNode.h b/Userland/Applications/Help/ManualSectionNode.h index 94346d3492..468137066c 100644 --- a/Userland/Applications/Help/ManualSectionNode.h +++ b/Userland/Applications/Help/ManualSectionNode.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -10,7 +11,7 @@ class ManualSectionNode : public ManualNode { public: - virtual ~ManualSectionNode() override { } + virtual ~ManualSectionNode() override = default; ManualSectionNode(String section, String name) : m_section(section) diff --git a/Userland/Applications/HexEditor/FindDialog.cpp b/Userland/Applications/HexEditor/FindDialog.cpp index 1ab00ffbd2..f2ef50fd2f 100644 --- a/Userland/Applications/HexEditor/FindDialog.cpp +++ b/Userland/Applications/HexEditor/FindDialog.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -150,7 +150,3 @@ FindDialog::FindDialog() done(ExecResult::ExecCancel); }; } - -FindDialog::~FindDialog() -{ -} diff --git a/Userland/Applications/HexEditor/FindDialog.h b/Userland/Applications/HexEditor/FindDialog.h index 169f9f6d82..89063c5360 100644 --- a/Userland/Applications/HexEditor/FindDialog.h +++ b/Userland/Applications/HexEditor/FindDialog.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -29,7 +29,7 @@ private: bool find_all() const { return m_find_all; } FindDialog(); - virtual ~FindDialog() override; + virtual ~FindDialog() override = default; RefPtr<GUI::TextEditor> m_text_editor; RefPtr<GUI::Button> m_find_button; diff --git a/Userland/Applications/HexEditor/GoToOffsetDialog.cpp b/Userland/Applications/HexEditor/GoToOffsetDialog.cpp index 9940b19169..99b2aedff2 100644 --- a/Userland/Applications/HexEditor/GoToOffsetDialog.cpp +++ b/Userland/Applications/HexEditor/GoToOffsetDialog.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -146,7 +146,3 @@ GoToOffsetDialog::GoToOffsetDialog() update_statusbar(); } - -GoToOffsetDialog::~GoToOffsetDialog() -{ -} diff --git a/Userland/Applications/HexEditor/GoToOffsetDialog.h b/Userland/Applications/HexEditor/GoToOffsetDialog.h index 358b04bf6d..fc118b28f4 100644 --- a/Userland/Applications/HexEditor/GoToOffsetDialog.h +++ b/Userland/Applications/HexEditor/GoToOffsetDialog.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +18,7 @@ public: private: GoToOffsetDialog(); - virtual ~GoToOffsetDialog() override; + virtual ~GoToOffsetDialog() override = default; void update_statusbar(); int process_input(); int calculate_new_offset(int offset); diff --git a/Userland/Applications/HexEditor/HexEditor.cpp b/Userland/Applications/HexEditor/HexEditor.cpp index 86b41e9448..1106057b11 100644 --- a/Userland/Applications/HexEditor/HexEditor.cpp +++ b/Userland/Applications/HexEditor/HexEditor.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -47,10 +48,6 @@ HexEditor::HexEditor() m_blink_timer->start(); } -HexEditor::~HexEditor() -{ -} - void HexEditor::set_readonly(bool readonly) { if (m_readonly == readonly) diff --git a/Userland/Applications/HexEditor/HexEditor.h b/Userland/Applications/HexEditor/HexEditor.h index 07834dee76..84989e0a95 100644 --- a/Userland/Applications/HexEditor/HexEditor.h +++ b/Userland/Applications/HexEditor/HexEditor.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,7 +29,7 @@ public: Text }; - virtual ~HexEditor() override; + virtual ~HexEditor() override = default; bool is_readonly() const { return m_readonly; } void set_readonly(bool); diff --git a/Userland/Applications/HexEditor/HexEditorWidget.cpp b/Userland/Applications/HexEditor/HexEditorWidget.cpp index 2c9fa88fe2..8e3a6e267e 100644 --- a/Userland/Applications/HexEditor/HexEditorWidget.cpp +++ b/Userland/Applications/HexEditor/HexEditorWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -202,10 +203,6 @@ HexEditorWidget::HexEditorWidget() m_editor->set_focus(true); } -HexEditorWidget::~HexEditorWidget() -{ -} - void HexEditorWidget::initialize_menubar(GUI::Window& window) { auto& file_menu = window.add_menu("&File"); diff --git a/Userland/Applications/HexEditor/HexEditorWidget.h b/Userland/Applications/HexEditor/HexEditorWidget.h index f07f5fe2fc..f4f3a6f470 100644 --- a/Userland/Applications/HexEditor/HexEditorWidget.h +++ b/Userland/Applications/HexEditor/HexEditorWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class HexEditor; class HexEditorWidget final : public GUI::Widget { C_OBJECT(HexEditorWidget) public: - virtual ~HexEditorWidget() override; + virtual ~HexEditorWidget() override = default; void open_file(NonnullRefPtr<Core::File>); void initialize_menubar(GUI::Window&); bool request_close(); diff --git a/Userland/Applications/ImageViewer/ViewWidget.cpp b/Userland/Applications/ImageViewer/ViewWidget.cpp index ebba2ba053..156f8c66bf 100644 --- a/Userland/Applications/ImageViewer/ViewWidget.cpp +++ b/Userland/Applications/ImageViewer/ViewWidget.cpp @@ -3,6 +3,7 @@ * Copyright (c) 2021, Linus Groh <linusg@serenityos.org> * Copyright (c) 2021, Mohsan Ali <mohsan0073@gmail.com> * Copyright (c) 2022, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,10 +29,6 @@ ViewWidget::ViewWidget() set_fill_with_background_color(false); } -ViewWidget::~ViewWidget() -{ -} - void ViewWidget::clear() { m_timer->stop(); diff --git a/Userland/Applications/ImageViewer/ViewWidget.h b/Userland/Applications/ImageViewer/ViewWidget.h index 364a51fe15..b016cd80e7 100644 --- a/Userland/Applications/ImageViewer/ViewWidget.h +++ b/Userland/Applications/ImageViewer/ViewWidget.h @@ -3,6 +3,7 @@ * Copyright (c) 2021, Linus Groh <linusg@serenityos.org> * Copyright (c) 2021, Mohsan Ali <mohsan0073@gmail.com> * Copyright (c) 2022, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,7 +27,7 @@ public: Last }; - virtual ~ViewWidget() override; + virtual ~ViewWidget() override = default; const Gfx::Bitmap* bitmap() const { return m_bitmap.ptr(); } const String& path() const { return m_path; } diff --git a/Userland/Applications/KeyboardMapper/KeyButton.cpp b/Userland/Applications/KeyboardMapper/KeyButton.cpp index 401118c629..6e8d97caed 100644 --- a/Userland/Applications/KeyboardMapper/KeyButton.cpp +++ b/Userland/Applications/KeyboardMapper/KeyButton.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com> * Copyright (c) 2021, Rasmus Nylander <RasmusNylander.SerenityOS@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,10 +12,6 @@ #include <LibGfx/Font.h> #include <LibGfx/Palette.h> -KeyButton::~KeyButton() -{ -} - void KeyButton::paint_event(GUI::PaintEvent& event) { GUI::Painter painter(*this); diff --git a/Userland/Applications/KeyboardMapper/KeyButton.h b/Userland/Applications/KeyboardMapper/KeyButton.h index 31b03ffe9f..d8d444cfc6 100644 --- a/Userland/Applications/KeyboardMapper/KeyButton.h +++ b/Userland/Applications/KeyboardMapper/KeyButton.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class KeyButton final : public GUI::AbstractButton { C_OBJECT(KeyButton) public: - virtual ~KeyButton() override; + virtual ~KeyButton() override = default; void set_pressed(bool value) { m_pressed = value; } diff --git a/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.cpp b/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.cpp index aee0ab7b57..8417d149eb 100644 --- a/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.cpp +++ b/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com> * Copyright (c) 2021, Rasmus Nylander <RasmusNylander.SerenityOS@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,10 +21,6 @@ KeyboardMapperWidget::KeyboardMapperWidget() create_frame(); } -KeyboardMapperWidget::~KeyboardMapperWidget() -{ -} - void KeyboardMapperWidget::create_frame() { set_fill_with_background_color(true); diff --git a/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h b/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h index 90807f4069..e1c854755f 100644 --- a/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h +++ b/Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class KeyboardMapperWidget final : public GUI::Widget { C_OBJECT(KeyboardMapperWidget) public: - virtual ~KeyboardMapperWidget() override; + virtual ~KeyboardMapperWidget() override = default; void create_frame(); ErrorOr<void> load_map_from_file(const String&); diff --git a/Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp b/Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp index e3d95390f6..eba887b3cc 100644 --- a/Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp +++ b/Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,7 +29,7 @@ class KeymapSelectionDialog final : public GUI::Dialog { C_OBJECT(KeymapSelectionDialog) public: - virtual ~KeymapSelectionDialog() override {}; + virtual ~KeymapSelectionDialog() override = default; static String select_keymap(Window* parent_window, Vector<String> const& selected_keymaps) { diff --git a/Userland/Applications/Magnifier/MagnifierWidget.cpp b/Userland/Applications/Magnifier/MagnifierWidget.cpp index b069eceeca..b60bcc25e6 100644 --- a/Userland/Applications/Magnifier/MagnifierWidget.cpp +++ b/Userland/Applications/Magnifier/MagnifierWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Valtteri Koskivuori <vkoskiv@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,10 +17,6 @@ MagnifierWidget::MagnifierWidget() GUI::DisplayLink::register_callback([this](auto) { sync(); }); } -MagnifierWidget::~MagnifierWidget() -{ -} - void MagnifierWidget::set_scale_factor(int scale_factor) { VERIFY(scale_factor == 2 || scale_factor == 4 || scale_factor == 8); diff --git a/Userland/Applications/Magnifier/MagnifierWidget.h b/Userland/Applications/Magnifier/MagnifierWidget.h index 0a7af0a4be..b19b991f16 100644 --- a/Userland/Applications/Magnifier/MagnifierWidget.h +++ b/Userland/Applications/Magnifier/MagnifierWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Valtteri Koskivuori <vkoskiv@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class MagnifierWidget final : public GUI::Frame { C_OBJECT(MagnifierWidget); public: - virtual ~MagnifierWidget(); + virtual ~MagnifierWidget() override = default; void set_scale_factor(int scale_factor); void set_color_filter(OwnPtr<Gfx::ColorBlindnessFilter>); void pause_capture(bool pause) diff --git a/Userland/Applications/Mail/AccountHolder.cpp b/Userland/Applications/Mail/AccountHolder.cpp index f2edd1b236..e9f56a973b 100644 --- a/Userland/Applications/Mail/AccountHolder.cpp +++ b/Userland/Applications/Mail/AccountHolder.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,10 +12,6 @@ AccountHolder::AccountHolder() m_mailbox_tree_model = MailboxTreeModel::create(*this); } -AccountHolder::~AccountHolder() -{ -} - void AccountHolder::add_account_with_name_and_mailboxes(String name, Vector<IMAP::ListItem> const& mailboxes) { auto account = AccountNode::create(move(name)); diff --git a/Userland/Applications/Mail/AccountHolder.h b/Userland/Applications/Mail/AccountHolder.h index 56a134a15d..fa694f271a 100644 --- a/Userland/Applications/Mail/AccountHolder.h +++ b/Userland/Applications/Mail/AccountHolder.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -86,7 +87,7 @@ private: class AccountHolder { public: - ~AccountHolder(); + ~AccountHolder() = default; static NonnullOwnPtr<AccountHolder> create() { diff --git a/Userland/Applications/Mail/InboxModel.cpp b/Userland/Applications/Mail/InboxModel.cpp index 4c1417e0ad..c5a1a39295 100644 --- a/Userland/Applications/Mail/InboxModel.cpp +++ b/Userland/Applications/Mail/InboxModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,10 +12,6 @@ InboxModel::InboxModel(Vector<InboxEntry> entries) { } -InboxModel::~InboxModel() -{ -} - int InboxModel::row_count(GUI::ModelIndex const&) const { return m_entries.size(); diff --git a/Userland/Applications/Mail/InboxModel.h b/Userland/Applications/Mail/InboxModel.h index 02d2f569d9..a878d77e30 100644 --- a/Userland/Applications/Mail/InboxModel.h +++ b/Userland/Applications/Mail/InboxModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -27,7 +28,7 @@ public: return adopt_ref(*new InboxModel(move(inbox_entries))); } - virtual ~InboxModel() override; + virtual ~InboxModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; } diff --git a/Userland/Applications/Mail/MailWidget.cpp b/Userland/Applications/Mail/MailWidget.cpp index e5e6670233..50fe6aad45 100644 --- a/Userland/Applications/Mail/MailWidget.cpp +++ b/Userland/Applications/Mail/MailWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> * Copyright (c) 2021, Undefine <cqundefine@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -95,10 +96,6 @@ MailWidget::MailWidget() }; } -MailWidget::~MailWidget() -{ -} - bool MailWidget::connect_and_login() { auto server = Config::read_string("Mail", "Connection", "Server", {}); diff --git a/Userland/Applications/Mail/MailWidget.h b/Userland/Applications/Mail/MailWidget.h index fe135f6035..650e0d65a1 100644 --- a/Userland/Applications/Mail/MailWidget.h +++ b/Userland/Applications/Mail/MailWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +18,7 @@ class MailWidget final : public GUI::Widget { C_OBJECT(MailWidget) public: - virtual ~MailWidget() override; + virtual ~MailWidget() override = default; bool connect_and_login(); diff --git a/Userland/Applications/Mail/MailboxTreeModel.cpp b/Userland/Applications/Mail/MailboxTreeModel.cpp index eb80315f8c..9f78366852 100644 --- a/Userland/Applications/Mail/MailboxTreeModel.cpp +++ b/Userland/Applications/Mail/MailboxTreeModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,10 +16,6 @@ MailboxTreeModel::MailboxTreeModel(AccountHolder const& account_holder) m_account_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/home-directory.png").release_value_but_fixme_should_propagate_errors()); } -MailboxTreeModel::~MailboxTreeModel() -{ -} - GUI::ModelIndex MailboxTreeModel::index(int row, int column, GUI::ModelIndex const& parent) const { if (!parent.is_valid()) { diff --git a/Userland/Applications/Mail/MailboxTreeModel.h b/Userland/Applications/Mail/MailboxTreeModel.h index 3df0c1ba62..3683f6034b 100644 --- a/Userland/Applications/Mail/MailboxTreeModel.h +++ b/Userland/Applications/Mail/MailboxTreeModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +19,7 @@ public: return adopt_ref(*new MailboxTreeModel(account_holder)); } - virtual ~MailboxTreeModel() override; + virtual ~MailboxTreeModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; diff --git a/Userland/Applications/MouseSettings/DoubleClickArrowWidget.cpp b/Userland/Applications/MouseSettings/DoubleClickArrowWidget.cpp index a72ad35010..aa49d2ca4c 100644 --- a/Userland/Applications/MouseSettings/DoubleClickArrowWidget.cpp +++ b/Userland/Applications/MouseSettings/DoubleClickArrowWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mathias Jakobsen <mathias@jbcoding.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,10 +14,6 @@ REGISTER_WIDGET(MouseSettings, DoubleClickArrowWidget); namespace MouseSettings { -DoubleClickArrowWidget::~DoubleClickArrowWidget() -{ -} - void DoubleClickArrowWidget::set_double_click_speed(int speed) { if (m_double_click_speed == speed) diff --git a/Userland/Applications/MouseSettings/DoubleClickArrowWidget.h b/Userland/Applications/MouseSettings/DoubleClickArrowWidget.h index d65e053a5e..519943bddb 100644 --- a/Userland/Applications/MouseSettings/DoubleClickArrowWidget.h +++ b/Userland/Applications/MouseSettings/DoubleClickArrowWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mathias Jakobsen <mathias@jbcoding.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ class DoubleClickArrowWidget final : public GUI::Widget { C_OBJECT(DoubleClickArrowWidget); public: - virtual ~DoubleClickArrowWidget() override; + virtual ~DoubleClickArrowWidget() override = default; void set_double_click_speed(int); private: diff --git a/Userland/Applications/MouseSettings/MouseWidget.cpp b/Userland/Applications/MouseSettings/MouseWidget.cpp index 31fd759f8b..045510f904 100644 --- a/Userland/Applications/MouseSettings/MouseWidget.cpp +++ b/Userland/Applications/MouseSettings/MouseWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -65,7 +65,3 @@ void MouseWidget::reset_default_values() m_double_click_speed_slider->set_value(double_click_speed_default); m_switch_buttons_checkbox->set_checked(false); } - -MouseWidget::~MouseWidget() -{ -} diff --git a/Userland/Applications/MouseSettings/MouseWidget.h b/Userland/Applications/MouseSettings/MouseWidget.h index ab9181d9fd..9779babbd7 100644 --- a/Userland/Applications/MouseSettings/MouseWidget.h +++ b/Userland/Applications/MouseSettings/MouseWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +14,7 @@ class MouseWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(MouseWidget) public: - virtual ~MouseWidget() override; + virtual ~MouseWidget() override = default; virtual void apply_settings() override; virtual void reset_default_values() override; diff --git a/Userland/Applications/MouseSettings/ThemeWidget.cpp b/Userland/Applications/MouseSettings/ThemeWidget.cpp index 32d2e0ce64..6fc7749d90 100644 --- a/Userland/Applications/MouseSettings/ThemeWidget.cpp +++ b/Userland/Applications/MouseSettings/ThemeWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -137,7 +137,3 @@ void ThemeWidget::reset_default_values() { m_theme_name_box->set_text("Default"); } - -ThemeWidget::~ThemeWidget() -{ -} diff --git a/Userland/Applications/MouseSettings/ThemeWidget.h b/Userland/Applications/MouseSettings/ThemeWidget.h index 5e54ce1f05..74fa63fe34 100644 --- a/Userland/Applications/MouseSettings/ThemeWidget.h +++ b/Userland/Applications/MouseSettings/ThemeWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +14,7 @@ class MouseCursorModel final : public GUI::Model { public: static NonnullRefPtr<MouseCursorModel> create() { return adopt_ref(*new MouseCursorModel); } - virtual ~MouseCursorModel() override { } + virtual ~MouseCursorModel() override = default; enum Column { Bitmap, @@ -36,7 +36,7 @@ public: } private: - MouseCursorModel() { } + MouseCursorModel() = default; struct Cursor { RefPtr<Gfx::Bitmap> bitmap; @@ -65,7 +65,7 @@ private: class ThemeWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(ThemeWidget) public: - virtual ~ThemeWidget() override; + virtual ~ThemeWidget() override = default; virtual void apply_settings() override; virtual void reset_default_values() override; diff --git a/Userland/Applications/Piano/KeysWidget.cpp b/Userland/Applications/Piano/KeysWidget.cpp index ae3124154a..5d128b4523 100644 --- a/Userland/Applications/Piano/KeysWidget.cpp +++ b/Userland/Applications/Piano/KeysWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,10 +18,6 @@ KeysWidget::KeysWidget(TrackManager& track_manager) set_fill_with_background_color(true); } -KeysWidget::~KeysWidget() -{ -} - int KeysWidget::mouse_note() const { if (m_mouse_down && m_mouse_note + m_track_manager.octave_base() < note_count) diff --git a/Userland/Applications/Piano/KeysWidget.h b/Userland/Applications/Piano/KeysWidget.h index 1b72456e0e..daf6048837 100644 --- a/Userland/Applications/Piano/KeysWidget.h +++ b/Userland/Applications/Piano/KeysWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class TrackManager; class KeysWidget final : public GUI::Frame { C_OBJECT(KeysWidget) public: - virtual ~KeysWidget() override; + virtual ~KeysWidget() override = default; int key_code_to_key(int key_code) const; int mouse_note() const; diff --git a/Userland/Applications/Piano/KnobsWidget.cpp b/Userland/Applications/Piano/KnobsWidget.cpp index 2e84504cd7..17fe3486fa 100644 --- a/Userland/Applications/Piano/KnobsWidget.cpp +++ b/Userland/Applications/Piano/KnobsWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -103,10 +104,6 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget) } } -KnobsWidget::~KnobsWidget() -{ -} - void KnobsWidget::cycle_waveform() { m_synth_waveform->set_selected_index((m_synth_waveform->selected_index() + 1) % m_synth_waveform->model()->row_count()); diff --git a/Userland/Applications/Piano/KnobsWidget.h b/Userland/Applications/Piano/KnobsWidget.h index 25c6add299..9021f76651 100644 --- a/Userland/Applications/Piano/KnobsWidget.h +++ b/Userland/Applications/Piano/KnobsWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -22,7 +23,7 @@ class MainWidget; class KnobsWidget final : public GUI::Frame { C_OBJECT(KnobsWidget) public: - virtual ~KnobsWidget() override; + virtual ~KnobsWidget() override = default; void update_knobs(); void cycle_waveform(); diff --git a/Userland/Applications/Piano/MainWidget.cpp b/Userland/Applications/Piano/MainWidget.cpp index 2c83269f73..34b0e3be63 100644 --- a/Userland/Applications/Piano/MainWidget.cpp +++ b/Userland/Applications/Piano/MainWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -52,10 +53,6 @@ MainWidget::MainWidget(TrackManager& track_manager, AudioPlayerLoop& loop) m_roll_widget->set_keys_widget(m_keys_widget); } -MainWidget::~MainWidget() -{ -} - void MainWidget::add_track_actions(GUI::Menu& menu) { menu.add_action(GUI::Action::create("&Add Track", { Mod_Ctrl, Key_T }, [&](auto&) { diff --git a/Userland/Applications/Piano/MainWidget.h b/Userland/Applications/Piano/MainWidget.h index e71a8572c0..845465b1e5 100644 --- a/Userland/Applications/Piano/MainWidget.h +++ b/Userland/Applications/Piano/MainWidget.h @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,7 +24,7 @@ class PlayerWidget; class MainWidget final : public GUI::Widget { C_OBJECT(MainWidget) public: - virtual ~MainWidget() override; + virtual ~MainWidget() override = default; void add_track_actions(GUI::Menu&); diff --git a/Userland/Applications/Piano/PlayerWidget.cpp b/Userland/Applications/Piano/PlayerWidget.cpp index 2ef688431f..3737a601a6 100644 --- a/Userland/Applications/Piano/PlayerWidget.cpp +++ b/Userland/Applications/Piano/PlayerWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -95,10 +96,6 @@ PlayerWidget::PlayerWidget(TrackManager& manager, AudioPlayerLoop& loop) }; } -PlayerWidget::~PlayerWidget() -{ -} - void PlayerWidget::add_track() { m_track_manager.add_track(); diff --git a/Userland/Applications/Piano/PlayerWidget.h b/Userland/Applications/Piano/PlayerWidget.h index 2164d0b2c7..af5e2f664e 100644 --- a/Userland/Applications/Piano/PlayerWidget.h +++ b/Userland/Applications/Piano/PlayerWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class TrackManager; class PlayerWidget final : public GUI::Toolbar { C_OBJECT(PlayerWidget) public: - virtual ~PlayerWidget() override; + virtual ~PlayerWidget() override = default; void add_track(); void next_track(); diff --git a/Userland/Applications/Piano/RollWidget.cpp b/Userland/Applications/Piano/RollWidget.cpp index 8379b4d662..d2457051cb 100644 --- a/Userland/Applications/Piano/RollWidget.cpp +++ b/Userland/Applications/Piano/RollWidget.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,10 +29,6 @@ RollWidget::RollWidget(TrackManager& track_manager) vertical_scrollbar().set_value(roll_height / 2); } -RollWidget::~RollWidget() -{ -} - void RollWidget::paint_event(GUI::PaintEvent& event) { m_roll_width = widget_inner_rect().width() * m_zoom_level; diff --git a/Userland/Applications/Piano/RollWidget.h b/Userland/Applications/Piano/RollWidget.h index 1e97d3a303..3e4ca04e9f 100644 --- a/Userland/Applications/Piano/RollWidget.h +++ b/Userland/Applications/Piano/RollWidget.h @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -19,7 +20,7 @@ using LibDSP::RollNote; class RollWidget final : public GUI::AbstractScrollableWidget { C_OBJECT(RollWidget) public: - virtual ~RollWidget() override; + virtual ~RollWidget() override = default; const KeysWidget* keys_widget() const { return m_keys_widget; } void set_keys_widget(const KeysWidget* widget) { m_keys_widget = widget; } diff --git a/Userland/Applications/Piano/SamplerWidget.cpp b/Userland/Applications/Piano/SamplerWidget.cpp index afa910c3f9..220ed553f5 100644 --- a/Userland/Applications/Piano/SamplerWidget.cpp +++ b/Userland/Applications/Piano/SamplerWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,10 +19,6 @@ WaveEditor::WaveEditor(TrackManager& track_manager) { } -WaveEditor::~WaveEditor() -{ -} - int WaveEditor::sample_to_y(double percentage) const { double portion_of_half_height = percentage * ((frame_inner_rect().height() - 1) / 2.0); @@ -100,7 +97,3 @@ SamplerWidget::SamplerWidget(TrackManager& track_manager) m_wave_editor = add<WaveEditor>(m_track_manager); m_wave_editor->set_fixed_height(100); } - -SamplerWidget::~SamplerWidget() -{ -} diff --git a/Userland/Applications/Piano/SamplerWidget.h b/Userland/Applications/Piano/SamplerWidget.h index 8380b33d3a..27ba0f58d0 100644 --- a/Userland/Applications/Piano/SamplerWidget.h +++ b/Userland/Applications/Piano/SamplerWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,7 +14,7 @@ class TrackManager; class WaveEditor final : public GUI::Frame { C_OBJECT(WaveEditor) public: - virtual ~WaveEditor() override; + virtual ~WaveEditor() override = default; private: explicit WaveEditor(TrackManager&); @@ -28,7 +29,7 @@ private: class SamplerWidget final : public GUI::Frame { C_OBJECT(SamplerWidget) public: - virtual ~SamplerWidget() override; + virtual ~SamplerWidget() override = default; private: explicit SamplerWidget(TrackManager&); diff --git a/Userland/Applications/Piano/Track.cpp b/Userland/Applications/Piano/Track.cpp index eceec68c43..7344a5c0d7 100644 --- a/Userland/Applications/Piano/Track.cpp +++ b/Userland/Applications/Piano/Track.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -24,10 +25,6 @@ Track::Track(const u32& time) set_volume(volume_max); } -Track::~Track() -{ -} - void Track::fill_sample(Sample& sample) { m_temporary_transport->time() = m_time; diff --git a/Userland/Applications/Piano/Track.h b/Userland/Applications/Piano/Track.h index 9be0e65502..230b052231 100644 --- a/Userland/Applications/Piano/Track.h +++ b/Userland/Applications/Piano/Track.h @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,7 +27,7 @@ class Track { public: explicit Track(const u32& time); - ~Track(); + ~Track() = default; const Vector<Audio::Sample>& recorded_sample() const { return m_recorded_sample; } const SinglyLinkedList<RollNote>& roll_notes(int note) const { return m_roll_notes[note]; } diff --git a/Userland/Applications/Piano/TrackManager.cpp b/Userland/Applications/Piano/TrackManager.cpp index 705af0f56b..37accde048 100644 --- a/Userland/Applications/Piano/TrackManager.cpp +++ b/Userland/Applications/Piano/TrackManager.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,10 +15,6 @@ TrackManager::TrackManager() add_track(); } -TrackManager::~TrackManager() -{ -} - void TrackManager::time_forward(int amount) { int new_value = (static_cast<int>(m_time) + amount) % roll_length; diff --git a/Userland/Applications/Piano/TrackManager.h b/Userland/Applications/Piano/TrackManager.h index 4b315ea118..3bbc09862b 100644 --- a/Userland/Applications/Piano/TrackManager.h +++ b/Userland/Applications/Piano/TrackManager.h @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class TrackManager { public: TrackManager(); - ~TrackManager(); + ~TrackManager() = default; Track& current_track() { return *m_tracks[m_current_track]; } Span<const Sample> buffer() const { return m_current_front_buffer; } diff --git a/Userland/Applications/Piano/WaveWidget.cpp b/Userland/Applications/Piano/WaveWidget.cpp index c91fefcfd9..e0c71163bc 100644 --- a/Userland/Applications/Piano/WaveWidget.cpp +++ b/Userland/Applications/Piano/WaveWidget.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,10 +16,6 @@ WaveWidget::WaveWidget(TrackManager& track_manager) { } -WaveWidget::~WaveWidget() -{ -} - int WaveWidget::sample_to_y(int sample) const { constexpr int nice_scale_factor = 4; diff --git a/Userland/Applications/Piano/WaveWidget.h b/Userland/Applications/Piano/WaveWidget.h index bc8a8f16cd..37f3433f63 100644 --- a/Userland/Applications/Piano/WaveWidget.h +++ b/Userland/Applications/Piano/WaveWidget.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ class TrackManager; class WaveWidget final : public GUI::Frame { C_OBJECT(WaveWidget) public: - virtual ~WaveWidget() override; + virtual ~WaveWidget() override = default; private: explicit WaveWidget(TrackManager&); diff --git a/Userland/Applications/PixelPaint/Layer.h b/Userland/Applications/PixelPaint/Layer.h index 966dad2b17..64860d867b 100644 --- a/Userland/Applications/PixelPaint/Layer.h +++ b/Userland/Applications/PixelPaint/Layer.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -29,7 +30,7 @@ public: static ErrorOr<NonnullRefPtr<Layer>> try_create_with_bitmap(Image&, NonnullRefPtr<Gfx::Bitmap>, String name); static ErrorOr<NonnullRefPtr<Layer>> try_create_snapshot(Image&, Layer const&); - ~Layer() { } + ~Layer() = default; Gfx::IntPoint const& location() const { return m_location; } void set_location(Gfx::IntPoint const& location) { m_location = location; } diff --git a/Userland/Applications/PixelPaint/LayerPropertiesWidget.cpp b/Userland/Applications/PixelPaint/LayerPropertiesWidget.cpp index f10cbfcdaf..298e8283e1 100644 --- a/Userland/Applications/PixelPaint/LayerPropertiesWidget.cpp +++ b/Userland/Applications/PixelPaint/LayerPropertiesWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -65,10 +66,6 @@ LayerPropertiesWidget::LayerPropertiesWidget() }; } -LayerPropertiesWidget::~LayerPropertiesWidget() -{ -} - void LayerPropertiesWidget::set_layer(Layer* layer) { if (m_layer == layer) diff --git a/Userland/Applications/PixelPaint/LayerPropertiesWidget.h b/Userland/Applications/PixelPaint/LayerPropertiesWidget.h index 33d212d335..714da7ed49 100644 --- a/Userland/Applications/PixelPaint/LayerPropertiesWidget.h +++ b/Userland/Applications/PixelPaint/LayerPropertiesWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ class LayerPropertiesWidget final : public GUI::Widget { C_OBJECT(LayerPropertiesWidget); public: - virtual ~LayerPropertiesWidget() override; + virtual ~LayerPropertiesWidget() override = default; void set_layer(Layer*); diff --git a/Userland/Applications/PixelPaint/PaletteWidget.cpp b/Userland/Applications/PixelPaint/PaletteWidget.cpp index d85cd2ce9d..7595c30caf 100644 --- a/Userland/Applications/PixelPaint/PaletteWidget.cpp +++ b/Userland/Applications/PixelPaint/PaletteWidget.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Felix Rauch <noreply@felixrau.ch> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -25,9 +26,7 @@ class ColorWidget : public GUI::Frame { C_OBJECT(ColorWidget); public: - virtual ~ColorWidget() override - { - } + virtual ~ColorWidget() override = default; virtual Color color() { return m_color; } @@ -66,7 +65,7 @@ class SelectedColorWidget : public GUI::Frame { C_OBJECT(SelectedColorWidget); public: - virtual ~SelectedColorWidget() override { } + virtual ~SelectedColorWidget() override = default; virtual void mousedown_event(GUI::MouseEvent& event) override { @@ -162,10 +161,6 @@ void PaletteWidget::set_image_editor(ImageEditor* editor) }; } -PaletteWidget::~PaletteWidget() -{ -} - void PaletteWidget::set_primary_color(Color color) { if (m_editor) diff --git a/Userland/Applications/PixelPaint/PaletteWidget.h b/Userland/Applications/PixelPaint/PaletteWidget.h index 6801b6e649..02540db80d 100644 --- a/Userland/Applications/PixelPaint/PaletteWidget.h +++ b/Userland/Applications/PixelPaint/PaletteWidget.h @@ -2,6 +2,7 @@ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Felix Rauch <noreply@felixrau.ch> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class PaletteWidget final : public GUI::Frame { C_OBJECT(PaletteWidget); public: - virtual ~PaletteWidget() override; + virtual ~PaletteWidget() override = default; void set_primary_color(Color); void set_secondary_color(Color); diff --git a/Userland/Applications/PixelPaint/ToolPropertiesWidget.cpp b/Userland/Applications/PixelPaint/ToolPropertiesWidget.cpp index eba4852b0b..1353bf91b0 100644 --- a/Userland/Applications/PixelPaint/ToolPropertiesWidget.cpp +++ b/Userland/Applications/PixelPaint/ToolPropertiesWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Ben Jilks <benjyjilks@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -42,9 +43,4 @@ void ToolPropertiesWidget::set_active_tool(Tool* tool) m_tool_widget_stack->set_active_widget(m_active_tool_widget); } - -ToolPropertiesWidget::~ToolPropertiesWidget() -{ -} - } diff --git a/Userland/Applications/PixelPaint/ToolPropertiesWidget.h b/Userland/Applications/PixelPaint/ToolPropertiesWidget.h index 925d08c5ef..8a3506eb31 100644 --- a/Userland/Applications/PixelPaint/ToolPropertiesWidget.h +++ b/Userland/Applications/PixelPaint/ToolPropertiesWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Ben Jilks <benjyjilks@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -19,7 +20,7 @@ class ToolPropertiesWidget final : public GUI::Widget { C_OBJECT(ToolPropertiesWidget); public: - virtual ~ToolPropertiesWidget() override; + virtual ~ToolPropertiesWidget() override = default; void set_active_tool(Tool*); diff --git a/Userland/Applications/PixelPaint/ToolboxWidget.cpp b/Userland/Applications/PixelPaint/ToolboxWidget.cpp index 48afba3f66..7cb2e6e0d5 100644 --- a/Userland/Applications/PixelPaint/ToolboxWidget.cpp +++ b/Userland/Applications/PixelPaint/ToolboxWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -45,10 +46,6 @@ ToolboxWidget::ToolboxWidget() setup_tools(); } -ToolboxWidget::~ToolboxWidget() -{ -} - void ToolboxWidget::setup_tools() { auto add_tool = [&](String name, StringView icon_name, GUI::Shortcut const& shortcut, NonnullOwnPtr<Tool> tool) { diff --git a/Userland/Applications/PixelPaint/ToolboxWidget.h b/Userland/Applications/PixelPaint/ToolboxWidget.h index 6de446ce56..789885802b 100644 --- a/Userland/Applications/PixelPaint/ToolboxWidget.h +++ b/Userland/Applications/PixelPaint/ToolboxWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +19,7 @@ class ToolboxWidget final : public GUI::Widget { C_OBJECT(ToolboxWidget); public: - virtual ~ToolboxWidget() override; + virtual ~ToolboxWidget() override = default; Function<void(Tool*)> on_tool_selection; diff --git a/Userland/Applications/PixelPaint/Tools/BrushTool.cpp b/Userland/Applications/PixelPaint/Tools/BrushTool.cpp index 62e2075d23..3e5786555f 100644 --- a/Userland/Applications/PixelPaint/Tools/BrushTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/BrushTool.cpp @@ -18,14 +18,6 @@ namespace PixelPaint { -BrushTool::BrushTool() -{ -} - -BrushTool::~BrushTool() -{ -} - void BrushTool::on_mousedown(Layer* layer, MouseEvent& event) { if (!layer) diff --git a/Userland/Applications/PixelPaint/Tools/BrushTool.h b/Userland/Applications/PixelPaint/Tools/BrushTool.h index 36daa91935..d76c40e295 100644 --- a/Userland/Applications/PixelPaint/Tools/BrushTool.h +++ b/Userland/Applications/PixelPaint/Tools/BrushTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2020, Ben Jilks <benjyjilks@gmail.com> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,8 +14,8 @@ namespace PixelPaint { class BrushTool : public Tool { public: - BrushTool(); - virtual ~BrushTool() override; + BrushTool() = default; + virtual ~BrushTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/BucketTool.cpp b/Userland/Applications/PixelPaint/Tools/BucketTool.cpp index 8b417cfa35..380b387728 100644 --- a/Userland/Applications/PixelPaint/Tools/BucketTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/BucketTool.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,10 +24,6 @@ BucketTool::BucketTool() m_cursor = Gfx::Bitmap::try_load_from_file("/res/icons/pixelpaint/bucket.png").release_value_but_fixme_should_propagate_errors(); } -BucketTool::~BucketTool() -{ -} - static float color_distance_squared(Gfx::Color const& lhs, Gfx::Color const& rhs) { int a = rhs.red() - lhs.red(); diff --git a/Userland/Applications/PixelPaint/Tools/BucketTool.h b/Userland/Applications/PixelPaint/Tools/BucketTool.h index a603914ab9..fc5e01f5d1 100644 --- a/Userland/Applications/PixelPaint/Tools/BucketTool.h +++ b/Userland/Applications/PixelPaint/Tools/BucketTool.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,7 +14,7 @@ namespace PixelPaint { class BucketTool final : public Tool { public: BucketTool(); - virtual ~BucketTool() override; + virtual ~BucketTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual GUI::Widget* get_properties_widget() override; diff --git a/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp b/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp index 2eca8ec643..998ee2cb49 100644 --- a/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,14 +21,6 @@ namespace PixelPaint { -EllipseTool::EllipseTool() -{ -} - -EllipseTool::~EllipseTool() -{ -} - void EllipseTool::draw_using(GUI::Painter& painter, Gfx::IntPoint const& start_position, Gfx::IntPoint const& end_position, int thickness) { Gfx::IntRect ellipse_intersecting_rect; diff --git a/Userland/Applications/PixelPaint/Tools/EllipseTool.h b/Userland/Applications/PixelPaint/Tools/EllipseTool.h index 7cc8722a66..03085d8277 100644 --- a/Userland/Applications/PixelPaint/Tools/EllipseTool.h +++ b/Userland/Applications/PixelPaint/Tools/EllipseTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -9,14 +10,15 @@ #include "Tool.h" #include <LibGUI/Forward.h> +#include <LibGUI/TextBox.h> #include <LibGfx/Point.h> namespace PixelPaint { class EllipseTool final : public Tool { public: - EllipseTool(); - virtual ~EllipseTool() override; + EllipseTool() = default; + virtual ~EllipseTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/EraseTool.cpp b/Userland/Applications/PixelPaint/Tools/EraseTool.cpp index b60a831c9c..01fb66b855 100644 --- a/Userland/Applications/PixelPaint/Tools/EraseTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/EraseTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,14 +21,6 @@ namespace PixelPaint { -EraseTool::EraseTool() -{ -} - -EraseTool::~EraseTool() -{ -} - Color EraseTool::color_for(GUI::MouseEvent const&) { if (m_use_secondary_color) diff --git a/Userland/Applications/PixelPaint/Tools/EraseTool.h b/Userland/Applications/PixelPaint/Tools/EraseTool.h index 6fbf048326..e53e0d22ee 100644 --- a/Userland/Applications/PixelPaint/Tools/EraseTool.h +++ b/Userland/Applications/PixelPaint/Tools/EraseTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,8 +17,8 @@ namespace PixelPaint { class EraseTool final : public BrushTool { public: - EraseTool(); - virtual ~EraseTool() override; + EraseTool() = default; + virtual ~EraseTool() override = default; virtual GUI::Widget* get_properties_widget() override; diff --git a/Userland/Applications/PixelPaint/Tools/GuideTool.cpp b/Userland/Applications/PixelPaint/Tools/GuideTool.cpp index 9a7e422955..1203fe7285 100644 --- a/Userland/Applications/PixelPaint/Tools/GuideTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/GuideTool.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,14 +16,6 @@ namespace PixelPaint { -GuideTool::GuideTool() -{ -} - -GuideTool::~GuideTool() -{ -} - RefPtr<Guide> GuideTool::closest_guide(const Gfx::IntPoint& point) { auto guides = editor()->guides(); diff --git a/Userland/Applications/PixelPaint/Tools/GuideTool.h b/Userland/Applications/PixelPaint/Tools/GuideTool.h index fab699aedf..67aeabc09c 100644 --- a/Userland/Applications/PixelPaint/Tools/GuideTool.h +++ b/Userland/Applications/PixelPaint/Tools/GuideTool.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -9,14 +10,15 @@ #include "../Guide.h" #include "Tool.h" #include <AK/RefPtr.h> +#include <LibGUI/Menu.h> namespace PixelPaint { class GuideTool final : public Tool { public: - GuideTool(); + GuideTool() = default; - virtual ~GuideTool() override; + virtual ~GuideTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/LineTool.cpp b/Userland/Applications/PixelPaint/Tools/LineTool.cpp index 9b3db8ecc5..425f74ca64 100644 --- a/Userland/Applications/PixelPaint/Tools/LineTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/LineTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -31,14 +32,6 @@ static Gfx::IntPoint constrain_line_angle(Gfx::IntPoint const& start_pos, Gfx::I start_pos.y() + (int)(AK::sin(constrained_angle) * line_length) }; } -LineTool::LineTool() -{ -} - -LineTool::~LineTool() -{ -} - void LineTool::on_mousedown(Layer* layer, MouseEvent& event) { if (!layer) diff --git a/Userland/Applications/PixelPaint/Tools/LineTool.h b/Userland/Applications/PixelPaint/Tools/LineTool.h index 874c3b5ddd..2b91236911 100644 --- a/Userland/Applications/PixelPaint/Tools/LineTool.h +++ b/Userland/Applications/PixelPaint/Tools/LineTool.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,8 +15,8 @@ namespace PixelPaint { class LineTool final : public Tool { public: - LineTool(); - virtual ~LineTool() override; + LineTool() = default; + virtual ~LineTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/MoveTool.cpp b/Userland/Applications/PixelPaint/Tools/MoveTool.cpp index 9690715c6a..694e04b129 100644 --- a/Userland/Applications/PixelPaint/Tools/MoveTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/MoveTool.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,14 +15,6 @@ namespace PixelPaint { -MoveTool::MoveTool() -{ -} - -MoveTool::~MoveTool() -{ -} - void MoveTool::on_mousedown(Layer* layer, MouseEvent& event) { if (event.image_event().button() == GUI::MouseButton::Secondary) { diff --git a/Userland/Applications/PixelPaint/Tools/MoveTool.h b/Userland/Applications/PixelPaint/Tools/MoveTool.h index d62d554258..e022256cce 100644 --- a/Userland/Applications/PixelPaint/Tools/MoveTool.h +++ b/Userland/Applications/PixelPaint/Tools/MoveTool.h @@ -1,19 +1,21 @@ /* * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ #pragma once +#include "../Layer.h" #include "Tool.h" namespace PixelPaint { class MoveTool final : public Tool { public: - MoveTool(); - virtual ~MoveTool() override; + MoveTool() = default; + virtual ~MoveTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/PenTool.cpp b/Userland/Applications/PixelPaint/Tools/PenTool.cpp index 587755ae8a..fa7170ba92 100644 --- a/Userland/Applications/PixelPaint/Tools/PenTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/PenTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -22,10 +23,6 @@ PenTool::PenTool() set_size(1); } -PenTool::~PenTool() -{ -} - void PenTool::draw_point(Gfx::Bitmap& bitmap, Gfx::Color const& color, Gfx::IntPoint const& point) { GUI::Painter painter(bitmap); diff --git a/Userland/Applications/PixelPaint/Tools/PenTool.h b/Userland/Applications/PixelPaint/Tools/PenTool.h index 5ac5f23c0a..502724ce03 100644 --- a/Userland/Applications/PixelPaint/Tools/PenTool.h +++ b/Userland/Applications/PixelPaint/Tools/PenTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ namespace PixelPaint { class PenTool final : public BrushTool { public: PenTool(); - virtual ~PenTool() override; + virtual ~PenTool() override = default; virtual GUI::Widget* get_properties_widget() override; diff --git a/Userland/Applications/PixelPaint/Tools/PickerTool.cpp b/Userland/Applications/PixelPaint/Tools/PickerTool.cpp index 1c209687d2..54fa83c2dd 100644 --- a/Userland/Applications/PixelPaint/Tools/PickerTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/PickerTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,14 +14,6 @@ namespace PixelPaint { -PickerTool::PickerTool() -{ -} - -PickerTool::~PickerTool() -{ -} - void PickerTool::on_mousedown(Layer* layer, MouseEvent& event) { auto& position = event.layer_event().position(); diff --git a/Userland/Applications/PixelPaint/Tools/PickerTool.h b/Userland/Applications/PixelPaint/Tools/PickerTool.h index 564632e7dd..1fab7e04e1 100644 --- a/Userland/Applications/PixelPaint/Tools/PickerTool.h +++ b/Userland/Applications/PixelPaint/Tools/PickerTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,8 +14,8 @@ namespace PixelPaint { class PickerTool final : public Tool { public: - PickerTool(); - virtual ~PickerTool() override; + PickerTool() = default; + virtual ~PickerTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp index 559be8ae9a..9f7de2d0d8 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,14 +19,6 @@ namespace PixelPaint { -RectangleSelectTool::RectangleSelectTool() -{ -} - -RectangleSelectTool::~RectangleSelectTool() -{ -} - void RectangleSelectTool::on_mousedown(Layer*, MouseEvent& event) { auto& image_event = event.image_event(); diff --git a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.h b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.h index 9216db6705..7d151a9fc2 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.h +++ b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,8 +17,8 @@ namespace PixelPaint { class RectangleSelectTool final : public Tool { public: - RectangleSelectTool(); - virtual ~RectangleSelectTool(); + RectangleSelectTool() = default; + virtual ~RectangleSelectTool() = default; virtual void on_mousedown(Layer*, MouseEvent& event) override; virtual void on_mousemove(Layer*, MouseEvent& event) override; diff --git a/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp b/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp index fccddc0ce7..b24d024a17 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,14 +21,6 @@ namespace PixelPaint { -RectangleTool::RectangleTool() -{ -} - -RectangleTool::~RectangleTool() -{ -} - void RectangleTool::draw_using(GUI::Painter& painter, Gfx::IntPoint const& start_position, Gfx::IntPoint const& end_position, int thickness) { Gfx::IntRect rect; diff --git a/Userland/Applications/PixelPaint/Tools/RectangleTool.h b/Userland/Applications/PixelPaint/Tools/RectangleTool.h index 410893da0c..781b113364 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleTool.h +++ b/Userland/Applications/PixelPaint/Tools/RectangleTool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,8 +16,8 @@ namespace PixelPaint { class RectangleTool final : public Tool { public: - RectangleTool(); - virtual ~RectangleTool() override; + RectangleTool() = default; + virtual ~RectangleTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mousemove(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/SprayTool.cpp b/Userland/Applications/PixelPaint/Tools/SprayTool.cpp index 711ce0d3db..0d099f0d36 100644 --- a/Userland/Applications/PixelPaint/Tools/SprayTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/SprayTool.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,10 +29,6 @@ SprayTool::SprayTool() m_timer->set_interval(200); } -SprayTool::~SprayTool() -{ -} - static double nrand() { return double(rand()) / double(RAND_MAX); diff --git a/Userland/Applications/PixelPaint/Tools/SprayTool.h b/Userland/Applications/PixelPaint/Tools/SprayTool.h index 1b492433f9..015e5703ee 100644 --- a/Userland/Applications/PixelPaint/Tools/SprayTool.h +++ b/Userland/Applications/PixelPaint/Tools/SprayTool.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ namespace PixelPaint { class SprayTool final : public Tool { public: SprayTool(); - virtual ~SprayTool() override; + virtual ~SprayTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual void on_mouseup(Layer*, MouseEvent&) override; diff --git a/Userland/Applications/PixelPaint/Tools/Tool.cpp b/Userland/Applications/PixelPaint/Tools/Tool.cpp index e1dde2fa05..4c647b1d5b 100644 --- a/Userland/Applications/PixelPaint/Tools/Tool.cpp +++ b/Userland/Applications/PixelPaint/Tools/Tool.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,14 +12,6 @@ namespace PixelPaint { -Tool::Tool() -{ -} - -Tool::~Tool() -{ -} - void Tool::setup(ImageEditor& editor) { m_editor = editor; diff --git a/Userland/Applications/PixelPaint/Tools/Tool.h b/Userland/Applications/PixelPaint/Tools/Tool.h index f72f06d2fc..14a9ed935c 100644 --- a/Userland/Applications/PixelPaint/Tools/Tool.h +++ b/Userland/Applications/PixelPaint/Tools/Tool.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -8,6 +9,7 @@ #pragma once #include <AK/Variant.h> +#include <LibGUI/Action.h> #include <LibGUI/Event.h> #include <LibGUI/Forward.h> #include <LibGUI/ValueSlider.h> @@ -20,7 +22,7 @@ class Layer; class Tool { public: - virtual ~Tool(); + virtual ~Tool() = default; class MouseEvent { public: @@ -73,7 +75,7 @@ public: void set_action(GUI::Action*); protected: - Tool(); + Tool() = default; WeakPtr<ImageEditor> m_editor; RefPtr<GUI::Action> m_action; diff --git a/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp b/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp index b1ca6dc28f..88b52725a5 100644 --- a/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,14 +12,6 @@ namespace PixelPaint { -ZoomTool::ZoomTool() -{ -} - -ZoomTool::~ZoomTool() -{ -} - void ZoomTool::on_mousedown(Layer*, MouseEvent& event) { auto& raw_event = event.raw_event(); diff --git a/Userland/Applications/PixelPaint/Tools/ZoomTool.h b/Userland/Applications/PixelPaint/Tools/ZoomTool.h index be1a3558fb..b52440c812 100644 --- a/Userland/Applications/PixelPaint/Tools/ZoomTool.h +++ b/Userland/Applications/PixelPaint/Tools/ZoomTool.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,8 +14,8 @@ namespace PixelPaint { class ZoomTool final : public Tool { public: - ZoomTool(); - virtual ~ZoomTool() override; + ZoomTool() = default; + virtual ~ZoomTool() override = default; virtual void on_mousedown(Layer*, MouseEvent&) override; virtual GUI::Widget* get_properties_widget() override; diff --git a/Userland/Applications/Run/RunWindow.cpp b/Userland/Applications/Run/RunWindow.cpp index 96eb30ce35..6e680936c4 100644 --- a/Userland/Applications/Run/RunWindow.cpp +++ b/Userland/Applications/Run/RunWindow.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Nick Vella <nick@nxk.io> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -69,10 +70,6 @@ RunWindow::RunWindow() }; } -RunWindow::~RunWindow() -{ -} - void RunWindow::event(Core::Event& event) { if (event.type() == GUI::Event::KeyUp || event.type() == GUI::Event::KeyDown) { diff --git a/Userland/Applications/Run/RunWindow.h b/Userland/Applications/Run/RunWindow.h index 04c8993597..c05bccf2ef 100644 --- a/Userland/Applications/Run/RunWindow.h +++ b/Userland/Applications/Run/RunWindow.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Nick Vella <nick@nxk.io> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class RunWindow final : public GUI::Window { C_OBJECT(RunWindow) public: - virtual ~RunWindow() override; + virtual ~RunWindow() override = default; virtual void event(Core::Event&) override; diff --git a/Userland/Applications/SoundPlayer/BarsVisualizationWidget.cpp b/Userland/Applications/SoundPlayer/BarsVisualizationWidget.cpp index 34918fe077..0f7be3a450 100644 --- a/Userland/Applications/SoundPlayer/BarsVisualizationWidget.cpp +++ b/Userland/Applications/SoundPlayer/BarsVisualizationWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -65,10 +66,6 @@ void BarsVisualizationWidget::paint_event(GUI::PaintEvent& event) m_is_using_last = false; } -BarsVisualizationWidget::~BarsVisualizationWidget() -{ -} - BarsVisualizationWidget::BarsVisualizationWidget() : m_last_id(-1) , m_is_using_last(false) diff --git a/Userland/Applications/SoundPlayer/BarsVisualizationWidget.h b/Userland/Applications/SoundPlayer/BarsVisualizationWidget.h index 262229537e..c0b7aa6062 100644 --- a/Userland/Applications/SoundPlayer/BarsVisualizationWidget.h +++ b/Userland/Applications/SoundPlayer/BarsVisualizationWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class BarsVisualizationWidget final : public VisualizationWidget { C_OBJECT(BarsVisualizationWidget) public: - ~BarsVisualizationWidget() override; + ~BarsVisualizationWidget() override = default; void set_buffer(RefPtr<Audio::Buffer> buffer) override; void set_samplerate(int samplerate) override; diff --git a/Userland/Applications/SoundPlayer/NoVisualizationWidget.cpp b/Userland/Applications/SoundPlayer/NoVisualizationWidget.cpp index e7a5510ccd..a83338d2b0 100644 --- a/Userland/Applications/SoundPlayer/NoVisualizationWidget.cpp +++ b/Userland/Applications/SoundPlayer/NoVisualizationWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -7,14 +8,6 @@ #include "NoVisualizationWidget.h" #include <LibGUI/Painter.h> -NoVisualizationWidget::NoVisualizationWidget() -{ -} - -NoVisualizationWidget::~NoVisualizationWidget() -{ -} - void NoVisualizationWidget::paint_event(GUI::PaintEvent& event) { Frame::paint_event(event); diff --git a/Userland/Applications/SoundPlayer/NoVisualizationWidget.h b/Userland/Applications/SoundPlayer/NoVisualizationWidget.h index ae1153cede..68ee01224f 100644 --- a/Userland/Applications/SoundPlayer/NoVisualizationWidget.h +++ b/Userland/Applications/SoundPlayer/NoVisualizationWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,12 +15,12 @@ class NoVisualizationWidget final : public VisualizationWidget { C_OBJECT(NoVisualizationWidget) public: - ~NoVisualizationWidget() override; + ~NoVisualizationWidget() override = default; void set_buffer(RefPtr<Audio::Buffer>) override; private: void paint_event(GUI::PaintEvent&) override; - NoVisualizationWidget(); + NoVisualizationWidget() = default; RefPtr<Gfx::Bitmap> m_serenity_bg; }; diff --git a/Userland/Applications/SoundPlayer/PlaybackManager.cpp b/Userland/Applications/SoundPlayer/PlaybackManager.cpp index b761509c1c..4d727102de 100644 --- a/Userland/Applications/SoundPlayer/PlaybackManager.cpp +++ b/Userland/Applications/SoundPlayer/PlaybackManager.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,10 +27,6 @@ PlaybackManager::PlaybackManager(NonnullRefPtr<Audio::ClientConnection> connecti m_device_sample_rate = connection->get_sample_rate(); } -PlaybackManager::~PlaybackManager() -{ -} - void PlaybackManager::set_loader(NonnullRefPtr<Audio::Loader>&& loader) { stop(); diff --git a/Userland/Applications/SoundPlayer/PlaybackManager.h b/Userland/Applications/SoundPlayer/PlaybackManager.h index 1a90408c1a..5683ac7cc6 100644 --- a/Userland/Applications/SoundPlayer/PlaybackManager.h +++ b/Userland/Applications/SoundPlayer/PlaybackManager.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ class PlaybackManager final { public: PlaybackManager(NonnullRefPtr<Audio::ClientConnection>); - ~PlaybackManager(); + ~PlaybackManager() = default; void play(); void stop(); diff --git a/Userland/Applications/SoundPlayer/Player.h b/Userland/Applications/SoundPlayer/Player.h index 8635a35452..277e65af2b 100644 --- a/Userland/Applications/SoundPlayer/Player.h +++ b/Userland/Applications/SoundPlayer/Player.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Cesar Torres <shortanemoia@protonmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -30,7 +31,7 @@ public: }; explicit Player(Audio::ClientConnection& audio_client_connection); - virtual ~Player() { } + virtual ~Player() = default; void play_file_path(String const& path); bool is_playlist(String const& path); diff --git a/Userland/Applications/SoundPlayer/SampleWidget.cpp b/Userland/Applications/SoundPlayer/SampleWidget.cpp index ea97ff714e..47d2dfe46c 100644 --- a/Userland/Applications/SoundPlayer/SampleWidget.cpp +++ b/Userland/Applications/SoundPlayer/SampleWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -9,14 +10,6 @@ #include <LibAudio/Buffer.h> #include <LibGUI/Painter.h> -SampleWidget::SampleWidget() -{ -} - -SampleWidget::~SampleWidget() -{ -} - void SampleWidget::paint_event(GUI::PaintEvent& event) { GUI::Frame::paint_event(event); diff --git a/Userland/Applications/SoundPlayer/SampleWidget.h b/Userland/Applications/SoundPlayer/SampleWidget.h index 63f3b8dc66..e3da71d291 100644 --- a/Userland/Applications/SoundPlayer/SampleWidget.h +++ b/Userland/Applications/SoundPlayer/SampleWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,12 +17,12 @@ class Buffer; class SampleWidget final : public VisualizationWidget { C_OBJECT(SampleWidget) public: - virtual ~SampleWidget() override; + virtual ~SampleWidget() override = default; void set_buffer(RefPtr<Audio::Buffer>) override; private: - SampleWidget(); + SampleWidget() = default; virtual void paint_event(GUI::PaintEvent&) override; RefPtr<Audio::Buffer> m_buffer; diff --git a/Userland/Applications/SpaceAnalyzer/TreeMapWidget.cpp b/Userland/Applications/SpaceAnalyzer/TreeMapWidget.cpp index 149baddc19..c8d7b10ec1 100644 --- a/Userland/Applications/SpaceAnalyzer/TreeMapWidget.cpp +++ b/Userland/Applications/SpaceAnalyzer/TreeMapWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,15 +15,6 @@ REGISTER_WIDGET(SpaceAnalyzer, TreeMapWidget) namespace SpaceAnalyzer { -TreeMapWidget::TreeMapWidget() - : m_viewpoint(0) -{ -} - -TreeMapWidget::~TreeMapWidget() -{ -} - static const Color colors[] = { Color(253, 231, 37), Color(148, 216, 64), diff --git a/Userland/Applications/SpaceAnalyzer/TreeMapWidget.h b/Userland/Applications/SpaceAnalyzer/TreeMapWidget.h index 0fb5dc2268..1e3ee8fc2c 100644 --- a/Userland/Applications/SpaceAnalyzer/TreeMapWidget.h +++ b/Userland/Applications/SpaceAnalyzer/TreeMapWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,7 +23,7 @@ protected: }; struct TreeMap : public RefCounted<TreeMap> { - virtual ~TreeMap() { } + virtual ~TreeMap() = default; virtual const TreeMapNode& root() const = 0; }; @@ -31,7 +31,7 @@ class TreeMapWidget final : public GUI::Frame { C_OBJECT(TreeMapWidget) public: - virtual ~TreeMapWidget() override; + virtual ~TreeMapWidget() override = default; Function<void()> on_path_change; Function<void(GUI::ContextMenuEvent&)> on_context_menu_request; size_t path_size() const; @@ -41,7 +41,7 @@ public: void set_tree(RefPtr<TreeMap> tree); private: - TreeMapWidget(); + TreeMapWidget() = default; virtual void paint_event(GUI::PaintEvent&) override; virtual void mousedown_event(GUI::MouseEvent&) override; virtual void doubleclick_event(GUI::MouseEvent&) override; @@ -67,7 +67,7 @@ private: RefPtr<TreeMap> m_tree; Vector<int> m_path; - size_t m_viewpoint; + size_t m_viewpoint { 0 }; const void* m_selected_node_cache; }; diff --git a/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.cpp b/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.cpp index c6bdde6bea..e9c43180f8 100644 --- a/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.cpp +++ b/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -55,9 +55,4 @@ void CellSyntaxHighlighter::rehighlight(const Palette& palette) } m_client->do_update(); } - -CellSyntaxHighlighter::~CellSyntaxHighlighter() -{ -} - } diff --git a/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.h b/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.h index e3e0901e56..0a19d3f715 100644 --- a/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.h +++ b/Userland/Applications/Spreadsheet/CellSyntaxHighlighter.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,8 +13,8 @@ namespace Spreadsheet { class CellSyntaxHighlighter final : public JS::SyntaxHighlighter { public: - CellSyntaxHighlighter() { } - virtual ~CellSyntaxHighlighter() override; + CellSyntaxHighlighter() = default; + virtual ~CellSyntaxHighlighter() override = default; virtual void rehighlight(const Palette&) override; void set_cell(const Cell* cell) { m_cell = cell; } diff --git a/Userland/Applications/Spreadsheet/CellType/Date.cpp b/Userland/Applications/Spreadsheet/CellType/Date.cpp index 65ce76d6a9..2db71c875f 100644 --- a/Userland/Applications/Spreadsheet/CellType/Date.cpp +++ b/Userland/Applications/Spreadsheet/CellType/Date.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,10 +17,6 @@ DateCell::DateCell() { } -DateCell::~DateCell() -{ -} - JS::ThrowCompletionOr<String> DateCell::display(Cell& cell, const CellTypeMetadata& metadata) const { return propagate_failure(cell, [&]() -> JS::ThrowCompletionOr<String> { diff --git a/Userland/Applications/Spreadsheet/CellType/Date.h b/Userland/Applications/Spreadsheet/CellType/Date.h index 41f6b3ec46..ddf90fc63e 100644 --- a/Userland/Applications/Spreadsheet/CellType/Date.h +++ b/Userland/Applications/Spreadsheet/CellType/Date.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +15,7 @@ class DateCell : public CellType { public: DateCell(); - virtual ~DateCell() override; + virtual ~DateCell() override = default; virtual JS::ThrowCompletionOr<String> display(Cell&, const CellTypeMetadata&) const override; virtual JS::ThrowCompletionOr<JS::Value> js_value(Cell&, const CellTypeMetadata&) const override; }; diff --git a/Userland/Applications/Spreadsheet/CellType/Identity.cpp b/Userland/Applications/Spreadsheet/CellType/Identity.cpp index 70a43c8be0..2a35ed3a46 100644 --- a/Userland/Applications/Spreadsheet/CellType/Identity.cpp +++ b/Userland/Applications/Spreadsheet/CellType/Identity.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,10 +15,6 @@ IdentityCell::IdentityCell() { } -IdentityCell::~IdentityCell() -{ -} - JS::ThrowCompletionOr<String> IdentityCell::display(Cell& cell, const CellTypeMetadata&) const { return cell.js_data().to_string(cell.sheet().global_object()); diff --git a/Userland/Applications/Spreadsheet/CellType/Identity.h b/Userland/Applications/Spreadsheet/CellType/Identity.h index 5811a7305e..917e7140c5 100644 --- a/Userland/Applications/Spreadsheet/CellType/Identity.h +++ b/Userland/Applications/Spreadsheet/CellType/Identity.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +14,7 @@ class IdentityCell : public CellType { public: IdentityCell(); - virtual ~IdentityCell() override; + virtual ~IdentityCell() override = default; virtual JS::ThrowCompletionOr<String> display(Cell&, const CellTypeMetadata&) const override; virtual JS::ThrowCompletionOr<JS::Value> js_value(Cell&, const CellTypeMetadata&) const override; }; diff --git a/Userland/Applications/Spreadsheet/CellType/Numeric.cpp b/Userland/Applications/Spreadsheet/CellType/Numeric.cpp index 186eea277e..3a6ad0871c 100644 --- a/Userland/Applications/Spreadsheet/CellType/Numeric.cpp +++ b/Userland/Applications/Spreadsheet/CellType/Numeric.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,10 +17,6 @@ NumericCell::NumericCell() { } -NumericCell::~NumericCell() -{ -} - JS::ThrowCompletionOr<String> NumericCell::display(Cell& cell, const CellTypeMetadata& metadata) const { return propagate_failure(cell, [&]() -> JS::ThrowCompletionOr<String> { diff --git a/Userland/Applications/Spreadsheet/CellType/Numeric.h b/Userland/Applications/Spreadsheet/CellType/Numeric.h index 928bdf6d81..daad9df765 100644 --- a/Userland/Applications/Spreadsheet/CellType/Numeric.h +++ b/Userland/Applications/Spreadsheet/CellType/Numeric.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -25,7 +25,7 @@ class NumericCell : public CellType { public: NumericCell(); - virtual ~NumericCell() override; + virtual ~NumericCell() override = default; virtual JS::ThrowCompletionOr<String> display(Cell&, const CellTypeMetadata&) const override; virtual JS::ThrowCompletionOr<JS::Value> js_value(Cell&, const CellTypeMetadata&) const override; }; diff --git a/Userland/Applications/Spreadsheet/CellType/String.cpp b/Userland/Applications/Spreadsheet/CellType/String.cpp index 76a9be8782..1b768c863f 100644 --- a/Userland/Applications/Spreadsheet/CellType/String.cpp +++ b/Userland/Applications/Spreadsheet/CellType/String.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,10 +15,6 @@ StringCell::StringCell() { } -StringCell::~StringCell() -{ -} - JS::ThrowCompletionOr<String> StringCell::display(Cell& cell, const CellTypeMetadata& metadata) const { auto string = TRY(cell.js_data().to_string(cell.sheet().global_object())); diff --git a/Userland/Applications/Spreadsheet/CellType/String.h b/Userland/Applications/Spreadsheet/CellType/String.h index 15fcca374d..c6e71d217e 100644 --- a/Userland/Applications/Spreadsheet/CellType/String.h +++ b/Userland/Applications/Spreadsheet/CellType/String.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +14,7 @@ class StringCell : public CellType { public: StringCell(); - virtual ~StringCell() override; + virtual ~StringCell() override = default; virtual JS::ThrowCompletionOr<String> display(Cell&, const CellTypeMetadata&) const override; virtual JS::ThrowCompletionOr<JS::Value> js_value(Cell&, const CellTypeMetadata&) const override; }; diff --git a/Userland/Applications/Spreadsheet/CellType/Type.h b/Userland/Applications/Spreadsheet/CellType/Type.h index 89ab6ee11a..7f5e1086ff 100644 --- a/Userland/Applications/Spreadsheet/CellType/Type.h +++ b/Userland/Applications/Spreadsheet/CellType/Type.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -30,7 +30,7 @@ public: virtual JS::ThrowCompletionOr<String> display(Cell&, const CellTypeMetadata&) const = 0; virtual JS::ThrowCompletionOr<JS::Value> js_value(Cell&, const CellTypeMetadata&) const = 0; - virtual ~CellType() { } + virtual ~CellType() = default; const String& name() const { return m_name; } diff --git a/Userland/Applications/Spreadsheet/HelpWindow.cpp b/Userland/Applications/Spreadsheet/HelpWindow.cpp index 8db4322eb3..58fe6a4bcc 100644 --- a/Userland/Applications/Spreadsheet/HelpWindow.cpp +++ b/Userland/Applications/Spreadsheet/HelpWindow.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,7 +23,7 @@ class HelpListModel final : public GUI::Model { public: static NonnullRefPtr<HelpListModel> create() { return adopt_ref(*new HelpListModel); } - virtual ~HelpListModel() override { } + virtual ~HelpListModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return m_keys.size(); } virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return 1; } @@ -198,8 +198,4 @@ void HelpWindow::set_docs(JsonObject&& docs) static_cast<HelpListModel*>(m_listview->model())->set_from(m_docs); m_listview->update(); } - -HelpWindow::~HelpWindow() -{ -} } diff --git a/Userland/Applications/Spreadsheet/HelpWindow.h b/Userland/Applications/Spreadsheet/HelpWindow.h index a7eb245574..1ee43a1afa 100644 --- a/Userland/Applications/Spreadsheet/HelpWindow.h +++ b/Userland/Applications/Spreadsheet/HelpWindow.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,7 +26,7 @@ public: return *(s_the = adopt_ref(*new HelpWindow(window))); } - virtual ~HelpWindow() override; + virtual ~HelpWindow() override = default; void set_docs(JsonObject&& docs); diff --git a/Userland/Applications/Spreadsheet/JSIntegration.cpp b/Userland/Applications/Spreadsheet/JSIntegration.cpp index d4dda776aa..18314b36a2 100644 --- a/Userland/Applications/Spreadsheet/JSIntegration.cpp +++ b/Userland/Applications/Spreadsheet/JSIntegration.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -97,10 +97,6 @@ SheetGlobalObject::SheetGlobalObject(Sheet& sheet) { } -SheetGlobalObject::~SheetGlobalObject() -{ -} - JS::ThrowCompletionOr<bool> SheetGlobalObject::internal_has_property(JS::PropertyKey const& name) const { if (name.is_string()) { @@ -362,10 +358,6 @@ WorkbookObject::WorkbookObject(Workbook& workbook, JS::GlobalObject& global_obje { } -WorkbookObject::~WorkbookObject() -{ -} - void WorkbookObject::initialize(JS::GlobalObject& global_object) { Object::initialize(global_object); diff --git a/Userland/Applications/Spreadsheet/JSIntegration.h b/Userland/Applications/Spreadsheet/JSIntegration.h index 67eb5fcec5..2fb1f28ad7 100644 --- a/Userland/Applications/Spreadsheet/JSIntegration.h +++ b/Userland/Applications/Spreadsheet/JSIntegration.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -25,7 +25,7 @@ class SheetGlobalObject final : public JS::GlobalObject { public: SheetGlobalObject(Sheet&); - virtual ~SheetGlobalObject() override; + virtual ~SheetGlobalObject() override = default; virtual JS::ThrowCompletionOr<bool> internal_has_property(JS::PropertyKey const& name) const override; virtual JS::ThrowCompletionOr<JS::Value> internal_get(JS::PropertyKey const&, JS::Value receiver) const override; @@ -51,7 +51,7 @@ class WorkbookObject final : public JS::Object { public: WorkbookObject(Workbook&, JS::GlobalObject&); - virtual ~WorkbookObject() override; + virtual ~WorkbookObject() override = default; virtual void initialize(JS::GlobalObject&) override; diff --git a/Userland/Applications/Spreadsheet/Readers/XSV.h b/Userland/Applications/Spreadsheet/Readers/XSV.h index abd07117f5..63e7e3d9ef 100644 --- a/Userland/Applications/Spreadsheet/Readers/XSV.h +++ b/Userland/Applications/Spreadsheet/Readers/XSV.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -68,7 +68,7 @@ public: parse_preview(); } - virtual ~XSV() { } + virtual ~XSV() = default; void parse(); bool has_error() const { return m_error != ReadError::None; } diff --git a/Userland/Applications/Spreadsheet/Spreadsheet.cpp b/Userland/Applications/Spreadsheet/Spreadsheet.cpp index 4c28433d0e..c1d7e1f3ed 100644 --- a/Userland/Applications/Spreadsheet/Spreadsheet.cpp +++ b/Userland/Applications/Spreadsheet/Spreadsheet.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020-2021, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -81,10 +81,6 @@ Sheet::Sheet(Workbook& workbook) } } -Sheet::~Sheet() -{ -} - JS::Interpreter& Sheet::interpreter() const { return const_cast<JS::Interpreter&>(*m_interpreter); diff --git a/Userland/Applications/Spreadsheet/Spreadsheet.h b/Userland/Applications/Spreadsheet/Spreadsheet.h index 0d4a36c5e1..a3bf270df2 100644 --- a/Userland/Applications/Spreadsheet/Spreadsheet.h +++ b/Userland/Applications/Spreadsheet/Spreadsheet.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020-2021, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -29,7 +29,7 @@ public: constexpr static size_t default_row_count = 100; constexpr static size_t default_column_count = 26; - ~Sheet(); + virtual ~Sheet() override = default; Optional<Position> parse_cell_name(StringView) const; Optional<size_t> column_index(StringView column_name) const; diff --git a/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp b/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp index 8d97b57516..51b1c5cca4 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp +++ b/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,10 +13,6 @@ namespace Spreadsheet { -SheetModel::~SheetModel() -{ -} - GUI::Variant SheetModel::data(const GUI::ModelIndex& index, GUI::ModelRole role) const { if (!index.is_valid()) diff --git a/Userland/Applications/Spreadsheet/SpreadsheetModel.h b/Userland/Applications/Spreadsheet/SpreadsheetModel.h index 1536074e77..f28411db23 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetModel.h +++ b/Userland/Applications/Spreadsheet/SpreadsheetModel.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +14,7 @@ namespace Spreadsheet { class SheetModel final : public GUI::Model { public: static NonnullRefPtr<SheetModel> create(Sheet& sheet) { return adopt_ref(*new SheetModel(sheet)); } - virtual ~SheetModel() override; + virtual ~SheetModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return m_sheet->row_count(); } virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return m_sheet->column_count(); } diff --git a/Userland/Applications/Spreadsheet/SpreadsheetView.cpp b/Userland/Applications/Spreadsheet/SpreadsheetView.cpp index 941b286e3b..d780887812 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetView.cpp +++ b/Userland/Applications/Spreadsheet/SpreadsheetView.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,10 +20,6 @@ namespace Spreadsheet { -SpreadsheetView::~SpreadsheetView() -{ -} - void SpreadsheetView::EditingDelegate::set_value(GUI::Variant const& value, GUI::ModelEditingDelegate::SelectionBehavior selection_behavior) { if (value.as_string().is_null()) { diff --git a/Userland/Applications/Spreadsheet/SpreadsheetView.h b/Userland/Applications/Spreadsheet/SpreadsheetView.h index 7d63a44953..e372d68385 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetView.h +++ b/Userland/Applications/Spreadsheet/SpreadsheetView.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,7 +20,7 @@ class CellEditor final : public GUI::TextEditor { C_OBJECT(CellEditor); public: - virtual ~CellEditor() { } + virtual ~CellEditor() = default; Function<void(GUI::KeyEvent&)> on_cursor_key_pressed; @@ -89,7 +89,7 @@ class SpreadsheetView final : public GUI::Widget { C_OBJECT(SpreadsheetView); public: - ~SpreadsheetView(); + ~SpreadsheetView() = default; Sheet* sheet_if_available() { return m_sheet; } diff --git a/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp b/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp index 5f20f9281a..0401aa32f7 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp +++ b/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -540,8 +540,4 @@ void SpreadsheetWidget::initialize_menubar(GUI::Window& window) help_menu.add_action(*m_functions_help_action); help_menu.add_action(*m_about_action); } - -SpreadsheetWidget::~SpreadsheetWidget() -{ -} } diff --git a/Userland/Applications/Spreadsheet/SpreadsheetWidget.h b/Userland/Applications/Spreadsheet/SpreadsheetWidget.h index 0908293239..aa7fb14b4d 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetWidget.h +++ b/Userland/Applications/Spreadsheet/SpreadsheetWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +17,7 @@ class SpreadsheetWidget final : public GUI::Widget { C_OBJECT(SpreadsheetWidget); public: - ~SpreadsheetWidget(); + virtual ~SpreadsheetWidget() override = default; void save(StringView filename); void load_file(Core::File&); diff --git a/Userland/Applications/Spreadsheet/Writers/XSV.h b/Userland/Applications/Spreadsheet/Writers/XSV.h index 08ce3a0b5c..6e1bd8548f 100644 --- a/Userland/Applications/Spreadsheet/Writers/XSV.h +++ b/Userland/Applications/Spreadsheet/Writers/XSV.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -75,7 +75,7 @@ public: generate(); } - virtual ~XSV() { } + virtual ~XSV() = default; bool has_error() const { return m_error != WriteError::None; } WriteError error() const { return m_error; } diff --git a/Userland/Applications/SystemMonitor/GraphWidget.cpp b/Userland/Applications/SystemMonitor/GraphWidget.cpp index f59112db77..238fbb3372 100644 --- a/Userland/Applications/SystemMonitor/GraphWidget.cpp +++ b/Userland/Applications/SystemMonitor/GraphWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,14 +13,6 @@ #include <LibGfx/Path.h> #include <LibGfx/SystemTheme.h> -GraphWidget::GraphWidget() -{ -} - -GraphWidget::~GraphWidget() -{ -} - void GraphWidget::add_value(Vector<u64, 1>&& value) { m_values.enqueue(move(value)); diff --git a/Userland/Applications/SystemMonitor/GraphWidget.h b/Userland/Applications/SystemMonitor/GraphWidget.h index 0c88b7d538..775b33a299 100644 --- a/Userland/Applications/SystemMonitor/GraphWidget.h +++ b/Userland/Applications/SystemMonitor/GraphWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,7 +14,7 @@ class GraphWidget final : public GUI::Frame { C_OBJECT(GraphWidget) public: - virtual ~GraphWidget() override; + virtual ~GraphWidget() override = default; void set_max(u64 max) { m_max = max; } u64 max() const { return m_max; } @@ -34,7 +35,7 @@ public: void set_stack_values(bool stack_values) { m_stack_values = stack_values; } private: - explicit GraphWidget(); + explicit GraphWidget() = default; virtual void paint_event(GUI::PaintEvent&) override; diff --git a/Userland/Applications/SystemMonitor/MemoryStatsWidget.cpp b/Userland/Applications/SystemMonitor/MemoryStatsWidget.cpp index 4c87363484..398eead9a2 100644 --- a/Userland/Applications/SystemMonitor/MemoryStatsWidget.cpp +++ b/Userland/Applications/SystemMonitor/MemoryStatsWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -58,10 +59,6 @@ MemoryStatsWidget::MemoryStatsWidget(GraphWidget& graph) refresh(); } -MemoryStatsWidget::~MemoryStatsWidget() -{ -} - static inline u64 page_count_to_bytes(size_t count) { return count * 4096; diff --git a/Userland/Applications/SystemMonitor/MemoryStatsWidget.h b/Userland/Applications/SystemMonitor/MemoryStatsWidget.h index 0ce0bdfd4b..ff32ec9753 100644 --- a/Userland/Applications/SystemMonitor/MemoryStatsWidget.h +++ b/Userland/Applications/SystemMonitor/MemoryStatsWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class MemoryStatsWidget final : public GUI::Widget { public: static MemoryStatsWidget* the(); - virtual ~MemoryStatsWidget() override; + virtual ~MemoryStatsWidget() override = default; void refresh(); diff --git a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp index f1fdcc9c98..89c5414f62 100644 --- a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp +++ b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -111,10 +112,6 @@ NetworkStatisticsWidget::NetworkStatisticsWidget() }; } -NetworkStatisticsWidget::~NetworkStatisticsWidget() -{ -} - void NetworkStatisticsWidget::update_models() { m_adapter_model->invalidate(); diff --git a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.h b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.h index 4c2b3c3ab6..8092281d8a 100644 --- a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.h +++ b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class NetworkStatisticsWidget final : public GUI::LazyWidget { C_OBJECT(NetworkStatisticsWidget) public: - virtual ~NetworkStatisticsWidget() override; + virtual ~NetworkStatisticsWidget() override = default; private: NetworkStatisticsWidget(); diff --git a/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.cpp b/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.cpp index 90cdf3a674..9607dd9623 100644 --- a/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.cpp +++ b/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -41,10 +42,6 @@ ProcessFileDescriptorMapWidget::ProcessFileDescriptorMapWidget() m_table_view->set_model(MUST(GUI::SortingProxyModel::create(*m_model))); } -ProcessFileDescriptorMapWidget::~ProcessFileDescriptorMapWidget() -{ -} - void ProcessFileDescriptorMapWidget::set_pid(pid_t pid) { if (m_pid == pid) diff --git a/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.h b/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.h index d6284d8595..001766b6d5 100644 --- a/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.h +++ b/Userland/Applications/SystemMonitor/ProcessFileDescriptorMapWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class ProcessFileDescriptorMapWidget final : public GUI::Widget { C_OBJECT(ProcessFileDescriptorMapWidget); public: - virtual ~ProcessFileDescriptorMapWidget() override; + virtual ~ProcessFileDescriptorMapWidget() override = default; void set_pid(pid_t); diff --git a/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.cpp b/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.cpp index c10a656b51..3295892092 100644 --- a/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.cpp +++ b/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ class PagemapPaintingDelegate final : public GUI::TableCellPaintingDelegate { public: - virtual ~PagemapPaintingDelegate() override { } + virtual ~PagemapPaintingDelegate() override = default; virtual void paint(GUI::Painter& painter, const Gfx::IntRect& a_rect, const Gfx::Palette&, const GUI::ModelIndex& index) override { @@ -107,10 +108,6 @@ ProcessMemoryMapWidget::ProcessMemoryMapWidget() m_timer = add<Core::Timer>(1000, [this] { refresh(); }); } -ProcessMemoryMapWidget::~ProcessMemoryMapWidget() -{ -} - void ProcessMemoryMapWidget::set_pid(pid_t pid) { if (m_pid == pid) diff --git a/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.h b/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.h index 0db74c2d8e..b710a0b89a 100644 --- a/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.h +++ b/Userland/Applications/SystemMonitor/ProcessMemoryMapWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class ProcessMemoryMapWidget final : public GUI::Widget { C_OBJECT(ProcessMemoryMapWidget); public: - virtual ~ProcessMemoryMapWidget() override; + virtual ~ProcessMemoryMapWidget() override = default; void set_pid(pid_t); void refresh(); diff --git a/Userland/Applications/SystemMonitor/ProcessModel.cpp b/Userland/Applications/SystemMonitor/ProcessModel.cpp index d4b5fe8799..bd66c376f4 100644 --- a/Userland/Applications/SystemMonitor/ProcessModel.cpp +++ b/Userland/Applications/SystemMonitor/ProcessModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -43,10 +44,6 @@ ProcessModel::ProcessModel() m_kernel_process_icon = GUI::Icon::default_icon("gear"); } -ProcessModel::~ProcessModel() -{ -} - int ProcessModel::row_count(GUI::ModelIndex const&) const { return m_tids.size(); diff --git a/Userland/Applications/SystemMonitor/ProcessModel.h b/Userland/Applications/SystemMonitor/ProcessModel.h index 1d8092e80a..274fdf288e 100644 --- a/Userland/Applications/SystemMonitor/ProcessModel.h +++ b/Userland/Applications/SystemMonitor/ProcessModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -54,7 +55,7 @@ public: static ProcessModel& the(); static NonnullRefPtr<ProcessModel> create() { return adopt_ref(*new ProcessModel); } - virtual ~ProcessModel() override; + virtual ~ProcessModel() override = default; virtual int row_count(GUI::ModelIndex const&) const override; virtual int column_count(GUI::ModelIndex const&) const override; diff --git a/Userland/Applications/SystemMonitor/ProcessStateWidget.cpp b/Userland/Applications/SystemMonitor/ProcessStateWidget.cpp index b988547d43..e80e6f9f43 100644 --- a/Userland/Applications/SystemMonitor/ProcessStateWidget.cpp +++ b/Userland/Applications/SystemMonitor/ProcessStateWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -89,7 +90,3 @@ ProcessStateWidget::ProcessStateWidget(pid_t pid) m_table_view->column_header().set_visible(false); m_table_view->column_header().set_section_size(0, 90); } - -ProcessStateWidget::~ProcessStateWidget() -{ -} diff --git a/Userland/Applications/SystemMonitor/ProcessStateWidget.h b/Userland/Applications/SystemMonitor/ProcessStateWidget.h index 1a57e35bfa..a2fd3e7bd7 100644 --- a/Userland/Applications/SystemMonitor/ProcessStateWidget.h +++ b/Userland/Applications/SystemMonitor/ProcessStateWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class ProcessStateWidget final : public GUI::Widget { C_OBJECT(ProcessStateWidget); public: - virtual ~ProcessStateWidget() override; + virtual ~ProcessStateWidget() override = default; private: explicit ProcessStateWidget(pid_t); diff --git a/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp b/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp index 9d4dff2316..4678192477 100644 --- a/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp +++ b/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -24,10 +25,6 @@ ProcessUnveiledPathsWidget::ProcessUnveiledPathsWidget() m_table_view->set_model(MUST(GUI::SortingProxyModel::create(*m_model))); } -ProcessUnveiledPathsWidget::~ProcessUnveiledPathsWidget() -{ -} - void ProcessUnveiledPathsWidget::set_pid(pid_t pid) { if (m_pid == pid) diff --git a/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h b/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h index b92c53337d..eec1f4a332 100644 --- a/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h +++ b/Userland/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class ProcessUnveiledPathsWidget final : public GUI::Widget { C_OBJECT(ProcessUnveiledPathsWidget); public: - virtual ~ProcessUnveiledPathsWidget() override; + virtual ~ProcessUnveiledPathsWidget() override = default; void set_pid(pid_t); diff --git a/Userland/Applications/SystemMonitor/ThreadStackWidget.cpp b/Userland/Applications/SystemMonitor/ThreadStackWidget.cpp index baeba6e377..d63d7660ee 100644 --- a/Userland/Applications/SystemMonitor/ThreadStackWidget.cpp +++ b/Userland/Applications/SystemMonitor/ThreadStackWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -73,10 +74,6 @@ ThreadStackWidget::ThreadStackWidget() m_stack_table->set_model(adopt_ref(*new ThreadStackModel())); } -ThreadStackWidget::~ThreadStackWidget() -{ -} - void ThreadStackWidget::show_event(GUI::ShowEvent&) { refresh(); diff --git a/Userland/Applications/SystemMonitor/ThreadStackWidget.h b/Userland/Applications/SystemMonitor/ThreadStackWidget.h index b3442d1b88..25756a1821 100644 --- a/Userland/Applications/SystemMonitor/ThreadStackWidget.h +++ b/Userland/Applications/SystemMonitor/ThreadStackWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -12,7 +13,7 @@ class ThreadStackWidget final : public GUI::Widget { C_OBJECT(ThreadStackWidget) public: - virtual ~ThreadStackWidget() override; + virtual ~ThreadStackWidget() override = default; void set_ids(pid_t pid, pid_t tid); void refresh(); diff --git a/Userland/Applications/SystemMonitor/main.cpp b/Userland/Applications/SystemMonitor/main.cpp index 5dd29186db..314417aa24 100644 --- a/Userland/Applications/SystemMonitor/main.cpp +++ b/Userland/Applications/SystemMonitor/main.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Undefine <cqundefine@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -61,7 +62,7 @@ static RefPtr<GUI::Statusbar> statusbar; class UnavailableProcessWidget final : public GUI::Frame { C_OBJECT(UnavailableProcessWidget) public: - virtual ~UnavailableProcessWidget() override { } + virtual ~UnavailableProcessWidget() override = default; const String& text() const { return m_text; } void set_text(String text) { m_text = move(text); } @@ -383,7 +384,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) class ProgressbarPaintingDelegate final : public GUI::TableCellPaintingDelegate { public: - virtual ~ProgressbarPaintingDelegate() override { } + virtual ~ProgressbarPaintingDelegate() override = default; virtual void paint(GUI::Painter& painter, const Gfx::IntRect& a_rect, const Palette& palette, const GUI::ModelIndex& index) override { diff --git a/Userland/Applications/TextEditor/FileArgument.cpp b/Userland/Applications/TextEditor/FileArgument.cpp index 732889c48c..e6acff471e 100644 --- a/Userland/Applications/TextEditor/FileArgument.cpp +++ b/Userland/Applications/TextEditor/FileArgument.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, ry755 <ryanst755@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -48,9 +49,4 @@ FileArgument::FileArgument(String file_argument) m_filename = groups.at(0).view.to_string(); } } - -FileArgument::~FileArgument() -{ -} - } diff --git a/Userland/Applications/TextEditor/FileArgument.h b/Userland/Applications/TextEditor/FileArgument.h index 06813df4cc..1646a6b7bb 100644 --- a/Userland/Applications/TextEditor/FileArgument.h +++ b/Userland/Applications/TextEditor/FileArgument.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, ry755 <ryanst755@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,7 +14,7 @@ namespace TextEditor { class FileArgument final { public: explicit FileArgument(String); - ~FileArgument(); + ~FileArgument() = default; String filename() { return m_filename; } Optional<size_t> line() { return m_line; } diff --git a/Userland/Applications/TextEditor/MainWidget.cpp b/Userland/Applications/TextEditor/MainWidget.cpp index 24f354ed81..85716b6692 100644 --- a/Userland/Applications/TextEditor/MainWidget.cpp +++ b/Userland/Applications/TextEditor/MainWidget.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -326,10 +327,6 @@ MainWidget::MainWidget() m_toolbar->add_action(m_editor->redo_action()); } -MainWidget::~MainWidget() -{ -} - Web::OutOfProcessWebView& MainWidget::ensure_web_view() { if (!m_page_view) { diff --git a/Userland/Applications/TextEditor/MainWidget.h b/Userland/Applications/TextEditor/MainWidget.h index 4f2be8a589..68b1ade247 100644 --- a/Userland/Applications/TextEditor/MainWidget.h +++ b/Userland/Applications/TextEditor/MainWidget.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -23,7 +24,7 @@ class MainWidget final : public GUI::Widget { C_OBJECT(MainWidget); public: - virtual ~MainWidget() override; + virtual ~MainWidget() override = default; bool read_file(Core::File&); void open_nonexistent_file(String const& path); bool request_close(); diff --git a/Userland/Applications/ThemeEditor/PreviewWidget.cpp b/Userland/Applications/ThemeEditor/PreviewWidget.cpp index 423f348896..49ae0f3114 100644 --- a/Userland/Applications/ThemeEditor/PreviewWidget.cpp +++ b/Userland/Applications/ThemeEditor/PreviewWidget.cpp @@ -2,6 +2,7 @@ * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2021, Antonio Di Stefano <tonio9681@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -100,10 +101,6 @@ PreviewWidget::PreviewWidget(const Gfx::Palette& preview_palette) set_greedy_for_hits(true); } -PreviewWidget::~PreviewWidget() -{ -} - void PreviewWidget::load_theme_bitmaps() { auto load_bitmap = [](String const& path, String& last_path, RefPtr<Gfx::Bitmap>& bitmap) { diff --git a/Userland/Applications/ThemeEditor/PreviewWidget.h b/Userland/Applications/ThemeEditor/PreviewWidget.h index af822916e5..f096c8cd89 100644 --- a/Userland/Applications/ThemeEditor/PreviewWidget.h +++ b/Userland/Applications/ThemeEditor/PreviewWidget.h @@ -2,6 +2,7 @@ * Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2021, Antonio Di Stefano <tonio9681@gmail.com> + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ class PreviewWidget final : public GUI::Frame { C_OBJECT(PreviewWidget); public: - virtual ~PreviewWidget() override; + virtual ~PreviewWidget() override = default; const Gfx::Palette& preview_palette() const { return m_preview_palette; } void set_preview_palette(const Gfx::Palette&); diff --git a/Userland/Applications/Welcome/WelcomeWidget.cpp b/Userland/Applications/Welcome/WelcomeWidget.cpp index 259a73bd07..d1ed999b6d 100644 --- a/Userland/Applications/Welcome/WelcomeWidget.cpp +++ b/Userland/Applications/Welcome/WelcomeWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -80,10 +80,6 @@ WelcomeWidget::WelcomeWidget() set_random_tip(); } -WelcomeWidget::~WelcomeWidget() -{ -} - void WelcomeWidget::open_and_parse_tips_file() { auto file = Core::File::construct("/home/anon/Documents/tips.txt"); diff --git a/Userland/Applications/Welcome/WelcomeWidget.h b/Userland/Applications/Welcome/WelcomeWidget.h index a0853b0d18..ed4d795194 100644 --- a/Userland/Applications/Welcome/WelcomeWidget.h +++ b/Userland/Applications/Welcome/WelcomeWidget.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021, the SerenityOS developers. + * Copyright (c) 2021-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -13,7 +13,7 @@ class WelcomeWidget final : public GUI::Widget { C_OBJECT(WelcomeWidget); public: - virtual ~WelcomeWidget() override; + virtual ~WelcomeWidget() override = default; private: WelcomeWidget(); |