diff options
author | Brian Gianforcaro <bgianf@serenityos.org> | 2022-01-17 00:52:42 -0800 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2022-01-17 11:17:15 +0100 |
commit | d20c5da0daff278ef9dc3bcb32991a9d141133f9 (patch) | |
tree | 8327bc63284b716309fe4dd6f9aeb3832bb8df79 /.gitattributes | |
parent | 4b2bbe6a7eb873eb8a3a80a8ed20a7d127e4be51 (diff) | |
download | serenity-d20c5da0daff278ef9dc3bcb32991a9d141133f9.zip |
Meta: Optimized lint-ports.py by avoiding duplicate execs of package.sh
The way that lint-ports.py obtains the ports properties is unfortunately
very process intensive. You have to execute `./package.sh showproperty`
once for each property, for each port. Resulting in hundreds of
executions.
We were doing this work twice in both `check_package_files()` and in
`read_port_dirs()`. This resulted in a runtime of around ~10 seconds on
my machine. Removing the duplicate work and allowing the other code path
to utilize the to use the cached properties brought the runtime down to
~5 seconds on my machine.
Diffstat (limited to '.gitattributes')
0 files changed, 0 insertions, 0 deletions