From b8d5ca85d9a6e6f42b8dbd6d47cab7bbcffeea90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Courr=C3=A8ges-Anglas?= Date: Fri, 3 Jan 2014 22:18:51 +0100 Subject: if (ptr) free(ptr) is not a good idiom. --- src/globals.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/globals.c') diff --git a/src/globals.c b/src/globals.c index 233f2ae..f81d7ad 100644 --- a/src/globals.c +++ b/src/globals.c @@ -108,8 +108,7 @@ set_nselection (char *txt, int len) int i; /* Update the selection structure */ - if (selection.text != NULL) - free(selection.text); + free (selection.text); /* Copy the string by hand. */ selection.text = malloc(len+1); @@ -125,8 +124,7 @@ void set_selection (char *txt) { /* Update the selection structure */ - if (selection.text != NULL) - free(selection.text); + free (selection.text); selection.text = xstrdup (txt); selection.len = strlen (txt); -- cgit v1.2.3