Age | Commit message (Collapse) | Author | |
---|---|---|---|
2014-03-03 | Add error checking for various boolean (0|1) settings. | Jérémie Courrèges-Anglas | |
2014-03-03 | Correct error message in set_barinpadding. | Jérémie Courrèges-Anglas | |
2014-03-03 | Factorize space for invalid negative args messages in various settings. | Jérémie Courrèges-Anglas | |
2014-03-03 | Make read_number more strict, returning errors. | Jérémie Courrèges-Anglas | |
* use strtol, and warn about overflow or invalid input. | |||
2014-03-03 | In read_frame, don't silently ignore invalid/unknown frame selectors. | Jérémie Courrèges-Anglas | |
2014-03-03 | Rename (again) string_to_number to string_to_positive_number | Jérémie Courrèges-Anglas | |
* where it is used, only (small) positive numbers make sense. * While here use strtol instead of manually parsing the string, and be careful about validation. (Still) return -1 to indicate failure. | |||
2014-03-03 | Amend find_group: first match by number, then by name. | Jérémie Courrèges-Anglas | |
* this is consistent with cmd_select and read_window. If one has a keybinding for "gselect 0" and then happens to have a group named "0", "gselect 0" should keep the same behavior: lead to group numbered 0. Discussed with |cos| who proposed the recent "search groups for exact name match first". | |||
2014-03-03 | Search windows names for exact match then for fuzzy match | Jérémie Courrèges-Anglas | |
* Contrary to the recent find_group change, windows are still searched by number first. This is inconsistent and a choice has to be made. | |||
2014-03-03 | Fix cmd_getsel when there is no X selection | Jérémie Courrèges-Anglas | |
* instead of feeding stdio a NULL string and invoking undefined behavior, return a failure | |||
2014-03-03 | In set_winname compare the full string, including the final NUL. | Jérémie Courrèges-Anglas | |
* detects erroneous inputs such as "titlefoo" instead of "title" | |||
2014-03-03 | "deffoo..." -> "set foo..." in the error messages. | Jérémie Courrèges-Anglas | |
* "deffoo"-style names are only compat aliases these days. | |||
2014-03-03 | Better, faster, prettier groups_find_by_group_name | Jérémie Courrèges-Anglas | |
* there are really two operation modes that could even be put into separate functions. So disentangle the logic and put the operation mode check outside of the loop parsing the groups list. | |||
2014-03-03 | Rename string_to_window_number to string_to_number. | Jérémie Courrèges-Anglas | |
* The previous name didn't make sense since it was also used for group numbers. * This function should probably make more checks or be deleted. | |||
2014-03-03 | Fix a typo in a comment. | Jérémie Courrèges-Anglas | |
2014-03-03 | Silence warning in previous commit. | Jérémie Courrèges-Anglas | |
2014-03-02 | Allow exact matching with gselect.fix/gselect_exact_match | cos | |
When having two groups where the second one's name partially matches the name of the first one, it is hard to gselect the second one. Similarly it is not possible to select groups with fully numerical names. e.g. If having the group list: 0-default 1*other 2-de 3-0 The user expactation when typing ":gselect de" or ":gselect 0" would likely be to select group number 2 & group number 3 respectively. This commit modifies the behaviour of gselect, to primarily select the group with an exactly matching name if possible, before trying numerical or partial matches. | |||
2014-02-20 | Fall back to ioctl(TIOCNOTTY) to detach from the controlling terminal. | Jérémie Courrèges-Anglas | |
* As with setpgid, only do this if setsid fails or is absent. | |||
2014-02-20 | Only call setpgid when setsid fails or is absent. | Jérémie Courrèges-Anglas | |
2014-02-20 | Detect pwd.h and getpwuid. | Jérémie Courrèges-Anglas | |
2014-02-20 | If HOME is not set in the env., fallback to the passwd entry. | Jérémie Courrèges-Anglas | |
* No attempt to detect pwd.h / getpwuid, not sure if needed. | |||
2014-02-20 | Mark the X socket as to be closed on exec. | Jérémie Courrèges-Anglas | |
* Avoids leaking a descriptor, and potential problems described in the comp.windows.x FAQ. | |||
2014-02-20 | Change set_close_on_exec to take a file descriptor. | Jérémie Courrèges-Anglas | |
* Since it's easier to get a fd from a FILE * rather than the other way around. | |||
2014-02-20 | Kill getsid(2) check in get_child_info. | Jérémie Courrèges-Anglas | |
* Purpose not understood, usage can't be right on OSes where getsid fails with EPERM if ratpoison and the argument pid are not in the session; guess what, ratpoison calls setsid(2) in spawn()... | |||
2014-02-20 | Kill noisy local variable. | Jérémie Courrèges-Anglas | |
2014-02-20 | Amend / kill weak comments. | Jérémie Courrèges-Anglas | |
2014-02-20 | Simplify using sbuf_free_struct. | Jérémie Courrèges-Anglas | |
2014-02-20 | Stop using XKeycodeToKeysym (deprecated). | Jérémie Courrèges-Anglas | |
* Use XkbKeycodeToKeysym instead. Not sure if this is a good change, but publish it at least so that people can test and report. | |||
2014-02-20 | Make some members of struct rp_input_line size_t. | Jérémie Courrèges-Anglas | |
2014-02-20 | Test for __builtin_prefetch, not for __GNUC__. | Jérémie Courrèges-Anglas | |
* Fixes build with pcc. | |||
2014-01-06 | Revert b470085. | Jérémie Courrèges-Anglas | |
* Wrong usage of pointers. Those two helper functions are supposed to update frame parameters passed as pointers, but this does not work. Assigning to a pointer merely changes its local value. * Additionally, forgotten assignment to "done" in find_non_dedicated_frame(), bug not visible in non-xinerama setups. | |||
2014-01-05 | Kill code #if 0'ed since 2001. | Jérémie Courrèges-Anglas | |
2014-01-04 | Kill init_globals(). | Jérémie Courrèges-Anglas | |
* selection has static storage and is thus correctly initialized. | |||
2014-01-04 | Ansify read_any_key(). | Jérémie Courrèges-Anglas | |
2014-01-03 | Make our fallback getline more compliant. | Jérémie Courrèges-Anglas | |
* don't use xmalloc/xrealloc, but return -1 in case of memory allocation failure * modify the parameters only when allocation succeeds | |||
2014-01-03 | Don't mix code and decls. | Jérémie Courrèges-Anglas | |
2014-01-03 | strdup -> xstrdup | Jérémie Courrèges-Anglas | |
2014-01-03 | malloc -> xmalloc | Jérémie Courrèges-Anglas | |
2014-01-03 | One realloc -> xrealloc. | Jérémie Courrèges-Anglas | |
2014-01-03 | Get rid of useless casts of xmalloc/realloc return value. | Jérémie Courrèges-Anglas | |
2014-01-03 | if (ptr) free(ptr) is not a good idiom. | Jérémie Courrèges-Anglas | |
2014-01-03 | Kill useless X_LDFLAGS and reorder variables. | Jérémie Courrèges-Anglas | |
2014-01-03 | Open $sysconfdir/ratpoisonrc, don't hardcode /etc. | Jérémie Courrèges-Anglas | |
2014-01-03 | Be more verbose about failures in read_startup_files(). | Jérémie Courrèges-Anglas | |
* If we fail with errno set to something != ENOENT then an error message should probably be printed. | |||
2014-01-03 | Better error checking for -f configfile. | Jérémie Courrèges-Anglas | |
* make read_startup_files() return whether it succeeded. A failure is when the user passed a specific config file, but we couldn't load it. * in main() exit if read_startup_files() failed. | |||
2014-01-03 | Report bugs to PACKAGE_BUGREPORT. | Jérémie Courrèges-Anglas | |
2014-01-03 | In str_comp() make len and i size_t. | Jérémie Courrèges-Anglas | |
2014-01-03 | Typo in comment. | Jérémie Courrèges-Anglas | |
2014-01-03 | Tiny xmalloc/realloc/strdup cleanup. | Jérémie Courrèges-Anglas | |
* kill "register" * compare pointers against NULL * separate declarations and code | |||
2014-01-03 | In parse_keydesc() strdup the key desc only if needed. | Jérémie Courrèges-Anglas | |
2014-01-03 | messages.h is included from ratpoison.h. | Jérémie Courrèges-Anglas | |