summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-02-23Fix select error handling.brainwash
Skip the error message and only show the window list when selecting an used window number in interactive mode.
2015-06-16New settable variable, framemsgwaitJérémie Courrèges-Anglas
Same as "msgwait" for for "Current Frame" messages.
2015-06-16Make msgwait a variable; keep the command for a whileJérémie Courrèges-Anglas
2015-02-05Be more strict about what "dedicate" acceptsJérémie Courrèges-Anglas
No argument or... either 0 or 1. Will perhaps make debugging easier.
2015-01-08Fix double free at exit time.Jérémie Courrèges-Anglas
On Ubuntu (system used by the problem reporter) this is a double free, on OpenBSD with S in malloc.conf it ends in a SIGBUS probably because of the aggressive junking.
2014-12-31Third try at cleaning set_active_window_bodyJérémie Courrèges-Anglas
Delete the weird logic and the nested loops. Use a true helper function, don't just move code around.
2014-12-31Style fixes in set_active_window_bodyJérémie Courrèges-Anglas
* Delete useless parens * Sprinkle whitespace * No "if (cond) statement;" on a single line (items from the GNU coding standards, cf. README.developers) Additionally, * Don't mix code and decls, for consistency * Compare pointers against NULL
2014-12-30Refactor duplicate branches of if() into a single block with leading ?:.Jeff Abrahamson
2014-09-17Comment on why XKeycodeToKeysym is still needed.Jérémie Courrèges-Anglas
Prodded by Jeff Abrahamson.
2014-09-15Plug memory leak in xineramaJérémie Courrèges-Anglas
If there is only one Xinerama screen we do not care about Xinerama but we should still free resources we just obtained.
2014-09-15Correct tortuous comparison that triggers warningsJérémie Courrèges-Anglas
The code was actually correct but boy, this is no way to write a comparison. XineramaQueryVersion() returns zero on failure, so compare against that. Not False, not Success, not Maybe.
2014-09-14Check for and include sys/stat.hJérémie Courrèges-Anglas
* needed by the recent use of fchmod, missing include warning triggered on Debian stable but not OpenBSD
2014-06-14Fix sfdump.Jérémie Courrèges-Anglas
One more proof that I should not hack on the multiple screens support. Patch from Joshua Leners.
2014-06-14Kill RCS Ids.Jérémie Courrèges-Anglas
2014-04-02At saving time, restrict the permissions of the history fileJérémie Courrèges-Anglas
2014-04-02fclose returns 0 on successJérémie Courrèges-Anglas
* amend the test to avoid needless spamming when running in debug mode * tweak spacing while here
2014-04-02Make sbuf_printf update the len and maxsz internal fieldsJérémie Courrèges-Anglas
* sbuf_printf updated the .data field with a freshly allocated string, but didn't bother setting the .len and .maxsz fields of the sbuf. Calling other sbuf_* functions on the same sbuf could lead to erratic behavior and data corruption. eg. in init_screen, the screen's display_string ended up corrupted, using putenv ratpoison couldn't override the DISPLAY environment variable in child processes anymore, introducing a regression on multi-screen setups. Bug reported and cause tracked down by William Yodlowsky, the maintainer of the OpenBSD ratpoison port. Thanks!
2014-03-29In read_shellcmd make sure we don't dereference a NULL pointer.Jérémie Courrèges-Anglas
2014-03-29Detect XKB support at build and runtime.Jérémie Courrèges-Anglas
2014-03-24Stray empty line introduced in 5dcd243Jérémie Courrèges-Anglas
2014-03-24Ensure NULL is treated as a pointer in execl* callsJérémie Courrèges-Anglas
2014-03-24Avoid malloc(0) in add_command.Jérémie Courrèges-Anglas
2014-03-24In frestore flag a frame_read error as appropriate.Jérémie Courrèges-Anglas
* while here kill a stray ';'
2014-03-24Factorize code in cmd_fdump.Jérémie Courrèges-Anglas
2014-03-24Factorize code in update_{window,group}_names.Jérémie Courrèges-Anglas
2014-03-24Indent function calls in unmanaged_window.Jérémie Courrèges-Anglas
2014-03-24Make unmanaged_window cheaper.Jérémie Courrèges-Anglas
* No need to get then free the window name in the loop, do it out of the loop.
2014-03-24Kill decls forgotten in a5ee817 "Kill code #if 0'ed since 2001."Jérémie Courrèges-Anglas
2014-03-24read_startup_files doesn't mangle its argument.Jérémie Courrèges-Anglas
2014-03-24Don't dup args passed on the cli, we don't mangle them.Jérémie Courrèges-Anglas
2014-03-24Put history_expand_line's return type on its own line.Jérémie Courrèges-Anglas
2014-03-24In history_add_upto make sure we don't dereference a NULL pointer;Jérémie Courrèges-Anglas
2014-03-24Kill history_resize, unused.Jérémie Courrèges-Anglas
2014-03-24Kill unused and forgotten include of assert.h in bar.cJérémie Courrèges-Anglas
2014-03-24Kill code and simplify cmd_numberJérémie Courrèges-Anglas
* cmd_number needs at least one argument * The code that handled the zero argument case was thus unreachable, and was the last user of print_window_information, so kill that function.
2014-03-04Kill last strcpy occurrence.Jérémie Courrèges-Anglas
* replace_keybinding is seldom used, no need to half-optimize it
2014-03-04strcpy -> memcpyJérémie Courrèges-Anglas
* since we have to know the string length anyway
2014-03-04strncpy -> memcpy.Jérémie Courrèges-Anglas
* we NUL-terminate it anyway * kill a useless "* sizeof (char)" while here
2014-03-04Kill useless comment.Jérémie Courrèges-Anglas
2014-03-04Simplify init_screen using sbufJérémie Courrèges-Anglas
2014-03-04Simplify read_shellcmd using sbufJérémie Courrèges-Anglas
2014-03-04Small coding standards fix.Jérémie Courrèges-Anglas
2014-03-04Simplify list_unmanaged_windows using sbufJérémie Courrèges-Anglas
2014-03-04More decls/code separation. More spacing too.Jérémie Courrèges-Anglas
2014-03-04Use get_homedir anywhere we can.Jérémie Courrèges-Anglas
2014-03-04get_homedir(), checks HOME and the password databaseJérémie Courrèges-Anglas
* ensures that the resulting home directory isn't the empty string (else returns NULL)
2014-03-03Refine error messages in cmd_fdump.Jérémie Courrèges-Anglas
2014-03-03Add error checking to set_padding and set_historysize.Jérémie Courrèges-Anglas
2014-03-03Add error checking for various boolean (0|1) settings.Jérémie Courrèges-Anglas
2014-03-03Correct error message in set_barinpadding.Jérémie Courrèges-Anglas