| Age | Commit message (Collapse) | Author |
|---|
|
* "deffoo"-style names are only compat aliases these days.
|
|
* The previous name didn't make sense since it was also used for group
numbers.
* This function should probably make more checks or be deleted.
|
|
|
|
|
|
When having two groups where the second one's name partially matches the name
of the first one, it is hard to gselect the second one. Similarly it is not
possible to select groups with fully numerical names.
e.g.
If having the group list:
0-default
1*other
2-de
3-0
The user expactation when typing ":gselect de" or ":gselect 0" would likely be
to select group number 2 & group number 3 respectively.
This commit modifies the behaviour of gselect, to primarily select the group
with an exactly matching name if possible, before trying numerical or partial
matches.
|
|
* As with setpgid, only do this if setsid fails or is absent.
|
|
|
|
* Since it's easier to get a fd from a FILE * rather than the other way
around.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* those functions expect an int whose value is between -1 and 255.
Cast to unsigned char so that sign extension when promoting to int
doesn't bite us.
|
|
* plug memory leak
* consistent indentation
* minimize variables scope
* kill commented code
|
|
* zero out the whole struct and explicitely assign CurrentTime (OL) to
ev.xkey.time. This should please Firefox when using C-t t.
|
|
* those commas shouldn't have been there in the first place. If your
scripts rely on this, watch out!
* code simplified and variables better named, while here.
|
|
Noticed by Repolho <repolho at zoho dot com>, who came with a different
fix.
|
|
Better variable names, more readable formatting.
Use a fixed buffer for the screen number appended to each frameset.
|
|
|
|
|
|
|
|
Noticed by Repolho <repolho at zoho dot com>, who came with a similar
fix.
|
|
|
|
Since add_command() for cmd_gnumber is forcing one (or two) numerical argument,
command() will never allow calling the cmd_gnumber() with arg[0] set to NULL.
|
|
|
|
* cmd_definekey: actually use cmd
* cmd_meta: remove ev1
* cmd_resize: remove nbytes
* cmd_ratrelwarp: remove s
* draw_string: remove lgv, lgc, mask; lgc wasn't XFreeGC'ed
* get_more_input: remove nbytes
* cleanup_frame: remove last_win
* get_window_list: remove other_window
Patch from Bernhard R. Link
|
|
* use a local variable instead of using ARG_STRING(0) ten times
* minimize scope of local variables
* use a struct sbuf instead of playing with xmalloc and strncpy
* correct indentation
|
|
* instead of playing with xmalloc, strlen and strncpy, use xstrdup
to do the copying and strcspn to delete the newline
|
|
* if the user aborted we receive a NULL pointer; don't attempt to
dereference it, and treat this case as a failure.
Matches the behaviour of cmd_colon and cmd_select
|
|
* in cmd_select(), consistently set the return value for all cases we deal
with
* in cmd_unmanage(), don't attempt to use a NULL pointer if the unmanaged
windows list is empty; just report success
* in cmd_kill, only report failure if XKillClient() actually failed
* in command(), remove a useless test: cmd can't be NULL
* in cmd_gravity, don't call current_window() twice
|
|
* only print the "Command key: ..." bits if we're dealing with
the root kmap
* don't read (and print) uninitialized data
(foomap->actions[foomap->actions_last] shouldn't be accessed)
It seems like keymap actions and other things like aliases
use arrays because they were implemented before linkedlist.[ch]
were introduced. Perhaps should we just switch them to more
fool-proof linked lists?
|
|
* (globals.[ch]): remove rp_text_width "font" arg, since its value
is always the global variable defaults.font (non-Xft case).
remove one #ifdef while here
* update rp_text_width() calls to match new signature
|
|
for waitpid(SIGCHLD, SIG_IGN) behaves wildly differently across OSes. Fixes
tmpwm hanging after child wm exits on OpenBSD.
|
|
* AC_CHECK_FUNCS: +setenv +unsetenv -putenv
(the check for putenv() wasn't used anyway)
* prefer setenv() to putenv() in cmd_setenv()
* prefer unsetenv() to putenv() in cmd_unsetenv()
- putenv("FOO") isn't legit everywhere
- putenv("FOO=") will only work on MinGW
* make the getenv command return an empty output if the variable wasn't found
* while here, split and sort AC_CHECK_FUNCS
|cos| on #ratpoison reported that environment variables weren't
properly removed, and proposed a different fix. thanks!
|
|
Without this change, cmd_info displays "No Window" if called
with the current window not in the current group (for example
directly after a gselect).
This change makes it also look in other groups. In that case
it might show a number not the one to switch back to it without
switching the group first, but I guess that is less confusing
than just claiming there is no window.
|
|
|
|
When an alias is executed without arguments, for example aliasing
"reload" to "source .ratpoisonrc" and then running "reload" by itself
results in "source: .ratpoisonrc : No such file or directory" implying
it was trying to load ".ratpoisonrc " (note the extra space).
|
|
|
|
exchange_with_frame now always selects the second frame given,
simplifying the code (getting rid of segfaults when both were
on different screens). This changes the behaviour of cmd_swap
to always focus the first argument when two arguments are given.
This patch also removes the screen argument of exchange_with_frame,
which is now no longer needed (and cmd_swap was giving the wrong
screen anyway in the case of multiple arguments given).
|
|
|
|
As reported by "Gentooer" in the #ratpoison IRC channel, there is a bug in
:cother and :iother. If are no windows and you issue either :cother, or
:iother ratpoison segfaults. This patch resolves the issue.
|
|
|
|
|
|
|
|
Now the inverted rectangle is drawn first and the text overtop in the bg color.
|
