Deprecate winliststyle variable & functionality.cr/deprecate_winliststyle

Window lists in ratpoison were initially displayed in one row, as modelled by
how :windows work in screen. When originally implementing column display format
an option to select between row & column was introduced.

Setting winliststyle to row has been broken for almost four years. Given that
no error reports have been seen during this time, it is fair to assume no one
is using the functionality.

Since allowing two values of winliststyle complicates the code to display
winlists & requires different code paths for interactive & non-interactive use,
it seems more sane to deprecate the unused feature rather than fix its bug(s).

1 files changed, 2 insertions, 0 deletions

diff --git a/src/bar.c b/src/bar.c
index 88b9966..8b249fa 100644
--- a/src/bar.c
+++ b/src/bar.c
@@ -192,12 +192,14 @@ update_window_names (rp_screen *s, char *fmt)
 
   bar_buffer = sbuf_new (0);
 
+#ifdef WINLISTSTYLE
   if(defaults.window_list_style == STYLE_ROW)
     {
       get_window_list (fmt, NULL, bar_buffer, &mark_start, &mark_end);
       marked_message_internal (sbuf_get (bar_buffer), mark_start, mark_end);
     }
   else
+#endif
     {
       get_window_list (fmt, "\n", bar_buffer, &mark_start, &mark_end);
       marked_message_internal (sbuf_get (bar_buffer), mark_start, mark_end);