From d9753cca6b0db724bc6d15e60cfad1705f800b96 Mon Sep 17 00:00:00 2001 From: Eduardo Habkost Date: Thu, 8 Oct 2020 16:27:12 -0400 Subject: can-host-socketcan: Fix crash when 'if' option is not set Fix the following crash: $ qemu-system-x86_64 -object can-host-socketcan,id=obj0 Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Acked-by: Pavel Pisa Message-Id: <20201008202713.1416823-3-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost --- net/can/can_socketcan.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'net') diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 92b1f79385..4b68f60c6b 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -194,6 +194,11 @@ static void can_host_socketcan_connect(CanHostState *ch, Error **errp) struct sockaddr_can addr; struct ifreq ifr; + if (!c->ifname) { + error_setg(errp, "'if' property not set"); + return; + } + /* open socket */ s = qemu_socket(PF_CAN, SOCK_RAW, CAN_RAW); if (s < 0) { -- cgit v1.2.3