From 50b7b000c9171c1253c1c875f46f654c3c0e1fc8 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Thu, 10 Sep 2015 10:19:16 -0600 Subject: hmp: Allow for error message hints on HMP Commits 7216ae3d and d2828429 disabled some error message hints, all because a change to use modern error reporting meant that the hint would be output prior to the actual error. Fix this by making hints a first-class member of Error. For example, we are now back to the pleasant: $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. Signed-off-by: Eric Blake Reviewed-by: Paolo Bonzini Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster --- include/qapi/error.h | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'include') diff --git a/include/qapi/error.h b/include/qapi/error.h index 426d5eaceb..d7878c3088 100644 --- a/include/qapi/error.h +++ b/include/qapi/error.h @@ -155,6 +155,13 @@ void error_setg_win32_internal(Error **errp, */ void error_propagate(Error **dst_errp, Error *local_err); +/** + * Append a printf-style human-readable explanation to an existing error. + * May be called multiple times, and safe if @errp is NULL. + */ +void error_append_hint(Error **errp, const char *fmt, ...) + GCC_FMT_ATTR(2, 3); + /* * Convenience function to report open() failure. */ -- cgit v1.2.3