diff options
| author | Corentin Chary <corentincj@iksaif.net> | 2011-02-25 22:54:53 +0100 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2011-02-25 16:04:43 -0600 |
| commit | c53af37f375ce9c4999ff451c51173bdc1167e67 (patch) | |
| tree | 55dbd29263542085dccb960893daa378e9b66395 /ui/vnc-jobs-async.c | |
| parent | 30faaf7073dd51b9e06589d7886696a3f13f201c (diff) | |
| download | qemu-c53af37f375ce9c4999ff451c51173bdc1167e67.zip | |
vnc: fix a memory leak in threaded vnc server
VncJobQueue's buffer is intended to be used for
as the output buffer for all operations in this queue,
but unfortunatly.
vnc_async_encoding_start() is in charge of setting this
buffer as the current output buffer, but
vnc_async_encoding_end() was not writting the changes back
to VncJobQueue, resulting in a big and ugly memleak.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'ui/vnc-jobs-async.c')
| -rw-r--r-- | ui/vnc-jobs-async.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c index 1d4c5e7f78..f596247004 100644 --- a/ui/vnc-jobs-async.c +++ b/ui/vnc-jobs-async.c @@ -186,6 +186,8 @@ static void vnc_async_encoding_end(VncState *orig, VncState *local) orig->hextile = local->hextile; orig->zrle = local->zrle; orig->lossy_rect = local->lossy_rect; + + queue->buffer = local->output; } static int vnc_worker_thread_loop(VncJobQueue *queue) |