summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2018-11-20 18:09:49 +0100
committerKevin Wolf <kwolf@redhat.com>2018-11-21 10:30:05 +0100
commitd8336c6b286d9715bfe29a0e0b415dfd7891f671 (patch)
tree9bd1199a62730ab3b724fa134eca43bd98f2a6b2 /tests
parent47c1cc30e440860aa695358f7c2dd0b9d7b53d16 (diff)
downloadqemu-d8336c6b286d9715bfe29a0e0b415dfd7891f671.zip
iotests: Replace time.clock() with Timeout
time.clock() is deprecated since Python 3.3. Current Python versions warn that the function will be removed in Python 3.8, and those warnings make the test case 118 fail. Replace it with the Timeout mechanism that is compatible with both Python 2 and 3, and makes the code even a little nicer. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests')
-rwxr-xr-xtests/qemu-iotests/11816
1 files changed, 6 insertions, 10 deletions
diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
index ff3b2ae3e7..c4f4c213ca 100755
--- a/tests/qemu-iotests/118
+++ b/tests/qemu-iotests/118
@@ -53,21 +53,17 @@ class ChangeBaseClass(iotests.QMPTestCase):
if not self.has_real_tray:
return
- timeout = time.clock() + 3
- while not self.has_opened and time.clock() < timeout:
- self.process_events()
- if not self.has_opened:
- self.fail('Timeout while waiting for the tray to open')
+ with iotests.Timeout(3, 'Timeout while waiting for the tray to open'):
+ while not self.has_opened:
+ self.process_events()
def wait_for_close(self):
if not self.has_real_tray:
return
- timeout = time.clock() + 3
- while not self.has_closed and time.clock() < timeout:
- self.process_events()
- if not self.has_opened:
- self.fail('Timeout while waiting for the tray to close')
+ with iotests.Timeout(3, 'Timeout while waiting for the tray to close'):
+ while not self.has_closed:
+ self.process_events()
class GeneralChangeTestsBaseClass(ChangeBaseClass):